git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] Fix running tests with --valgrind
@ 2016-07-11 11:45 Johannes Schindelin
  2016-07-11 15:29 ` Duy Nguyen
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schindelin @ 2016-07-11 11:45 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Duy Nguyen

We forgot to adjust this code path after moving the test helpers to
t/helper/.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
Published-As: https://github.com/dscho/git/releases/tag/valgrind-and-test-helpers-v1
 t/test-lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 0055ebb..493a92b 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -798,7 +798,7 @@ then
 	# override all git executables in TEST_DIRECTORY/..
 	GIT_VALGRIND=$TEST_DIRECTORY/valgrind
 	mkdir -p "$GIT_VALGRIND"/bin
-	for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/test-*
+	for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/t/helper/test-*
 	do
 		make_valgrind_symlink $file
 	done
-- 
2.9.0.278.g1caae67

base-commit: 5c589a73de4394ad125a4effac227b3aec856fa1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix running tests with --valgrind
  2016-07-11 11:45 [PATCH] Fix running tests with --valgrind Johannes Schindelin
@ 2016-07-11 15:29 ` Duy Nguyen
  0 siblings, 0 replies; 2+ messages in thread
From: Duy Nguyen @ 2016-07-11 15:29 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: Git Mailing List, Junio C Hamano

On Mon, Jul 11, 2016 at 1:45 PM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> We forgot to adjust this code path after moving the test helpers to
> t/helper/.

Oops. Yet it looks like the right thing to do.

>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> Published-As: https://github.com/dscho/git/releases/tag/valgrind-and-test-helpers-v1
>  t/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 0055ebb..493a92b 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -798,7 +798,7 @@ then
>         # override all git executables in TEST_DIRECTORY/..
>         GIT_VALGRIND=$TEST_DIRECTORY/valgrind
>         mkdir -p "$GIT_VALGRIND"/bin
> -       for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/test-*
> +       for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/t/helper/test-*
>         do
>                 make_valgrind_symlink $file
>         done
> --
> 2.9.0.278.g1caae67
>
> base-commit: 5c589a73de4394ad125a4effac227b3aec856fa1



-- 
Duy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-11 15:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 11:45 [PATCH] Fix running tests with --valgrind Johannes Schindelin
2016-07-11 15:29 ` Duy Nguyen

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).