From: Duy Nguyen <pclouds@gmail.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Fix running tests with --valgrind
Date: Mon, 11 Jul 2016 17:29:58 +0200 [thread overview]
Message-ID: <CACsJy8D5K5rbpXXrf-JXVrJCBXXgf78+_QeYUhOcAZW1hM=6CA@mail.gmail.com> (raw)
In-Reply-To: <80e5a1b53844d82c48eb16c88a962d9d693e0491.1468237495.git.johannes.schindelin@gmx.de>
On Mon, Jul 11, 2016 at 1:45 PM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> We forgot to adjust this code path after moving the test helpers to
> t/helper/.
Oops. Yet it looks like the right thing to do.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> Published-As: https://github.com/dscho/git/releases/tag/valgrind-and-test-helpers-v1
> t/test-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 0055ebb..493a92b 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -798,7 +798,7 @@ then
> # override all git executables in TEST_DIRECTORY/..
> GIT_VALGRIND=$TEST_DIRECTORY/valgrind
> mkdir -p "$GIT_VALGRIND"/bin
> - for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/test-*
> + for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/t/helper/test-*
> do
> make_valgrind_symlink $file
> done
> --
> 2.9.0.278.g1caae67
>
> base-commit: 5c589a73de4394ad125a4effac227b3aec856fa1
--
Duy
prev parent reply other threads:[~2016-07-11 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 11:45 [PATCH] Fix running tests with --valgrind Johannes Schindelin
2016-07-11 15:29 ` Duy Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8D5K5rbpXXrf-JXVrJCBXXgf78+_QeYUhOcAZW1hM=6CA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).