Re: [PATCH 1/5] i18n: keep the last \n even when text is poisoned

[Nguyen Thai Ngoc Duy <pclouds@gmail.com>]

2012/3/9 Jonathan Nieder <jrnieder@gmail.com>:
> I realize this was not the motivation behind the above patch, but if
> the translation of some message has to end with a newline for git to
> function correctly, would we consider that a bug?
>
> I am of two minds on that:
>
>  - on one hand, translators tend to be trustworthy, reasonable folks

We trust msgfmt and it does check \n in msgstr if there is in msgid.

>  - on the other hand, anything we can do to make the translation
>   process less fussy seems like time well spent

That's at the cost of more code to split \n out of the strings, and
there are 113 of them (some not published yet).

> The latter wins out for me, so I would prefer not to have this patch
> so the test suite can detect important newlines that should be not be
> part of the translatable string.

It's the former for me, but that's probably because I'm also a
translator :) Anyway for tricky cases where msgfmt fails to detect,
there's the role of l10n coordinators, who should review translation
and catch these errors.

> Just my two cents,
> Jonathan
-- 
Duy