From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
Git Mailing List <git@vger.kernel.org>,
Thomas Rast <tr@thomasrast.ch>
Subject: Re: FORMAT_PATCH_NAME_MAX increase
Date: Tue, 30 May 2017 16:35:42 +0200 [thread overview]
Message-ID: <CACBZZX7x7s-RfQMZjHuq=fbGtOeQzYin_Owqx7dK3v7dudh8zA@mail.gmail.com> (raw)
In-Reply-To: <xmqqfufmbh4f.fsf@gitster.mtv.corp.google.com>
On Tue, May 30, 2017 at 3:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Just curious do you know about https://github.com/trast/tbdiff ? If
>> not it might have a high overlap with what you're doing.
>
> Yes, that is a very good suggestion. You'd need to be able to
> actually apply the patches but the way I often do a review is very
> similar to (actually, I'd say it is identical workflow) Laszlo's,
> and it goes like this:
>
> $ git checkout topic ;# previous round
> $ git checkout master... ;# check out the fork point of previous one
> $ git am mbox ;# apply the updated one
> $ git tbdiff ..@{-1} @{-1}..
I wonder if this tool seemingly everyone on-list uses should just be
integrated into git.git.
I only learned about it <2 weeks ago and it's been great. The diff
output was a bit nonsensical in some cases because it uses python's
diff engine instead of git's.
Would you mind patches to just integrate it to git in python as-is,
then we could slowly convert it to C as we're doing with everything
else.
next prev parent reply other threads:[~2017-05-30 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 8:49 FORMAT_PATCH_NAME_MAX increase Laszlo Ersek
2017-05-30 1:34 ` Junio C Hamano
2017-05-30 11:03 ` Laszlo Ersek
2017-05-30 13:28 ` Junio C Hamano
2017-05-30 11:36 ` Ævar Arnfjörð Bjarmason
2017-05-30 12:28 ` Laszlo Ersek
2017-05-30 12:33 ` Laszlo Ersek
2017-05-30 12:41 ` Ævar Arnfjörð Bjarmason
2017-05-30 13:37 ` Junio C Hamano
2017-05-30 14:35 ` Ævar Arnfjörð Bjarmason [this message]
2017-05-30 15:06 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACBZZX7x7s-RfQMZjHuq=fbGtOeQzYin_Owqx7dK3v7dudh8zA@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lersek@redhat.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).