From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: FORMAT_PATCH_NAME_MAX increase
Date: Tue, 30 May 2017 13:36:41 +0200 [thread overview]
Message-ID: <CACBZZX5U=U1bpiFuuxH2t8ZWnmQQAjWm1ji8XYq_6-SJPGL1sw@mail.gmail.com> (raw)
In-Reply-To: <99ac8ee7-67b5-5ae7-51cf-6be38de6217f@redhat.com>
On Mon, May 29, 2017 at 10:49 AM, Laszlo Ersek <lersek@redhat.com> wrote:
> Hi,
>
> would it be possible to
>
> - increase the FORMAT_PATCH_NAME_MAX macro from 64 to, say, 128?
>
> - Or else to introduce a new git-config knob for it?
>
> I have a small review-helper / interdiff script that matches patches
> from adjacent versions of a series against each other, based on subject
> line. (Using the formatted file name with the patch number stripped.)
> The project in question uses long common prefixes in subjects, and the
> current limit of 64 does not always ensure unicity (again, with the
> number stripped).
I don't see why this shouldn't be made configurable, but more
generally if you have a script like this it seems like a futile effort
in general to just make the subject longer to solve the general case,
consider:
(cd /tmp/; rm -rf test; git init test; cd test && for i in {1..3};
do touch $i && git add $i && git commit -m"test"; done && git
format-patch -2 && git reset --hard HEAD~2 && git am *patch)
Which now yields:
0001-test.patch
0002-test.patch
Git projects in general will have plenty of patches like this, e.g.
"fix build" or "update tests" or whatever. Isn't a better solution for
your script to e.g. key on git-patch-id?
$ grep "^From " *patch
0001-test.patch:From 870e37afa1a5aeb7eef76e607345adcfd4a9022d Mon
Sep 17 00:00:00 2001
0002-test.patch:From de8c37a1532a4f6ae71ffa65400479ba77438f3b Mon
Sep 17 00:00:00 2001
$ cat *patch | git patch-id
c71eb8f2c8c461ba6040668e9d79f996f5a04a61
870e37afa1a5aeb7eef76e607345adcfd4a9022d
735aff6fb601d7ce99506dc7701be3e8a9b5d38c
de8c37a1532a4f6ae71ffa65400479ba77438f3b
Other potential heuristics could be keying not just on the subject but
on the subject + subject of the last N commits for each commit, which
should give more of a unique key, or key on the whole commit message
etc.
next prev parent reply other threads:[~2017-05-30 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 8:49 FORMAT_PATCH_NAME_MAX increase Laszlo Ersek
2017-05-30 1:34 ` Junio C Hamano
2017-05-30 11:03 ` Laszlo Ersek
2017-05-30 13:28 ` Junio C Hamano
2017-05-30 11:36 ` Ævar Arnfjörð Bjarmason [this message]
2017-05-30 12:28 ` Laszlo Ersek
2017-05-30 12:33 ` Laszlo Ersek
2017-05-30 12:41 ` Ævar Arnfjörð Bjarmason
2017-05-30 13:37 ` Junio C Hamano
2017-05-30 14:35 ` Ævar Arnfjörð Bjarmason
2017-05-30 15:06 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACBZZX5U=U1bpiFuuxH2t8ZWnmQQAjWm1ji8XYq_6-SJPGL1sw@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=lersek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).