From: Laszlo Ersek <lersek@redhat.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Thomas Rast" <tr@thomasrast.ch>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: FORMAT_PATCH_NAME_MAX increase
Date: Tue, 30 May 2017 17:06:11 +0200 [thread overview]
Message-ID: <36557854-907f-9bb0-2059-c97328e1ca41@redhat.com> (raw)
In-Reply-To: <CACBZZX7x7s-RfQMZjHuq=fbGtOeQzYin_Owqx7dK3v7dudh8zA@mail.gmail.com>
On 05/30/17 16:35, Ævar Arnfjörð Bjarmason wrote:
> On Tue, May 30, 2017 at 3:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>> Just curious do you know about https://github.com/trast/tbdiff ? If
>>> not it might have a high overlap with what you're doing.
Thank you for the suggestion, it does exactly what I need. It solves the
Assignment Problem a whole lot better than my current, crude script.
https://en.wikipedia.org/wiki/Assignment_problem
https://en.wikipedia.org/wiki/Hungarian_algorithm
(Mildly amusing, to me anyway: I happen to be Hungarian.)
The output of git-tbdiff is not exactly the way I like it (I like to
review interdiffs colorized, and fed to $PAGER individually), but I can
easily do that on top of the "--no-patches" output.
>> Yes, that is a very good suggestion. You'd need to be able to
>> actually apply the patches but the way I often do a review is very
>> similar to (actually, I'd say it is identical workflow) Laszlo's,
>> and it goes like this:
>>
>> $ git checkout topic ;# previous round
>> $ git checkout master... ;# check out the fork point of previous one
>> $ git am mbox ;# apply the updated one
>> $ git tbdiff ..@{-1} @{-1}..
>
> I wonder if this tool seemingly everyone on-list uses should just be
> integrated into git.git.
>
> I only learned about it <2 weeks ago and it's been great. The diff
> output was a bit nonsensical in some cases because it uses python's
> diff engine instead of git's.
Yes, I'd probably plug in git's diff engine (the patience algorithm at
that).
>
> Would you mind patches to just integrate it to git in python as-is,
> then we could slowly convert it to C as we're doing with everything
> else.
That would be wonderful. My preference would be to use core git features
for solving the problem; as a second preference, it would be great if
git-tbdiff were packaged & shipped by GNU/Linux distros.
Thomas (I see you are on To:/Cc: now -- I meant to CC you, snarfing your
email from the git.git history :) ), are you aware of any distros
already packaging git-tbdiff?
Still the best would be if git provided this feature out of the box;
incremental review of rerolled series appears a common activity for any
serious reviewer / subsystem co-maintainer.
Thanks!
Laszlo
prev parent reply other threads:[~2017-05-30 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 8:49 FORMAT_PATCH_NAME_MAX increase Laszlo Ersek
2017-05-30 1:34 ` Junio C Hamano
2017-05-30 11:03 ` Laszlo Ersek
2017-05-30 13:28 ` Junio C Hamano
2017-05-30 11:36 ` Ævar Arnfjörð Bjarmason
2017-05-30 12:28 ` Laszlo Ersek
2017-05-30 12:33 ` Laszlo Ersek
2017-05-30 12:41 ` Ævar Arnfjörð Bjarmason
2017-05-30 13:37 ` Junio C Hamano
2017-05-30 14:35 ` Ævar Arnfjörð Bjarmason
2017-05-30 15:06 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36557854-907f-9bb0-2059-c97328e1ca41@redhat.com \
--to=lersek@redhat.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).