From: Brandon Casey <drafnel@gmail.com>
To: Joey Hess <joey@kitenet.net>
Cc: Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces
Date: Fri, 2 Aug 2013 09:14:45 -0700 [thread overview]
Message-ID: <CA+sFfMdeGCfWbXfv7YqZi4zZj6RhDaugVgHJNu_Fhmx35wi=8Q@mail.gmail.com> (raw)
In-Reply-To: <20130802152713.GA23548@gnu.kitenet.net>
On Fri, Aug 2, 2013 at 8:27 AM, Joey Hess <joey@kitenet.net> wrote:
> Jeff King wrote:
>> By the way, Joey, I am not sure how safe "git cat-file --batch-check" is
>> for arbitrary filenames. In particular, I don't know how it would react
>> to a filename with an embedded newline (and I do not think it will undo
>> quoting). Certainly that does not excuse this regression; even if what
>> you are doing is not 100% reliable, it is good enough in sane situations
>> and we should not be breaking it. But you may want to double-check the
>> behavior of your scripts in such a case, and we may need to add a "-z"
>> to support it reliably.
>
> Yes, I would prefer to have a -z mode. I think my code otherwise handles
> newlines.
>
> Thanks for the quick fix. I agree that only enabling the behavior with
> %{rest} makes sense.
>
> --
> see shy jo
/methinks we've identified a gap in our test coverage. Care to add a
test that covers the functionality that git-annex depends on?
-Brandon
next prev parent reply other threads:[~2013-08-02 16:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130801201842.GA16809@kitenet.net>
2013-08-02 6:40 ` [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces Jonathan Nieder
2013-08-02 10:54 ` Jeff King
2013-08-02 11:59 ` Jeff King
2013-08-02 15:27 ` Joey Hess
2013-08-02 16:14 ` Brandon Casey [this message]
2013-08-02 16:41 ` Junio C Hamano
2013-08-02 17:28 ` Jeff King
2013-08-02 18:30 ` Junio C Hamano
2013-08-02 20:05 ` Jonathan Nieder
2013-08-03 7:18 ` Jeff King
2013-08-02 16:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+sFfMdeGCfWbXfv7YqZi4zZj6RhDaugVgHJNu_Fhmx35wi=8Q@mail.gmail.com' \
--to=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joey@kitenet.net \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).