From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Joey Hess <joeyh@debian.org>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces
Date: Fri, 2 Aug 2013 03:54:02 -0700 [thread overview]
Message-ID: <20130802105402.GA25697@sigill.intra.peff.net> (raw)
In-Reply-To: <20130802064003.GB3013@elie.Belkin>
On Thu, Aug 01, 2013 at 11:40:03PM -0700, Jonathan Nieder wrote:
> > Commit c334b87b30c1464a1ab563fe1fb8de5eaf0e5bac caused a reversion in
> > git-cat-file --batch.
> >
> > With an older version:
> >
> > joey@gnu:~/tmp/rrr>git cat-file --batch
> > :file name
> > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 blob 0
> >
> > With the new version:
> >
> > joey@wren:~/tmp/r>git cat-file --batch
> > :file name
> > :file missing
> [...]
> Oh dear. Luckily you caught this before the final 1.8.4 release. I
> wonder if we should just revert c334b87b (cat-file: split --batch
> input lines on whitespace, 2013-07-11) for now.
Ugh. Yeah, the incorrect assumption from the commit message of c334b87b
is "Object names cannot contain spaces...". Refs cannot, but filename
specifiers after a colon can.
We need to revert that commit before the release. It can either be
replaced with:
1. A "--split" (or similar) option to use the behavior only when
desired.
2. Enabling splitting only when %(rest) is used in the output format.
And I suppose it is too late in the cycle for either of those to go into
v1.8.4. That's a shame, but I think losing that particular patch does
not affect the rest of the series, so we are OK to ship without it.
Thanks Joey for a timely bug report.
-Peff
next prev parent reply other threads:[~2013-08-02 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130801201842.GA16809@kitenet.net>
2013-08-02 6:40 ` [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces Jonathan Nieder
2013-08-02 10:54 ` Jeff King [this message]
2013-08-02 11:59 ` Jeff King
2013-08-02 15:27 ` Joey Hess
2013-08-02 16:14 ` Brandon Casey
2013-08-02 16:41 ` Junio C Hamano
2013-08-02 17:28 ` Jeff King
2013-08-02 18:30 ` Junio C Hamano
2013-08-02 20:05 ` Jonathan Nieder
2013-08-03 7:18 ` Jeff King
2013-08-02 16:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802105402.GA25697@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joeyh@debian.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).