From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Joey Hess <joeyh@debian.org>,
git@vger.kernel.org
Subject: Re: [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces
Date: Fri, 02 Aug 2013 09:41:52 -0700 [thread overview]
Message-ID: <7vtxj8oxin.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130802115906.GA9183@sigill.intra.peff.net> (Jeff King's message of "Fri, 2 Aug 2013 04:59:07 -0700")
Jeff King <peff@peff.net> writes:
> On Fri, Aug 02, 2013 at 03:54:02AM -0700, Jeff King wrote:
>
>> We need to revert that commit before the release. It can either be
>> replaced with:
>>
>> 1. A "--split" (or similar) option to use the behavior only when
>> desired.
>>
>> 2. Enabling splitting only when %(rest) is used in the output format.
>
> Of the two, I think the latter is more sensible; the former is
> unnecessarily placing the burden on the user to match "--split" with
> their use of "%(rest)". The second is pointless without the first.
>
> A patch to implement (2) is below.
As I'd queue this on top of the revert, I had to wrangle it a bit to
make it relative, i.e. "this resurrects what the other reverted
patch did but in a weaker/safer form".
This will be kept outside this cycle. Thanks for a quick fix.
next prev parent reply other threads:[~2013-08-02 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130801201842.GA16809@kitenet.net>
2013-08-02 6:40 ` [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces Jonathan Nieder
2013-08-02 10:54 ` Jeff King
2013-08-02 11:59 ` Jeff King
2013-08-02 15:27 ` Joey Hess
2013-08-02 16:14 ` Brandon Casey
2013-08-02 16:41 ` Junio C Hamano [this message]
2013-08-02 17:28 ` Jeff King
2013-08-02 18:30 ` Junio C Hamano
2013-08-02 20:05 ` Jonathan Nieder
2013-08-03 7:18 ` Jeff King
2013-08-02 16:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtxj8oxin.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=joeyh@debian.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).