From: Lars Schneider <larsxschneider@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Luke Diamand" <luke@diamand.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems
Date: Fri, 21 Aug 2015 10:08:09 +0200 [thread overview]
Message-ID: <C80E3141-C247-439B-97B5-562881C127F3@gmail.com> (raw)
In-Reply-To: <xmqq37ze7y4o.fsf@gitster.dls.corp.google.com>
@Luke, Torsten, Eric, Junio:
Thanks for the great feedback. I incorporated everything into "[PATCH v3] git-p4: fix faulty paths for case insensitive systems”.
Is this the correct way? I have never worked with the email-patch-files before :-)
- Lars
On 20 Aug 2015, at 17:55, Junio C Hamano <gitster@pobox.com> wrote:
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>>>> + find . | grep TWO/file1.txt &&
>>>> + find . | grep TWO/File2.txt &&
>>>> + find . | grep TWO/file3.txt &&
>>> Not sure about the find | grep here either.
>> See answers above.
>
> These are not very good tests; they will match "OTWO/file1.txto",
> too. Besides, it is wasteful to run find three times.
>
> find ?* -print | sort >actual &&
> cat >expect <<-\EOF &&
> TWO/file1.txt
> ...
> EOF
> test_cmp expect actual
>
> or something like that instead?
next prev parent reply other threads:[~2015-08-21 8:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 20:04 [PATCH v2] git-p4: fix faulty paths for case insensitive systems larsxschneider
2015-08-19 20:04 ` larsxschneider
2015-08-20 4:59 ` Torsten Bögershausen
2015-08-20 7:16 ` Lars Schneider
2015-08-20 13:17 ` Eric Sunshine
2015-08-20 15:55 ` Junio C Hamano
2015-08-21 8:08 ` Lars Schneider [this message]
2015-08-21 8:10 ` Eric Sunshine
2015-08-20 19:02 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C80E3141-C247-439B-97B5-562881C127F3@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke@diamand.org \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).