From: "Torsten Bögershausen" <tboegi@web.de>
To: "Lars Schneider" <larsxschneider@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org, luke@diamand.org, pw@padd.com,
torarvid@gmail.com, ksaitoh560@gmail.com
Subject: Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems
Date: Thu, 20 Aug 2015 21:02:29 +0200 [thread overview]
Message-ID: <55D62445.5030402@web.de> (raw)
In-Reply-To: <917E3751-4BC8-4034-9101-30C77426D81C@gmail.com>
On 2015-08-20 09.16, Lars Schneider wrote:
> Thanks for your feedback! See my answers below.
>> Identify path names that are different with respect to case sensitivity.
> Agreed!
>
>>
>>
>>> If there are any then run `p4 dirs` to build up a dictionary
>>> containing the "correct" cases for each path. It looks like P4
>>> interprets "correct" here as the existing path of the first file in a
>>> directory. The path dictionary is used later on to fix all paths.
>>>
>>> This is only applied if the parameter "--fix-paths" is passed to the
>>> git-p4 clone command.
>> The "fix-path" doesn't tell a user what exactly is fixed.
>> Something like "fix-path-case" may be more self-explaining,
>> but I would simply use "--ignore-case", which is more in line
>> with Git. (But this is debatable)
> I agree but “—ignore-case” seems a bit broad to me. How about “—ignore-path-case”? Because it is really only about paths case, not filename case.
OK, better.
>>> - def update_client_spec_path_cache(self, files):
>>> + def update_client_spec_path_cache(self, files, fixPathCase = None):
If you want, you can change the name of the parameter into ignorePathCase,
but I'm not sure...
> Can you try to rephrase your comment? I don’t get it. My “cd command” is already in parenthesis (== subshell), no?
I may have commented on the wrong TC :-(
This is the one:
+test_expect_success 'Create a repo with path case variations' '
+ client_view "//depot/... //client/..." &&
+ cd "$cli" &&
+
+ mkdir -p One/two &&
+ [snip]
+'
which should be like this:
+test_expect_success 'Create a repo with path case variations' '
+ client_view "//depot/... //client/..." &&
+ (
+ cd "$cli" &&
+ mkdir -p One/two &&
+ [snip]
+ )
+'
prev parent reply other threads:[~2015-08-20 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 20:04 [PATCH v2] git-p4: fix faulty paths for case insensitive systems larsxschneider
2015-08-19 20:04 ` larsxschneider
2015-08-20 4:59 ` Torsten Bögershausen
2015-08-20 7:16 ` Lars Schneider
2015-08-20 13:17 ` Eric Sunshine
2015-08-20 15:55 ` Junio C Hamano
2015-08-21 8:08 ` Lars Schneider
2015-08-21 8:10 ` Eric Sunshine
2015-08-20 19:02 ` Torsten Bögershausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D62445.5030402@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=ksaitoh560@gmail.com \
--cc=larsxschneider@gmail.com \
--cc=luke@diamand.org \
--cc=pw@padd.com \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).