Gitk : When the number of commits is small, you can roll up excessively

Gitk : When the number of commits is small, you can roll up excessively

[L2750558108]

Gitk : When the number of commits is small, you can roll up excessively







Reduce :



1.Create a new respository
2.Make 2 Commit
3.Go to Gitk to see them
4.Scroll up in the commit list and you can see the error

Re: Gitk : When the number of commits is small, you can roll up excessively

[Philip Oakley]

A bit of a late response..
On 14/02/2023 06:02, L2750558108@outlook.com wrote:
> Gitk : When the number of commits is small, you can roll up excessively
>
> Reduce :
>
> 1.Create a new respository
> 2.Make 2 Commit
> 3.Go to Gitk to see them
> 4.Scroll up in the commit list and you can see the error
I cannot replicate this problem (on Git-for-Windows git version
2.39.2.windows.1).

What OS, Git and gitk versions are you on?

I created the repo with the commands
phili@Philip-Win10 MINGW64 /c/git-sdk-64/usr/src (main)
$ git init gitkfault
$ cd gitkfault/
$ echo test>file;git add file;git commit -mfirst
$ echo test2>file;git add file;git commit -msecond
$ gitk &
[1] 1021

I was visualising the commits (lower gitk window) with the "Diff" and
"Patch" settings.
 
At your step 4, I tried 'scrolling up' both by mouse clicking on the two
commits in the top left window that displays the history, and by using
the left/right arrows displayed just right of the "SHA1 ID" value. No
errors were shown.

(those sha1 arrows are distinct from the 'Find' selection and navigation
capability immediately below the "SHA1 ID" line.

What were the exact errors shown at your step 4?

--
Philip

Re: Gitk : When the number of commits is small, you can roll up excessively

[Philip Oakley]

On 27/02/2023 05:01, L2750558108@outlook.com wrote:
> You can scroll up via the scroll wheel or the right column button and
> see the white space in front of the first row, and in this case, the
> collision box for each row is misaligned, which prevents me from
> selecting the commit by clicking. If you stll not understand, I can
> send a picture or video to show the situation I am experiencing,

I see the space above (which I guess is for 'uncommitted changes',
should they exist) and a small space below when scrolling.
I'm unsure what the 'collision box' refers to as I don't see any
'misalignment'. But I maybe just too familiar with gitk's quirks.

> but I don't know where to put them
>

The https://groups.google.com/g/git-users does allow (If I remember
correctly) the inclusion of photos. Please do annotate/label the screen
shots. Plain text doesn't always carry the expected nuances...
>  
> ------------------------------------------------------------------------
> L2750558108@outlook.com
>
>      
>     From: Philip Oakley <mailto:philipoakley@iee.email>
>     Date: 2023-02-26 20:26
>     To: L2750558108@outlook.com; git <mailto:git@vger.kernel.org>
>     Subject: Re: Gitk : When the number of commits is small, you can
>     roll up excessively
>     A bit of a late response..
>     On 14/02/2023 06:02, L2750558108@outlook.com wrote:
>     > Gitk : When the number of commits is small, you can roll up
>     excessively
>     >
>     > Reduce :
>     >
>     > 1.Create a new respository
>     > 2.Make 2 Commit
>     > 3.Go to Gitk to see them
>     > 4.Scroll up in the commit list and you can see the error
>     I cannot replicate this problem (on Git-for-Windows git version
>     2.39.2.windows.1).
>
>     What OS, Git and gitk versions are you on?
>
>     I created the repo with the commands
>     phili@Philip-Win10 MINGW64 /c/git-sdk-64/usr/src (main)
>     $ git init gitkfault
>     $ cd gitkfault/
>     $ echo test>file;git add file;git commit -mfirst
>     $ echo test2>file;git add file;git commit -msecond
>     $ gitk &
>     [1] 1021
>
>     I was visualising the commits (lower gitk window) with the "Diff" and
>     "Patch" settings.
>      
>     At your step 4, I tried 'scrolling up' both by mouse clicking on
>     the two
>     commits in the top left window that displays the history, and by
>     using
>     the left/right arrows displayed just right of the "SHA1 ID" value. No
>     errors were shown.
>
>     (those sha1 arrows are distinct from the 'Find' selection and
>     navigation
>     capability immediately below the "SHA1 ID" line.
>
>     What were the exact errors shown at your step 4?
>
>     -- 
>     Philip
>

Re: Gitk : When the number of commits is small, you can roll up excessively

[Johannes Sixt]

Am 27.02.23 um 11:00 schrieb Philip Oakley:
> On 27/02/2023 05:01, L2750558108@outlook.com wrote:
>> You can scroll up via the scroll wheel or the right column button and
>> see the white space in front of the first row, and in this case, the
>> collision box for each row is misaligned, which prevents me from
>> selecting the commit by clicking. If you stll not understand, I can
>> send a picture or video to show the situation I am experiencing,
> 
> I see the space above (which I guess is for 'uncommitted changes',
> should they exist) and a small space below when scrolling.
> I'm unsure what the 'collision box' refers to as I don't see any
> 'misalignment'. But I maybe just too familiar with gitk's quirks.

The issue is this: When there is vertical space for a list of, say, 10
commits, but there are only 3 commits, then you can scroll the display
such that the 3 commit lines are at the bottom of the list and there is
blank space above the lines. Now, when you click on one of the lines,
nothing happens; but when you click into the void near the top, one of
the lines is selected as if the lines were displayed at the top.
Clearly, the click hitbox for the lines is not aligned with how the
lines are displayed.

IMHO, this is a case of "if it hurts, don't do it".

-- Hannes