git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Philip Oakley <philipoakley@iee.email>
Cc: "L2750558108@outlook.com" <L2750558108@outlook.com>,
	git <git@vger.kernel.org>
Subject: Re: Gitk : When the number of commits is small, you can roll up excessively
Date: Tue, 28 Feb 2023 07:35:41 +0100	[thread overview]
Message-ID: <75afffcd-65f8-e8e2-1cd9-51806194e4b3@kdbg.org> (raw)
In-Reply-To: <15d5c6c5-091a-63b1-979a-5aaa64c9e717@iee.email>

Am 27.02.23 um 11:00 schrieb Philip Oakley:
> On 27/02/2023 05:01, L2750558108@outlook.com wrote:
>> You can scroll up via the scroll wheel or the right column button and
>> see the white space in front of the first row, and in this case, the
>> collision box for each row is misaligned, which prevents me from
>> selecting the commit by clicking. If you stll not understand, I can
>> send a picture or video to show the situation I am experiencing,
> 
> I see the space above (which I guess is for 'uncommitted changes',
> should they exist) and a small space below when scrolling.
> I'm unsure what the 'collision box' refers to as I don't see any
> 'misalignment'. But I maybe just too familiar with gitk's quirks.

The issue is this: When there is vertical space for a list of, say, 10
commits, but there are only 3 commits, then you can scroll the display
such that the 3 commit lines are at the bottom of the list and there is
blank space above the lines. Now, when you click on one of the lines,
nothing happens; but when you click into the void near the top, one of
the lines is selected as if the lines were displayed at the top.
Clearly, the click hitbox for the lines is not aligned with how the
lines are displayed.

IMHO, this is a case of "if it hurts, don't do it".

-- Hannes


      reply	other threads:[~2023-02-28  6:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  6:02 Gitk : When the number of commits is small, you can roll up excessively L2750558108
2023-02-26 12:26 ` Philip Oakley
     [not found]   ` <CH2PR14MB35637B8C5593D5F17076E7EEB1AF9@CH2PR14MB3563.namprd14.prod.outlook.com>
2023-02-27 10:00     ` Philip Oakley
2023-02-28  6:35       ` Johannes Sixt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75afffcd-65f8-e8e2-1cd9-51806194e4b3@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=L2750558108@outlook.com \
    --cc=git@vger.kernel.org \
    --cc=philipoakley@iee.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).