From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: What's cooking in git.git (Oct 2010, #01; Wed, 13)
Date: Thu, 14 Oct 2010 09:23:36 +0000 [thread overview]
Message-ID: <AANLkTimr73DUBBwdj9MXOQQ=O-vmyyEZpgwdHmRsGG_-@mail.gmail.com> (raw)
In-Reply-To: <7v39s9fkk1.fsf@alter.siamese.dyndns.org>
On Thu, Oct 14, 2010 at 04:46, Junio C Hamano <gitster@pobox.com> wrote:
> - test-lib: make test_expect_code a test command
>
> Somewhat rerolled, but the largest one among the series was Nacked by a
> few people and needs to be rerolled again.
Why did you amend this to use this sed trick:
+sed -e 's/Z$//' >expect <<\EOF &&
+not ok - 1 tests clean up even after a failure
+# Z
+# touch clean-after-failure &&
+# test_when_finished rm clean-after-failure &&
+# (exit 1)
+# Z
+not ok - 2 failure to clean up causes the test to fail
+# Z
+# test_when_finished \"(exit 2)\"
+# Z
Is it just to keep it diff --check clean?
Anyway if we munge the output like this the output of test_cmp will be
more confusing when it fails, because it'll be diff(1)-ing something
that the test-lib would never emit.
> * ab/i18n (2010-09-12) 159 commits
Could you please pick up the 160 commit version of this at:
git://github.com/avar/git.git ab/i18n
It has the new "gettext.c: use libcharset.h instead of langinfo.h when
available" patch by Erik Faye-Lund and me, which would be nice to have
tested in pu.
next prev parent reply other threads:[~2010-10-14 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 4:46 What's cooking in git.git (Oct 2010, #01; Wed, 13) Junio C Hamano
2010-10-14 5:51 ` Nazri Ramliy
2010-10-14 9:23 ` Ævar Arnfjörð Bjarmason [this message]
2010-10-14 20:00 ` Stable ab/i18n branch Jonathan Nieder
2010-10-14 20:44 ` Ævar Arnfjörð Bjarmason
2010-10-14 20:54 ` Jonathan Nieder
2010-10-14 21:18 ` Ævar Arnfjörð Bjarmason
2010-10-14 21:26 ` Sverre Rabbelier
2010-10-14 21:50 ` Jon Seymour
2010-10-15 4:54 ` Ævar Arnfjörð Bjarmason
2010-10-15 0:07 ` Jonathan Nieder
2010-10-15 5:16 ` Ævar Arnfjörð Bjarmason
2010-10-15 5:28 ` Jonathan Nieder
2010-10-15 5:35 ` Ævar Arnfjörð Bjarmason
2010-10-17 4:44 ` Junio C Hamano
2010-10-17 12:33 ` Ævar Arnfjörð Bjarmason
2010-10-17 15:59 ` Jonathan Nieder
2010-10-18 23:39 ` Junio C Hamano
2010-10-19 6:05 ` Michael J Gruber
2010-10-17 4:43 ` What's cooking in git.git (Oct 2010, #01; Wed, 13) Junio C Hamano
2010-10-21 2:14 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimr73DUBBwdj9MXOQQ=O-vmyyEZpgwdHmRsGG_-@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).