From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: What's cooking in git.git (Oct 2010, #01; Wed, 13)
Date: Sat, 16 Oct 2010 21:43:40 -0700 [thread overview]
Message-ID: <7vk4lh5szn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: AANLkTimr73DUBBwdj9MXOQQ=O-vmyyEZpgwdHmRsGG_-@mail.gmail.com
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Thu, Oct 14, 2010 at 04:46, Junio C Hamano <gitster@pobox.com> wrote:
>
>> - test-lib: make test_expect_code a test command
>>
>> Somewhat rerolled, but the largest one among the series was Nacked by a
>> few people and needs to be rerolled again.
>
> Why did you amend this to use this sed trick:
>
> +sed -e 's/Z$//' >expect <<\EOF &&
> +not ok - 1 tests clean up even after a failure
> +# Z
> +# touch clean-after-failure &&
> +# test_when_finished rm clean-after-failure &&
> +# (exit 1)
> +# Z
> +not ok - 2 failure to clean up causes the test to fail
> +# Z
> +# test_when_finished \"(exit 2)\"
> +# Z
>
> Is it just to keep it diff --check clean?
Yes and files with trailing whitespaces are hard to understand in general
when reading, even outside the "should I apply that patch?" contenxt.
> Anyway if we munge the output like this the output of test_cmp will be
> more confusing when it fails, because it'll be diff(1)-ing something
> that the test-lib would never emit.
Hmm, why? "expect" has trailing whitespaces on lines that end with Z,
i.e. what the original patch wanted to place in.
next prev parent reply other threads:[~2010-10-17 4:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 4:46 What's cooking in git.git (Oct 2010, #01; Wed, 13) Junio C Hamano
2010-10-14 5:51 ` Nazri Ramliy
2010-10-14 9:23 ` Ævar Arnfjörð Bjarmason
2010-10-14 20:00 ` Stable ab/i18n branch Jonathan Nieder
2010-10-14 20:44 ` Ævar Arnfjörð Bjarmason
2010-10-14 20:54 ` Jonathan Nieder
2010-10-14 21:18 ` Ævar Arnfjörð Bjarmason
2010-10-14 21:26 ` Sverre Rabbelier
2010-10-14 21:50 ` Jon Seymour
2010-10-15 4:54 ` Ævar Arnfjörð Bjarmason
2010-10-15 0:07 ` Jonathan Nieder
2010-10-15 5:16 ` Ævar Arnfjörð Bjarmason
2010-10-15 5:28 ` Jonathan Nieder
2010-10-15 5:35 ` Ævar Arnfjörð Bjarmason
2010-10-17 4:44 ` Junio C Hamano
2010-10-17 12:33 ` Ævar Arnfjörð Bjarmason
2010-10-17 15:59 ` Jonathan Nieder
2010-10-18 23:39 ` Junio C Hamano
2010-10-19 6:05 ` Michael J Gruber
2010-10-17 4:43 ` Junio C Hamano [this message]
2010-10-21 2:14 ` What's cooking in git.git (Oct 2010, #01; Wed, 13) Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk4lh5szn.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).