git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: Stable ab/i18n branch
Date: Fri, 15 Oct 2010 05:16:32 +0000	[thread overview]
Message-ID: <AANLkTim0a7J5L1dtZNYTG7strEhjitZein5CVQayZFRh@mail.gmail.com> (raw)
In-Reply-To: <20101015000749.GD29494@burratino>

On Fri, Oct 15, 2010 at 00:07, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> While that's not a perfect solution I think it's the best we're going
>> to get for the time being. I'm pretty convinced that if I tried to
>> make git itself LC_CTYPE-safe as part of this already huge series it'd
>> never get merged. Having messages with question marks from strerror()
>> on certain platforms is an OK compromise in my opinion.
>
> The question marks[1] are what I was referring to.  Consider this from
> the point of view of someone working on the Debian package: would
> users consider that an appropriate or positive change for squeeze+1?
> (Hint: not if it doesn't come with some benefit in their locale, no.)

No benefit? The benefit is that the program they previously either
didn't understand or understood poorly is now talking to them in their
native language. That's a pretty big benefit.

The tradeoff is that a small subset of the messages which include
strerror() output will show non-ASCII characters as question marks on
GNU systems.

Don't get me wrong. I think it's a bug that we need to fix. I just
think it's a relatively minor annoyance, not a showstopper. With it
the feature *mostly* just works, and the things that don't can be
documented by the Debian maintainer and others as a known bug.

> I suspect making git work with other LC_CTYPE would not actually be
> too hard[2].  Such fixes are useful for futureproofing and increased
> sanity anyway --- they do not have to be part of the l10n branch imho.

It's something we want yes, but not something I have time for these
days. So unless someone else is interested in helping audit all that
code, providing a printf() fallback on glibc etc. it'll block the i18n
series.

For something I at least think is a relatively minor issue that
doesn't warrant throwing the baby out with the bathwater.

  reply	other threads:[~2010-10-15  5:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-14  4:46 What's cooking in git.git (Oct 2010, #01; Wed, 13) Junio C Hamano
2010-10-14  5:51 ` Nazri Ramliy
2010-10-14  9:23 ` Ævar Arnfjörð Bjarmason
2010-10-14 20:00   ` Stable ab/i18n branch Jonathan Nieder
2010-10-14 20:44     ` Ævar Arnfjörð Bjarmason
2010-10-14 20:54       ` Jonathan Nieder
2010-10-14 21:18         ` Ævar Arnfjörð Bjarmason
2010-10-14 21:26           ` Sverre Rabbelier
2010-10-14 21:50           ` Jon Seymour
2010-10-15  4:54             ` Ævar Arnfjörð Bjarmason
2010-10-15  0:07           ` Jonathan Nieder
2010-10-15  5:16             ` Ævar Arnfjörð Bjarmason [this message]
2010-10-15  5:28               ` Jonathan Nieder
2010-10-15  5:35                 ` Ævar Arnfjörð Bjarmason
2010-10-17  4:44     ` Junio C Hamano
2010-10-17 12:33       ` Ævar Arnfjörð Bjarmason
2010-10-17 15:59         ` Jonathan Nieder
2010-10-18 23:39         ` Junio C Hamano
2010-10-19  6:05           ` Michael J Gruber
2010-10-17  4:43   ` What's cooking in git.git (Oct 2010, #01; Wed, 13) Junio C Hamano
2010-10-21  2:14 ` Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTim0a7J5L1dtZNYTG7strEhjitZein5CVQayZFRh@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=kusmabite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).