git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Jakub Narebski <jnareb@gmail.com>
Subject: Re: [RFC PATCH] Makefile: Turn off the configure target by default
Date: Mon, 11 Oct 2010 07:59:09 +0000	[thread overview]
Message-ID: <AANLkTikGSj-x4hk7NFysWETuR80=REZ81Qy8Zu3Pks-L@mail.gmail.com> (raw)
In-Reply-To: <36e21bdafd75e95f1e13437f81067c71c7390408.1286783121.git.git@drmicha.warpmail.net>

On Mon, Oct 11, 2010 at 07:47, Michael J Gruber
<git@drmicha.warpmail.net> wrote:

(CC-ing Jakub Narebski, who maintains configure.ac)

I don't like it. For one this would break build scripts that use `make
configure && ./configure && ...`. It's also annoying to have to set
some variable to *really* invoke a target that I just indicated I
*really* wanted by invoking it in the first place.

Perhaps a @echo from the configure script itself indicating that it's
complimentary would be better.

> For most software packages, untar-autoconf/make configure-configure-make
> is the preferred way to build the package; not so for Git. But the
> presence of the make target makes people believe so.

Unlike in most packages autoconf is strictly complimentary for Git,
but it usually gives you much better results. Instead of the Makefile
guessing based on `uname -s` we actually check for features and set
the config.mak.autogen variables accordingly.

So it's less likely to break on odd systems, and given that (as you
point out) mostly everyone has autoconf already recommending it as the
default would make more sense than the other way around.

>    On an annecdotical note: When I decided to switch to a dvcs, I failed building
>    Git (with configure) and tried out hg instead. Imagine!

What sort of failure? Has it been fixed since then?

  reply	other threads:[~2010-10-11  7:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11  7:47 [RFC PATCH] Makefile: Turn off the configure target by default Michael J Gruber
2010-10-11  7:59 ` Ævar Arnfjörð Bjarmason [this message]
2010-10-11  8:39   ` Jakub Narebski
2010-10-11  9:40     ` Ævar Arnfjörð Bjarmason
2010-10-11 12:10       ` Michael J Gruber
2010-10-11 12:37         ` [RFC PATCH] Makefile: point out "make" if "make configure" fails Ævar Arnfjörð Bjarmason
2010-10-11 15:06           ` Jakub Narebski
2010-10-11 20:46             ` Sverre Rabbelier
2010-10-11 15:18         ` [RFC PATCH] Makefile: Turn off the configure target by default Jakub Narebski
2010-10-11 15:28           ` Michael J Gruber
2010-10-11 16:21             ` Ævar Arnfjörð Bjarmason
2010-10-11 16:26               ` Jonathan Nieder
2010-10-12  8:33                 ` Michael J Gruber
2010-10-12  9:10                   ` Tor Arntsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikGSj-x4hk7NFysWETuR80=REZ81Qy8Zu3Pks-L@mail.gmail.com' \
    --to=avarab@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).