From: Michael J Gruber <git@drmicha.warpmail.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [RFC PATCH] Makefile: Turn off the configure target by default
Date: Mon, 11 Oct 2010 09:47:03 +0200 [thread overview]
Message-ID: <36e21bdafd75e95f1e13437f81067c71c7390408.1286783121.git.git@drmicha.warpmail.net> (raw)
For most software packages, untar-autoconf/make configure-configure-make
is the preferred way to build the package; not so for Git. But the
presence of the make target makes people believe so.
Try and make people use "make configure" only when they are sure they
need to.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
This does not help with people running autoconf themselves, of course.
But we keep answering questions about failed configure attempts.
On an annecdotical note: When I decided to switch to a dvcs, I failed building
Git (with configure) and tried out hg instead. Imagine!
Makefile | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 1f1ce04..430c096 100644
--- a/Makefile
+++ b/Makefile
@@ -1744,11 +1744,18 @@ $(patsubst %.py,%,$(SCRIPT_PYTHON)): % : unimplemented.sh
endif # NO_PYTHON
configure: configure.ac
+ifdef USEAUTOCONF
$(QUIET_GEN)$(RM) $@ $<+ && \
sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \
$< > $<+ && \
autoconf -o $@ $<+ && \
$(RM) $<+
+else
+ @echo "Using the Makefile and defining variables in config.mak is the"
+ @echo "preferred way of building Git. Please use"
+ @echo "USEAUTOCONF=1 make configure"
+ @echo "if you are really sure you need configure."
+endif
# These can record GIT_VERSION
git.o git.spec \
--
1.7.3.1.184.g5b1fd
next reply other threads:[~2010-10-11 7:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 7:47 Michael J Gruber [this message]
2010-10-11 7:59 ` [RFC PATCH] Makefile: Turn off the configure target by default Ævar Arnfjörð Bjarmason
2010-10-11 8:39 ` Jakub Narebski
2010-10-11 9:40 ` Ævar Arnfjörð Bjarmason
2010-10-11 12:10 ` Michael J Gruber
2010-10-11 12:37 ` [RFC PATCH] Makefile: point out "make" if "make configure" fails Ævar Arnfjörð Bjarmason
2010-10-11 15:06 ` Jakub Narebski
2010-10-11 20:46 ` Sverre Rabbelier
2010-10-11 15:18 ` [RFC PATCH] Makefile: Turn off the configure target by default Jakub Narebski
2010-10-11 15:28 ` Michael J Gruber
2010-10-11 16:21 ` Ævar Arnfjörð Bjarmason
2010-10-11 16:26 ` Jonathan Nieder
2010-10-12 8:33 ` Michael J Gruber
2010-10-12 9:10 ` Tor Arntsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36e21bdafd75e95f1e13437f81067c71c7390408.1286783121.git.git@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).