git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [RFC PATCH] Makefile: Turn off the configure target by default
Date: Mon, 11 Oct 2010 17:18:39 +0200	[thread overview]
Message-ID: <201010111718.39996.jnareb@gmail.com> (raw)
In-Reply-To: <4CB2FEB8.3050705@drmicha.warpmail.net>

Dnia poniedziałek 11. października 2010 14:10, Michael J Gruber napisał:
> Ævar Arnfjörð Bjarmason venit, vidit, dixit 11.10.2010 11:40:
>> On Mon, Oct 11, 2010 at 08:39, Jakub Narebski <jnareb@gmail.com> wrote:
>> 
>>> But thanks to having ./configure optional step, we can build git also
>>> on platforms that doesn't have autoconf installed (though the same could
>>> be achieved by bundling ./configure script with release tarballs).
>> 
>> It already is built as part of the tarballs, at least for
>> http://kernel.org/pub/software/scm/git/git-1.7.3.1.tar.bz2
> 
> Well, the point of my semi-serious RFC is that every so often, we have a
> variation on the following theme on the list:
> 
> - "Newbee" uses make configure && ./configure && make and can't build.

As Ævar writes this happen mostly because "newbee" doesn't have autoconf
installed (and is not using released tarball, where ./configure script
is included).  Ævar solution is much better.

> - Helpful "oldbees" respond like "Duh! Use the Makefile".

This can happen because A.) "oldbee" doesn't use configure script
himself, so he gives (universal) advice that he can check, or B.) 
because there is an error in both Makefile guessing and ./configure
script doesn't detect or misdetect thing; then "Use the Makefile"
can be considered workaround for the issue till bug gets fixed.

> configure is a second class citizen in git.git (we even explicitly
> .gitignore it - if you allow that lame joke),

We .gitignore 'configure' script because it is *generated* file, and
generated files should be not, as rule, placed under version control.

> But, really, the typical responses to build problems with configure
> indicate that most long timers don't use configure either, and probably
> don't feel too comfortable with it. So, I think we should either make
> the status quo clearer (Makefile as primary method) or change the status
> quo. I can only do the former ;)

Because ./configure script enhances Makefile rather than generate it,
using configure script can only improve situation (at the cost of extra
cycles spent detecting)... well, with exception of rare cases bugs in
configure.ac making it misdetect.

-- 
Jakub Narebski
Poland

  parent reply	other threads:[~2010-10-11 15:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11  7:47 [RFC PATCH] Makefile: Turn off the configure target by default Michael J Gruber
2010-10-11  7:59 ` Ævar Arnfjörð Bjarmason
2010-10-11  8:39   ` Jakub Narebski
2010-10-11  9:40     ` Ævar Arnfjörð Bjarmason
2010-10-11 12:10       ` Michael J Gruber
2010-10-11 12:37         ` [RFC PATCH] Makefile: point out "make" if "make configure" fails Ævar Arnfjörð Bjarmason
2010-10-11 15:06           ` Jakub Narebski
2010-10-11 20:46             ` Sverre Rabbelier
2010-10-11 15:18         ` Jakub Narebski [this message]
2010-10-11 15:28           ` [RFC PATCH] Makefile: Turn off the configure target by default Michael J Gruber
2010-10-11 16:21             ` Ævar Arnfjörð Bjarmason
2010-10-11 16:26               ` Jonathan Nieder
2010-10-12  8:33                 ` Michael J Gruber
2010-10-12  9:10                   ` Tor Arntsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010111718.39996.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).