git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff Hostetler <git@jeffhostetler.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>,
	"'Duy Nguyen'" <pclouds@gmail.com>,
	"'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>
Cc: 'Git Mailing List' <git@vger.kernel.org>
Subject: Re: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh
Date: Tue, 21 May 2019 12:55:25 -0400	[thread overview]
Message-ID: <92cfdf43-8841-9c5a-7838-dda995038908@jeffhostetler.com> (raw)
In-Reply-To: <000501d50fd6$24c0f0e0$6e42d2a0$@nexbridge.com>



On 5/21/2019 9:07 AM, Randall S. Becker wrote:
> On May 21, 2019 07:59, Duy Nguyen wrote:
>> On Tue, May 21, 2019 at 6:51 PM Ævar Arnfjörð Bjarmason
>> <avarab@gmail.com> wrote:
>>> But the real bug looks like the trace2 code unconditionally depending
>>> on pthreads, even though NonStop has 'NO_PTHREADS =
>> UnfortunatelyYes'
>>> defined.
>>>
>>> That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
>>> using pthreads is failing with whatever pthread-bizarro NonStop has.
>>>
>>> That seems easy enough to "fix", just always fake up "main" if we
>>> don't have pthreads, but perhaps Jeff H. has another opinion on it...
>>
>> That's not NonStop. thread-utils.h (re)defines pthread_getspecific() to return
>> NULL when NO_PTHREADS, which triggers this I think.
> 
> The platform *is* NonStop, which has SPT and PUT pthreads, but we have never been able to make them work with git, so did not include them in the configuration.
> 

I just reproduced this on my Mac with NO_PTHREADS defined.
I'll post a fix shortly.

Jeff

      reply	other threads:[~2019-05-21 16:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 10:44 [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh Randall S. Becker
2019-05-21 11:49 ` Ævar Arnfjörð Bjarmason
2019-05-21 11:59   ` Duy Nguyen
2019-05-21 13:07     ` Randall S. Becker
2019-05-21 16:55       ` Jeff Hostetler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92cfdf43-8841-9c5a-7838-dda995038908@jeffhostetler.com \
    --to=git@jeffhostetler.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).