git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh
@ 2019-05-21 10:44 Randall S. Becker
  2019-05-21 11:49 ` Ævar Arnfjörð Bjarmason
  0 siblings, 1 reply; 5+ messages in thread
From: Randall S. Becker @ 2019-05-21 10:44 UTC (permalink / raw)
  To: git

Hi All,

On the NonStop platform, the entire test for t0211-trace2-perf.sh does not
work. The first case, in verbose, reports:

We get errors when the script is run:

Use of uninitialized value within @tokens in pattern match (m//) at
t0211/scrub_perf.perl line 29, <> line 1.

Initialized empty Git repository in /home/git/git/t/trash
directory.t0211-trace2-perf/.git/
expecting success:
        test_when_finished "rm trace.perf actual expect" &&
        GIT_TR2_PERF="$(pwd)/trace.perf" test-tool trace2 001return 0 &&
        perl "$TEST_DIRECTORY/t0211/scrub_perf.perl" <trace.perf >actual &&
        cat >expect <<-EOF &&
                d0|main|version|||||$V
                d0|main|start||_T_ABS_|||_EXE_ trace2 001return 0
                d0|main|cmd_name|||||trace2 (trace2)
                d0|main|exit||_T_ABS_|||code:0
                d0|main|atexit||_T_ABS_|||code:0
        EOF
        test_cmp expect actual

--- expect      2019-05-21 10:38:47 +0000
+++ actual      2019-05-21 10:38:47 +0000
@@ -1,5 +1,5 @@
-d0|main|version|||||2.22.0.rc1
-d0|main|start||_T_ABS_|||_EXE_ trace2 001return 0
-d0|main|cmd_name|||||trace2 (trace2)
-d0|main|exit||_T_ABS_|||code:0
-d0|main|atexit||_T_ABS_|||code:0
+d0|th01:unknown|version|||||2.22.0.rc1
+d0|th02:unknown|start||_T_ABS_|||_EXE_ trace2 001return 0
+d0|th03:unknown|cmd_name|||||trace2 (trace2)
+d0|th04:unknown|exit||_T_ABS_|||code:0
+d0|th06:unknown|atexit||_T_ABS_|||code:0

Our perl is v5.24.0 and this cannot be upgraded.

Thoughts?

Randall

-- Brief whoami:
 NonStop developer since approximately 211288444200000000
 UNIX developer since approximately 421664400
-- In my real life, I talk too much.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh
  2019-05-21 10:44 [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh Randall S. Becker
@ 2019-05-21 11:49 ` Ævar Arnfjörð Bjarmason
  2019-05-21 11:59   ` Duy Nguyen
  0 siblings, 1 reply; 5+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2019-05-21 11:49 UTC (permalink / raw)
  To: Randall S. Becker; +Cc: git, Jeff Hostetler


On Tue, May 21 2019, Randall S. Becker wrote:

> Hi All,
>
> On the NonStop platform, the entire test for t0211-trace2-perf.sh does not
> work. The first case, in verbose, reports:
>
> We get errors when the script is run:
>
> Use of uninitialized value within @tokens in pattern match (m//) at
> t0211/scrub_perf.perl line 29, <> line 1.

Could you intrument that test top "cat" the raw trace.perf you get?

That's some bug in the perl side of the parsing.

But the real bug looks like the trace2 code unconditionally depending on
pthreads, even though NonStop has 'NO_PTHREADS = UnfortunatelyYes'
defined.

That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
using pthreads is failing with whatever pthread-bizarro NonStop has.

That seems easy enough to "fix", just always fake up "main" if we don't
have pthreads, but perhaps Jeff H. has another opinion on it...

> Initialized empty Git repository in /home/git/git/t/trash
> directory.t0211-trace2-perf/.git/
> expecting success:
>         test_when_finished "rm trace.perf actual expect" &&
>         GIT_TR2_PERF="$(pwd)/trace.perf" test-tool trace2 001return 0 &&
>         perl "$TEST_DIRECTORY/t0211/scrub_perf.perl" <trace.perf >actual &&
>         cat >expect <<-EOF &&
>                 d0|main|version|||||$V
>                 d0|main|start||_T_ABS_|||_EXE_ trace2 001return 0
>                 d0|main|cmd_name|||||trace2 (trace2)
>                 d0|main|exit||_T_ABS_|||code:0
>                 d0|main|atexit||_T_ABS_|||code:0
>         EOF
>         test_cmp expect actual
>
> --- expect      2019-05-21 10:38:47 +0000
> +++ actual      2019-05-21 10:38:47 +0000
> @@ -1,5 +1,5 @@
> -d0|main|version|||||2.22.0.rc1
> -d0|main|start||_T_ABS_|||_EXE_ trace2 001return 0
> -d0|main|cmd_name|||||trace2 (trace2)
> -d0|main|exit||_T_ABS_|||code:0
> -d0|main|atexit||_T_ABS_|||code:0
> +d0|th01:unknown|version|||||2.22.0.rc1
> +d0|th02:unknown|start||_T_ABS_|||_EXE_ trace2 001return 0
> +d0|th03:unknown|cmd_name|||||trace2 (trace2)
> +d0|th04:unknown|exit||_T_ABS_|||code:0
> +d0|th06:unknown|atexit||_T_ABS_|||code:0
>
> Our perl is v5.24.0 and this cannot be upgraded.
>
> Thoughts?
>
> Randall
>
> -- Brief whoami:
>  NonStop developer since approximately 211288444200000000
>  UNIX developer since approximately 421664400
> -- In my real life, I talk too much.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh
  2019-05-21 11:49 ` Ævar Arnfjörð Bjarmason
@ 2019-05-21 11:59   ` Duy Nguyen
  2019-05-21 13:07     ` Randall S. Becker
  0 siblings, 1 reply; 5+ messages in thread
From: Duy Nguyen @ 2019-05-21 11:59 UTC (permalink / raw)
  To: Ævar Arnfjörð Bjarmason
  Cc: Randall S. Becker, Git Mailing List, Jeff Hostetler

On Tue, May 21, 2019 at 6:51 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> But the real bug looks like the trace2 code unconditionally depending on
> pthreads, even though NonStop has 'NO_PTHREADS = UnfortunatelyYes'
> defined.
>
> That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
> using pthreads is failing with whatever pthread-bizarro NonStop has.
>
> That seems easy enough to "fix", just always fake up "main" if we don't
> have pthreads, but perhaps Jeff H. has another opinion on it...

That's not NonStop. thread-utils.h (re)defines pthread_getspecific()
to return NULL when NO_PTHREADS, which triggers this I think.
-- 
Duy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh
  2019-05-21 11:59   ` Duy Nguyen
@ 2019-05-21 13:07     ` Randall S. Becker
  2019-05-21 16:55       ` Jeff Hostetler
  0 siblings, 1 reply; 5+ messages in thread
From: Randall S. Becker @ 2019-05-21 13:07 UTC (permalink / raw)
  To: 'Duy Nguyen', 'Ævar Arnfjörð Bjarmason'
  Cc: 'Git Mailing List', 'Jeff Hostetler'

On May 21, 2019 07:59, Duy Nguyen wrote:
> On Tue, May 21, 2019 at 6:51 PM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
> > But the real bug looks like the trace2 code unconditionally depending
> > on pthreads, even though NonStop has 'NO_PTHREADS =
> UnfortunatelyYes'
> > defined.
> >
> > That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
> > using pthreads is failing with whatever pthread-bizarro NonStop has.
> >
> > That seems easy enough to "fix", just always fake up "main" if we
> > don't have pthreads, but perhaps Jeff H. has another opinion on it...
> 
> That's not NonStop. thread-utils.h (re)defines pthread_getspecific() to return
> NULL when NO_PTHREADS, which triggers this I think.

The platform *is* NonStop, which has SPT and PUT pthreads, but we have never been able to make them work with git, so did not include them in the configuration.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh
  2019-05-21 13:07     ` Randall S. Becker
@ 2019-05-21 16:55       ` Jeff Hostetler
  0 siblings, 0 replies; 5+ messages in thread
From: Jeff Hostetler @ 2019-05-21 16:55 UTC (permalink / raw)
  To: Randall S. Becker, 'Duy Nguyen',
	'Ævar Arnfjörð Bjarmason'
  Cc: 'Git Mailing List'



On 5/21/2019 9:07 AM, Randall S. Becker wrote:
> On May 21, 2019 07:59, Duy Nguyen wrote:
>> On Tue, May 21, 2019 at 6:51 PM Ævar Arnfjörð Bjarmason
>> <avarab@gmail.com> wrote:
>>> But the real bug looks like the trace2 code unconditionally depending
>>> on pthreads, even though NonStop has 'NO_PTHREADS =
>> UnfortunatelyYes'
>>> defined.
>>>
>>> That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
>>> using pthreads is failing with whatever pthread-bizarro NonStop has.
>>>
>>> That seems easy enough to "fix", just always fake up "main" if we
>>> don't have pthreads, but perhaps Jeff H. has another opinion on it...
>>
>> That's not NonStop. thread-utils.h (re)defines pthread_getspecific() to return
>> NULL when NO_PTHREADS, which triggers this I think.
> 
> The platform *is* NonStop, which has SPT and PUT pthreads, but we have never been able to make them work with git, so did not include them in the configuration.
> 

I just reproduced this on my Mac with NO_PTHREADS defined.
I'll post a fix shortly.

Jeff

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-21 16:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 10:44 [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh Randall S. Becker
2019-05-21 11:49 ` Ævar Arnfjörð Bjarmason
2019-05-21 11:59   ` Duy Nguyen
2019-05-21 13:07     ` Randall S. Becker
2019-05-21 16:55       ` Jeff Hostetler

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).