From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: git@vger.kernel.org, Jeff Hostetler <git@jeffhostetler.com>
Subject: Re: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh
Date: Tue, 21 May 2019 13:49:28 +0200 [thread overview]
Message-ID: <87a7fguiwn.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <019e01d50fc2$324bd400$96e37c00$@nexbridge.com>
On Tue, May 21 2019, Randall S. Becker wrote:
> Hi All,
>
> On the NonStop platform, the entire test for t0211-trace2-perf.sh does not
> work. The first case, in verbose, reports:
>
> We get errors when the script is run:
>
> Use of uninitialized value within @tokens in pattern match (m//) at
> t0211/scrub_perf.perl line 29, <> line 1.
Could you intrument that test top "cat" the raw trace.perf you get?
That's some bug in the perl side of the parsing.
But the real bug looks like the trace2 code unconditionally depending on
pthreads, even though NonStop has 'NO_PTHREADS = UnfortunatelyYes'
defined.
That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
using pthreads is failing with whatever pthread-bizarro NonStop has.
That seems easy enough to "fix", just always fake up "main" if we don't
have pthreads, but perhaps Jeff H. has another opinion on it...
> Initialized empty Git repository in /home/git/git/t/trash
> directory.t0211-trace2-perf/.git/
> expecting success:
> test_when_finished "rm trace.perf actual expect" &&
> GIT_TR2_PERF="$(pwd)/trace.perf" test-tool trace2 001return 0 &&
> perl "$TEST_DIRECTORY/t0211/scrub_perf.perl" <trace.perf >actual &&
> cat >expect <<-EOF &&
> d0|main|version|||||$V
> d0|main|start||_T_ABS_|||_EXE_ trace2 001return 0
> d0|main|cmd_name|||||trace2 (trace2)
> d0|main|exit||_T_ABS_|||code:0
> d0|main|atexit||_T_ABS_|||code:0
> EOF
> test_cmp expect actual
>
> --- expect 2019-05-21 10:38:47 +0000
> +++ actual 2019-05-21 10:38:47 +0000
> @@ -1,5 +1,5 @@
> -d0|main|version|||||2.22.0.rc1
> -d0|main|start||_T_ABS_|||_EXE_ trace2 001return 0
> -d0|main|cmd_name|||||trace2 (trace2)
> -d0|main|exit||_T_ABS_|||code:0
> -d0|main|atexit||_T_ABS_|||code:0
> +d0|th01:unknown|version|||||2.22.0.rc1
> +d0|th02:unknown|start||_T_ABS_|||_EXE_ trace2 001return 0
> +d0|th03:unknown|cmd_name|||||trace2 (trace2)
> +d0|th04:unknown|exit||_T_ABS_|||code:0
> +d0|th06:unknown|atexit||_T_ABS_|||code:0
>
> Our perl is v5.24.0 and this cannot be upgraded.
>
> Thoughts?
>
> Randall
>
> -- Brief whoami:
> NonStop developer since approximately 211288444200000000
> UNIX developer since approximately 421664400
> -- In my real life, I talk too much.
next prev parent reply other threads:[~2019-05-21 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 10:44 [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh Randall S. Becker
2019-05-21 11:49 ` Ævar Arnfjörð Bjarmason [this message]
2019-05-21 11:59 ` Duy Nguyen
2019-05-21 13:07 ` Randall S. Becker
2019-05-21 16:55 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7fguiwn.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).