git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] stash: don't translate literal commands
@ 2021-05-16 21:57 Alex Henrie
  2021-05-17 16:48 ` Derrick Stolee
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Henrie @ 2021-05-16 21:57 UTC (permalink / raw)
  To: git, ungureanupaulsebastian, t.gummerer, gitster; +Cc: Alex Henrie

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 builtin/stash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/stash.c b/builtin/stash.c
index d68ed784d2..075bcf6ee5 100644
--- a/builtin/stash.c
+++ b/builtin/stash.c
@@ -26,7 +26,7 @@ static const char * const git_stash_usage[] = {
 	N_("git stash drop [-q|--quiet] [<stash>]"),
 	N_("git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]"),
 	N_("git stash branch <branchname> [<stash>]"),
-	N_("git stash clear"),
+	"git stash clear",
 	N_("git stash [push [-p|--patch] [-k|--[no-]keep-index] [-q|--quiet]\n"
 	   "          [-u|--include-untracked] [-a|--all] [-m|--message <message>]\n"
 	   "          [--pathspec-from-file=<file> [--pathspec-file-nul]]\n"
@@ -67,7 +67,7 @@ static const char * const git_stash_branch_usage[] = {
 };
 
 static const char * const git_stash_clear_usage[] = {
-	N_("git stash clear"),
+	"git stash clear",
 	NULL
 };
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] stash: don't translate literal commands
  2021-05-16 21:57 [PATCH] stash: don't translate literal commands Alex Henrie
@ 2021-05-17 16:48 ` Derrick Stolee
  2021-05-18  6:08   ` Alex Henrie
  0 siblings, 1 reply; 3+ messages in thread
From: Derrick Stolee @ 2021-05-17 16:48 UTC (permalink / raw)
  To: Alex Henrie, git, ungureanupaulsebastian, t.gummerer, gitster

On 5/16/2021 5:57 PM, Alex Henrie wrote:
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  builtin/stash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/builtin/stash.c b/builtin/stash.c
> index d68ed784d2..075bcf6ee5 100644
> --- a/builtin/stash.c
> +++ b/builtin/stash.c
> @@ -26,7 +26,7 @@ static const char * const git_stash_usage[] = {
>  	N_("git stash drop [-q|--quiet] [<stash>]"),
>  	N_("git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]"),
>  	N_("git stash branch <branchname> [<stash>]"),
> -	N_("git stash clear"),
> +	"git stash clear",

I immediately saw the commands above and wondered why you are
not removing them from being translated. My guess is that the
"<stash>" strings are the bits that are interesting to
translate. Perhaps add some description in your commit message
as to why you are drawing the line here?

>  static const char * const git_stash_clear_usage[] = {
> -	N_("git stash clear"),
> +	"git stash clear",
>  	NULL
>  };

Are there other instances in builtin/*.c? If not, then it
would be nice to say so. Otherwise, it would be good to fix
them, while you are here.

Thanks,
-Stolee

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] stash: don't translate literal commands
  2021-05-17 16:48 ` Derrick Stolee
@ 2021-05-18  6:08   ` Alex Henrie
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Henrie @ 2021-05-18  6:08 UTC (permalink / raw)
  To: Derrick Stolee
  Cc: Git mailing list, ungureanupaulsebastian, t.gummerer, Junio C Hamano

On Mon, May 17, 2021 at 10:48 AM Derrick Stolee <stolee@gmail.com> wrote:
>
> On 5/16/2021 5:57 PM, Alex Henrie wrote:
>
> >  static const char * const git_stash_clear_usage[] = {
> > -     N_("git stash clear"),
> > +     "git stash clear",
> >       NULL
> >  };
>
> Are there other instances in builtin/*.c? If not, then it
> would be nice to say so. Otherwise, it would be good to fix
> them, while you are here.

I reviewed all of the translatable strings and only found this problem
in graph.c and builtin/stash.c.

-Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-18  6:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 21:57 [PATCH] stash: don't translate literal commands Alex Henrie
2021-05-17 16:48 ` Derrick Stolee
2021-05-18  6:08   ` Alex Henrie

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).