git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Alex Henrie <alexhenrie24@gmail.com>,
	git@vger.kernel.org, ungureanupaulsebastian@gmail.com,
	t.gummerer@gmail.com, gitster@pobox.com
Subject: Re: [PATCH] stash: don't translate literal commands
Date: Mon, 17 May 2021 12:48:33 -0400	[thread overview]
Message-ID: <91d3d4e7-a04f-3fc4-a97b-90af02b20ed5@gmail.com> (raw)
In-Reply-To: <20210516215704.32440-1-alexhenrie24@gmail.com>

On 5/16/2021 5:57 PM, Alex Henrie wrote:
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  builtin/stash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/builtin/stash.c b/builtin/stash.c
> index d68ed784d2..075bcf6ee5 100644
> --- a/builtin/stash.c
> +++ b/builtin/stash.c
> @@ -26,7 +26,7 @@ static const char * const git_stash_usage[] = {
>  	N_("git stash drop [-q|--quiet] [<stash>]"),
>  	N_("git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]"),
>  	N_("git stash branch <branchname> [<stash>]"),
> -	N_("git stash clear"),
> +	"git stash clear",

I immediately saw the commands above and wondered why you are
not removing them from being translated. My guess is that the
"<stash>" strings are the bits that are interesting to
translate. Perhaps add some description in your commit message
as to why you are drawing the line here?

>  static const char * const git_stash_clear_usage[] = {
> -	N_("git stash clear"),
> +	"git stash clear",
>  	NULL
>  };

Are there other instances in builtin/*.c? If not, then it
would be nice to say so. Otherwise, it would be good to fix
them, while you are here.

Thanks,
-Stolee

  reply	other threads:[~2021-05-17 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 21:57 Alex Henrie
2021-05-17 16:48 ` Derrick Stolee [this message]
2021-05-18  6:08   ` Alex Henrie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91d3d4e7-a04f-3fc4-a97b-90af02b20ed5@gmail.com \
    --to=stolee@gmail.com \
    --cc=alexhenrie24@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=t.gummerer@gmail.com \
    --cc=ungureanupaulsebastian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).