From: Thomas Braun <thomas.braun@virtuell-zuhause.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Ramkumar Ramachandra" <artagnon@gmail.com>,
"John Keeping" <john@keeping.me.uk>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v3 2/2] completion: add git status
Date: Fri, 3 Jun 2016 17:41:35 +0200 [thread overview]
Message-ID: <8f5e515b-8efc-0160-820e-d81885fc6c36@virtuell-zuhause.de> (raw)
In-Reply-To: <xmqqtwhbtq46.fsf@gitster.mtv.corp.google.com>
Am 02.06.2016 um 20:14 schrieb Junio C Hamano:
> Thomas Braun <thomas.braun@virtuell-zuhause.de> writes:
>
>> + untracked_state="$(__git_find_on_cmdline "--untracked-files=no\
>> + --untracked-files=normal --untracked-files=all")"
>
> Just wondering but does this help my use of the command like
>
> $ git status -uno <TAB>
>
> or do I now have to spell it out like
>
> $ git status --untracked-files=no <TAB>
>
> to take advantage of it?
I was unsure if I should support the short option (-u) as well. On
thinking about it again there is little use of only doing it for the
long option.
Will be handled in a reroll.
>> + untracked_state=${untracked_state##--untracked-files=}
>> +
>> + if [ -z "$untracked_state" ]; then
>> + untracked_state="$(git --git-dir="$(__gitdir)" config "status.showUntrackedFiles")"
>> + fi
>> +
>> + case "$untracked_state" in
>> + no)
>> + # --ignored option does not matter
>
> Style. I see existing case/esac statements that use this style, but
> our preference is not to indent case arms like this; rather:
>
> case "$untracked_state" in
> no)
> # --ignored ...
>
> which saves the indentation one level overall.
thanks, will be fixed.
>> + complete_opt=
>> + ;;
>> + all|normal|*)
>> + complete_opt="--cached --directory --no-empty-directory --others"
>> +
>> + if [ -n "$(__git_find_on_cmdline "--ignored")" ]; then
>
> Same question as the "--untracked-files=no vs -uno" applies here.
Is there a short version of --ignored? I could not find one in the help,
and from a look into cmd_status in commit.c I would say there is none.
next prev parent reply other threads:[~2016-06-03 15:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 23:42 [PATCH 1/2] completion: create variable for untracked file modes Thomas Braun
2016-06-01 4:05 ` Jeff King
2016-06-01 7:02 ` Junio C Hamano
2016-06-01 9:14 ` Thomas Braun
2016-06-01 9:37 ` [PATCH v2 " Thomas Braun
2016-06-01 11:59 ` SZEDER Gábor
2016-06-02 12:19 ` Thomas Braun
[not found] ` <6e722a5fb64b73373ac6450ec9600e98745df29d.1464769152.git.thomas.braun@virtuell-zuhause.de>
2016-06-01 9:37 ` [PATCH v2 2/2] completion: add git status Thomas Braun
2016-06-01 12:15 ` SZEDER Gábor
2016-06-02 15:04 ` Thomas Braun
[not found] ` <9ef8cfd8fb89bcacd123ddbebc12f961a292ef8b.1464879648.git.thomas.braun@virtuell-zuhause.de>
2016-06-02 15:11 ` [PATCH v3 " Thomas Braun
2016-06-02 18:14 ` Junio C Hamano
2016-06-03 15:41 ` Thomas Braun [this message]
2016-06-03 16:34 ` Junio C Hamano
2016-06-03 17:17 ` Jeff King
2016-06-03 17:54 ` Junio C Hamano
2016-06-03 18:20 ` Thomas Braun
2016-06-03 18:34 ` [PATCH v4 0/3] support completion for " Thomas Braun
2016-06-03 18:34 ` [PATCH v4 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-03 18:34 ` [PATCH v4 2/3] completion: add __git_get_option_value helper Thomas Braun
2016-06-10 13:10 ` SZEDER Gábor
2016-06-25 16:13 ` Thomas Braun
2016-06-03 18:34 ` [PATCH v4 3/3] completion: add git status Thomas Braun
2016-06-06 17:57 ` Junio C Hamano
2016-06-07 7:47 ` Thomas Braun
2016-06-06 18:03 ` [PATCH v4 0/3] support completion for " Junio C Hamano
2016-06-10 10:12 ` [PATCH v5 0/3] completion: add " Thomas Braun
2016-06-10 10:12 ` [PATCH v5 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-10 10:12 ` [PATCH v5 2/3] completion: add __git_get_option_value helper Thomas Braun
2016-06-10 10:12 ` [PATCH v5 3/3] completion: add git status Thomas Braun
2016-06-10 10:23 ` [PATCH v5 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-10 10:24 ` [PATCH v5 3/3] completion: add git status Thomas Braun
2016-06-02 15:16 ` [PATCH v3 1/2] completion: factor out untracked file modes into a variable Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f5e515b-8efc-0160-820e-d81885fc6c36@virtuell-zuhause.de \
--to=thomas.braun@virtuell-zuhause.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).