From: Thomas Braun <thomas.braun@virtuell-zuhause.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: peff@peff.net, git@vger.kernel.org,
"Ramkumar Ramachandra" <artagnon@gmail.com>,
"John Keeping" <john@keeping.me.uk>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v4 3/3] completion: add git status
Date: Tue, 7 Jun 2016 09:47:13 +0200 [thread overview]
Message-ID: <7bf0dd4a-ec78-f415-f35c-161f42c3c17d@virtuell-zuhause.de> (raw)
In-Reply-To: <xmqqmvmyxksj.fsf@gitster.mtv.corp.google.com>
Am 06.06.2016 um 19:57 schrieb Junio C Hamano:
> Thomas Braun <thomas.braun@virtuell-zuhause.de> writes:
>
>> + case "$cur" in
>> + --ignore-submodules=*)
>> + __gitcomp "none untracked dirty all" "" "${cur##--ignore-submodules=}"
>> + return
>> + ;;
>> + --untracked-files=*)
>> + __gitcomp "$__git_untracked_file_modes" "" "${cur##--untracked-files=}"
>> + return
>> + ;;
>> + --column=*)
>> + __gitcomp "
>> + always never auto column row plain dense nodense
>> + " "" "${cur##--column=}"
>> + return
>> + ;;
>> + --*)
>> + __gitcomp "
>> + --short --branch --porcelain --long --verbose
>> + --untracked-files= --ignore-submodules= --ignored
>> + --column= --no-column
>> + "
>> + return
>> + ;;
>> + esac
>> +
>> + untracked_state="$(__git_get_option_value "-u" "--untracked-files="\
>
> If you have a SP before that backslash, you can avoid getting
> misunderstood that you are attempting to extend that string
> "--untracked-files=". The backslash is telling the shell that there
> are more arguments to come, and it is misleading to rely on the fast
> that the next line happens to begin with a whitespace.
Thanks, will be fixed in the reroll.
>> + "$__git_untracked_file_modes" "status.showUntrackedFiles")"
>
>
>> + case "$untracked_state" in
>> + no)
>> + # --ignored option does not matter
>> + complete_opt=
>> + ;;
>> + all|normal|*)
>> + complete_opt="--cached --directory --no-empty-directory --others"
>> +
>> + if [ -n "$(__git_find_on_cmdline "--ignored")" ]; then
>> + complete_opt="$complete_opt --ignored --exclude=*"
>> + fi
>> + ;;
>> + esac
>> +
>> + __git_complete_index_file "$complete_opt"
>> +}
>> +
>> __git_config_get_set_variables ()
>> {
>> local prevword word config_file= c=$cword
>
next prev parent reply other threads:[~2016-06-07 7:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 23:42 [PATCH 1/2] completion: create variable for untracked file modes Thomas Braun
2016-06-01 4:05 ` Jeff King
2016-06-01 7:02 ` Junio C Hamano
2016-06-01 9:14 ` Thomas Braun
2016-06-01 9:37 ` [PATCH v2 " Thomas Braun
2016-06-01 11:59 ` SZEDER Gábor
2016-06-02 12:19 ` Thomas Braun
[not found] ` <6e722a5fb64b73373ac6450ec9600e98745df29d.1464769152.git.thomas.braun@virtuell-zuhause.de>
2016-06-01 9:37 ` [PATCH v2 2/2] completion: add git status Thomas Braun
2016-06-01 12:15 ` SZEDER Gábor
2016-06-02 15:04 ` Thomas Braun
[not found] ` <9ef8cfd8fb89bcacd123ddbebc12f961a292ef8b.1464879648.git.thomas.braun@virtuell-zuhause.de>
2016-06-02 15:11 ` [PATCH v3 " Thomas Braun
2016-06-02 18:14 ` Junio C Hamano
2016-06-03 15:41 ` Thomas Braun
2016-06-03 16:34 ` Junio C Hamano
2016-06-03 17:17 ` Jeff King
2016-06-03 17:54 ` Junio C Hamano
2016-06-03 18:20 ` Thomas Braun
2016-06-03 18:34 ` [PATCH v4 0/3] support completion for " Thomas Braun
2016-06-03 18:34 ` [PATCH v4 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-03 18:34 ` [PATCH v4 2/3] completion: add __git_get_option_value helper Thomas Braun
2016-06-10 13:10 ` SZEDER Gábor
2016-06-25 16:13 ` Thomas Braun
2016-06-03 18:34 ` [PATCH v4 3/3] completion: add git status Thomas Braun
2016-06-06 17:57 ` Junio C Hamano
2016-06-07 7:47 ` Thomas Braun [this message]
2016-06-06 18:03 ` [PATCH v4 0/3] support completion for " Junio C Hamano
2016-06-10 10:12 ` [PATCH v5 0/3] completion: add " Thomas Braun
2016-06-10 10:12 ` [PATCH v5 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-10 10:12 ` [PATCH v5 2/3] completion: add __git_get_option_value helper Thomas Braun
2016-06-10 10:12 ` [PATCH v5 3/3] completion: add git status Thomas Braun
2016-06-10 10:23 ` [PATCH v5 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-10 10:24 ` [PATCH v5 3/3] completion: add git status Thomas Braun
2016-06-02 15:16 ` [PATCH v3 1/2] completion: factor out untracked file modes into a variable Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bf0dd4a-ec78-f415-f35c-161f42c3c17d@virtuell-zuhause.de \
--to=thomas.braun@virtuell-zuhause.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).