From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Thomas Braun" <thomas.braun@virtuell-zuhause.de>,
git@vger.kernel.org, "Ramkumar Ramachandra" <artagnon@gmail.com>,
"John Keeping" <john@keeping.me.uk>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v3 2/2] completion: add git status
Date: Fri, 3 Jun 2016 13:17:11 -0400 [thread overview]
Message-ID: <20160603171711.GC3858@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqzir2p6yv.fsf@gitster.mtv.corp.google.com>
On Fri, Jun 03, 2016 at 09:34:00AM -0700, Junio C Hamano wrote:
> Thomas Braun <thomas.braun@virtuell-zuhause.de> writes:
>
> >>> + if [ -n "$(__git_find_on_cmdline "--ignored")" ]; then
> >>
> >> Same question as the "--untracked-files=no vs -uno" applies here.
> >
> > Is there a short version of --ignored? I could not find one in the help,
> > and from a look into cmd_status in commit.c I would say there is none.
>
> I was primarily wondering about the effect of parse-options have.
> It lets you truncate a long option to its unique prefix (e.g.
> "--untracked-files=all" can be spelled as "--unt=all"). It seems
> that "--ignored" must be spelled in full, which means the use of
> find-on-cmdline we see above is OK, but the reason why it is so is a
> bit subtle. It may deserve a comment there, perhaps.
I don't think we handle arguments to unique-prefix options throughout
the completion. There's lots of:
case "${words[c]}" in
--foo) ...
--bar) ...
--etc) ...
I suspect trying to support them everywhere would be a moderate pain,
and I doubt it is all that useful. We already know the person is using
tab-completion, so the natural thing to do after typing "--unt" is to
hit "<Tab>" rather than "=". That gives you the same effect, with the
added feedback that you're using a recognized action.
I know not everybody will the "natural thing" I claim, and if it were
easy to support everywhere, I don't mind doing it. But I suspect
(without thinking very hard on it) that it would make those case
statements a bit harder to read and maintain.
-Peff
next prev parent reply other threads:[~2016-06-03 17:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 23:42 [PATCH 1/2] completion: create variable for untracked file modes Thomas Braun
2016-06-01 4:05 ` Jeff King
2016-06-01 7:02 ` Junio C Hamano
2016-06-01 9:14 ` Thomas Braun
2016-06-01 9:37 ` [PATCH v2 " Thomas Braun
2016-06-01 11:59 ` SZEDER Gábor
2016-06-02 12:19 ` Thomas Braun
[not found] ` <6e722a5fb64b73373ac6450ec9600e98745df29d.1464769152.git.thomas.braun@virtuell-zuhause.de>
2016-06-01 9:37 ` [PATCH v2 2/2] completion: add git status Thomas Braun
2016-06-01 12:15 ` SZEDER Gábor
2016-06-02 15:04 ` Thomas Braun
[not found] ` <9ef8cfd8fb89bcacd123ddbebc12f961a292ef8b.1464879648.git.thomas.braun@virtuell-zuhause.de>
2016-06-02 15:11 ` [PATCH v3 " Thomas Braun
2016-06-02 18:14 ` Junio C Hamano
2016-06-03 15:41 ` Thomas Braun
2016-06-03 16:34 ` Junio C Hamano
2016-06-03 17:17 ` Jeff King [this message]
2016-06-03 17:54 ` Junio C Hamano
2016-06-03 18:20 ` Thomas Braun
2016-06-03 18:34 ` [PATCH v4 0/3] support completion for " Thomas Braun
2016-06-03 18:34 ` [PATCH v4 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-03 18:34 ` [PATCH v4 2/3] completion: add __git_get_option_value helper Thomas Braun
2016-06-10 13:10 ` SZEDER Gábor
2016-06-25 16:13 ` Thomas Braun
2016-06-03 18:34 ` [PATCH v4 3/3] completion: add git status Thomas Braun
2016-06-06 17:57 ` Junio C Hamano
2016-06-07 7:47 ` Thomas Braun
2016-06-06 18:03 ` [PATCH v4 0/3] support completion for " Junio C Hamano
2016-06-10 10:12 ` [PATCH v5 0/3] completion: add " Thomas Braun
2016-06-10 10:12 ` [PATCH v5 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-10 10:12 ` [PATCH v5 2/3] completion: add __git_get_option_value helper Thomas Braun
2016-06-10 10:12 ` [PATCH v5 3/3] completion: add git status Thomas Braun
2016-06-10 10:23 ` [PATCH v5 1/3] completion: factor out untracked file modes into a variable Thomas Braun
2016-06-10 10:24 ` [PATCH v5 3/3] completion: add git status Thomas Braun
2016-06-02 15:16 ` [PATCH v3 1/2] completion: factor out untracked file modes into a variable Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603171711.GC3858@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=szeder@ira.uka.de \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).