From: Andreas Schwab <schwab@linux-m68k.org>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()
Date: Sat, 08 Jul 2017 13:08:23 +0200 [thread overview]
Message-ID: <87tw2ngp94.fsf@linux-m68k.org> (raw)
In-Reply-To: <d1bb978b-a7df-48a8-15c8-80730c77e11c@web.de> ("René Scharfe"'s message of "Sat, 8 Jul 2017 10:58:42 +0200")
On Jul 08 2017, René Scharfe <l.s.r@web.de> wrote:
> Avoid running over the end of another -- a C string whose length we
> don't know -- by using strcmp(3) instead of memcmp(3) for comparing it
> with another C string.
That's not a good justification for the change, since memcmp never reads
past the differing characters.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2017-07-08 11:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 8:58 [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name() René Scharfe
2017-07-08 11:08 ` Andreas Schwab [this message]
2017-07-08 11:43 ` René Scharfe
2017-07-08 13:38 ` Andreas Schwab
2017-07-09 12:20 ` René Scharfe
2017-07-09 12:37 ` Andreas Schwab
2017-07-09 13:19 ` René Scharfe
2017-07-09 17:05 ` Junio C Hamano
2017-07-08 11:08 ` Ramsay Jones
2017-07-08 11:52 ` René Scharfe
2017-07-08 22:29 ` Junio C Hamano
2017-07-09 12:20 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw2ngp94.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).