From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 2CEB4202AE for ; Sat, 8 Jul 2017 11:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752836AbdGHLI2 (ORCPT ); Sat, 8 Jul 2017 07:08:28 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:37232 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbdGHLI1 (ORCPT ); Sat, 8 Jul 2017 07:08:27 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3x4THF5v9Zz1qrdW; Sat, 8 Jul 2017 13:08:24 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3x4THD5kkKz3jgYD; Sat, 8 Jul 2017 13:08:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id yW4BfrstQzHt; Sat, 8 Jul 2017 13:08:24 +0200 (CEST) X-Auth-Info: 3xhc1+1y1YQKT5DhuycDtFsJa2FKkfD6M1Sz5+8goOpOxiCkLrOa+1/hMJh84K/u Received: from igel.home (ppp-88-217-9-219.dynamic.mnet-online.de [88.217.9.219]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 8 Jul 2017 13:08:24 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 75A8D2C3186; Sat, 8 Jul 2017 13:08:23 +0200 (CEST) From: Andreas Schwab To: =?utf-8?Q?Ren=C3=A9?= Scharfe Cc: Git List , Junio C Hamano Subject: Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name() References: X-Yow: Am I SHOPLIFTING? Date: Sat, 08 Jul 2017 13:08:23 +0200 In-Reply-To: (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Sat, 8 Jul 2017 10:58:42 +0200") Message-ID: <87tw2ngp94.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Jul 08 2017, René Scharfe wrote: > Avoid running over the end of another -- a C string whose length we > don't know -- by using strcmp(3) instead of memcmp(3) for comparing it > with another C string. That's not a good justification for the change, since memcmp never reads past the differing characters. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."