git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()
Date: Sat, 8 Jul 2017 13:52:11 +0200	[thread overview]
Message-ID: <8bd7c4c6-c545-723b-ec4b-262abd8a7f5f@web.de> (raw)
In-Reply-To: <d83d2395-e667-9e52-cc94-af5fbec6054c@ramsayjones.plus.com>

Am 08.07.2017 um 13:08 schrieb Ramsay Jones:
> On 08/07/17 09:58, René Scharfe wrote:
>> Avoid running over the end of another -- a C string whose length we
>> don't know -- by using strcmp(3) instead of memcmp(3) for comparing it
>> with another C string.
> 
> I had to read this twice, along with the patch text, before this
> made any sense. ;-) The missing information being that 'another'
> was the name of the string variable that we were potentially
> 'running over the end of'.

Yeah, sorry, encasing that unusual variable name in quotes would
probably have helped.

René

  reply	other threads:[~2017-07-08 11:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08  8:58 [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name() René Scharfe
2017-07-08 11:08 ` Andreas Schwab
2017-07-08 11:43   ` René Scharfe
2017-07-08 13:38     ` Andreas Schwab
2017-07-09 12:20       ` René Scharfe
2017-07-09 12:37         ` Andreas Schwab
2017-07-09 13:19           ` René Scharfe
2017-07-09 17:05             ` Junio C Hamano
2017-07-08 11:08 ` Ramsay Jones
2017-07-08 11:52   ` René Scharfe [this message]
2017-07-08 22:29     ` Junio C Hamano
2017-07-09 12:20       ` René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd7c4c6-c545-723b-ec4b-262abd8a7f5f@web.de \
    --to=l.s.r@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).