From: Matthieu Moy <git@matthieu-moy.fr>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Matthieu Moy <git@matthieu-moy.fr>,
Corentin BOMPARD <corentin.bompard@etu.univ-lyon1.fr>,
Git List <git@vger.kernel.org>,
nathan.berbezier@etu.univ-lyon1.fr,
pablo.chabanne@etu.univ-lyon1.fr
Subject: Re: [PATCH 2/2 v3] doc: format pathnames and URLs as monospace.
Date: Wed, 13 Mar 2019 10:53:21 +0100 [thread overview]
Message-ID: <86lg1j6qy6.fsf@matthieu-moy.fr> (raw)
In-Reply-To: <CAPig+cQEYDay9kTUpBepw6kN_PgpG4dRXeNf82Kty+E7piXeWg@mail.gmail.com> (Eric Sunshine's message of "Tue, 12 Mar 2019 11:48:14 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> In patch 1/2:
>
> * drop the full stop from the first line of the commit message
>
> * s/futur/future/ in the commit message
>
> * s/There are false/& positives/ in the commit message
>
> * s/both, It/both, it/
Nice catches, thanks.
> In patch 2/2, there's a 'man curl' which probably ought to be
> converted to `man curl` (per paragraph updated by patch 1/2), but
> perhaps that's outside the scope of this patch series
Yes, I have no objection in fixing it but I'd rather limit the scope of
the patch and keep other fixes for another time.
Thanks,
--
Matthieu Moy
https://matthieu-moy.fr/
prev parent reply other threads:[~2019-03-13 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 13:04 [PATCH 1/2 v3] doc/CodingGuidelines: URLs and paths as monospace Corentin BOMPARD
2019-03-06 13:04 ` [PATCH 2/2 v3] doc: format pathnames and URLs " Corentin BOMPARD
2019-03-12 13:16 ` Matthieu Moy
2019-03-12 15:48 ` Eric Sunshine
2019-03-12 17:13 ` Andrei Rybak
2019-03-13 2:16 ` Junio C Hamano
2019-03-13 6:43 ` Eric Sunshine
2019-03-13 9:53 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lg1j6qy6.fsf@matthieu-moy.fr \
--to=git@matthieu-moy.fr \
--cc=corentin.bompard@etu.univ-lyon1.fr \
--cc=git@vger.kernel.org \
--cc=nathan.berbezier@etu.univ-lyon1.fr \
--cc=pablo.chabanne@etu.univ-lyon1.fr \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).