From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andrei Rybak <rybak.a.v@gmail.com>,
Corentin BOMPARD <corentin.bompard@etu.univ-lyon1.fr>,
Matthieu Moy <git@matthieu-moy.fr>,
Git List <git@vger.kernel.org>,
nathan.berbezier@etu.univ-lyon1.fr,
pablo.chabanne@etu.univ-lyon1.fr
Subject: Re: [PATCH 2/2 v3] doc: format pathnames and URLs as monospace.
Date: Wed, 13 Mar 2019 02:43:02 -0400 [thread overview]
Message-ID: <CAPig+cTxH9_mDwMdiRui5Lx7cmwg0K2PT2Cvj4YTn2gCg8Mcmw@mail.gmail.com> (raw)
In-Reply-To: <xmqq5zsnfrhk.fsf@gitster-ct.c.googlers.com>
On Tue, Mar 12, 2019 at 10:17 PM Junio C Hamano <gitster@pobox.com> wrote:
> Andrei Rybak <rybak.a.v@gmail.com> writes:
> > On 2019-03-12 16:48, Eric Sunshine wrote:
> >> * drop the full stop from the first line of the commit message
> >> * s/futur/future/ in the commit message
> >> * s/There are false/& positives/ in the commit message
> >> * s/both, It/both, it/
> >
> > * s/inconsistant/inconsistent/ in the first paragraph of the commit message.
>
> Here is what I have locally, with the above input, relative to what
> Matthieu reviewed.
The range-diff you presented looks good and addresses all the (minor)
issues raised.
next prev parent reply other threads:[~2019-03-13 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 13:04 [PATCH 1/2 v3] doc/CodingGuidelines: URLs and paths as monospace Corentin BOMPARD
2019-03-06 13:04 ` [PATCH 2/2 v3] doc: format pathnames and URLs " Corentin BOMPARD
2019-03-12 13:16 ` Matthieu Moy
2019-03-12 15:48 ` Eric Sunshine
2019-03-12 17:13 ` Andrei Rybak
2019-03-13 2:16 ` Junio C Hamano
2019-03-13 6:43 ` Eric Sunshine [this message]
2019-03-13 9:53 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTxH9_mDwMdiRui5Lx7cmwg0K2PT2Cvj4YTn2gCg8Mcmw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=corentin.bompard@etu.univ-lyon1.fr \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nathan.berbezier@etu.univ-lyon1.fr \
--cc=pablo.chabanne@etu.univ-lyon1.fr \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).