git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Matthieu Moy <git@matthieu-moy.fr>
Cc: Corentin BOMPARD <corentin.bompard@etu.univ-lyon1.fr>,
	Git List <git@vger.kernel.org>,
	nathan.berbezier@etu.univ-lyon1.fr,
	pablo.chabanne@etu.univ-lyon1.fr
Subject: Re: [PATCH 2/2 v3] doc: format pathnames and URLs as monospace.
Date: Tue, 12 Mar 2019 11:48:14 -0400	[thread overview]
Message-ID: <CAPig+cQEYDay9kTUpBepw6kN_PgpG4dRXeNf82Kty+E7piXeWg@mail.gmail.com> (raw)
In-Reply-To: <86va0o9qsp.fsf@matthieu-moy.fr>

On Tue, Mar 12, 2019 at 9:16 AM Matthieu Moy <git@matthieu-moy.fr> wrote:
> Corentin BOMPARD <corentin.bompard@etu.univ-lyon1.fr> writes:
> >  Changes: We listen to Matthieu MOY and Eric SUNSHINE's remarks about
> >  our mistakes on the last patch.
>
> This addresses all my previous remarks, so this (patches 1 and 2) is now
>
> Reviewed-by: Matthieu Moy <git@matthieu-moy.fr>
>
> I'm Cc-ing Eric in case he has anything more to say.

Thanks. A few comments:

In patch 1/2:

* drop the full stop from the first line of the commit message

* s/futur/future/ in the commit message

* s/There are false/& positives/ in the commit message

* s/both, It/both, it/

In patch 2/2, there's a 'man curl' which probably ought to be
converted to `man curl` (per paragraph updated by patch 1/2), but
perhaps that's outside the scope of this patch series (though it would
be easy enough to do -- but not necessarily worth a re-roll). Nothing
else popped out at me while scanning the patch.

  reply	other threads:[~2019-03-12 15:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 13:04 [PATCH 1/2 v3] doc/CodingGuidelines: URLs and paths as monospace Corentin BOMPARD
2019-03-06 13:04 ` [PATCH 2/2 v3] doc: format pathnames and URLs " Corentin BOMPARD
2019-03-12 13:16   ` Matthieu Moy
2019-03-12 15:48     ` Eric Sunshine [this message]
2019-03-12 17:13       ` Andrei Rybak
2019-03-13  2:16         ` Junio C Hamano
2019-03-13  6:43           ` Eric Sunshine
2019-03-13  9:53       ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cQEYDay9kTUpBepw6kN_PgpG4dRXeNf82Kty+E7piXeWg@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=corentin.bompard@etu.univ-lyon1.fr \
    --cc=git@matthieu-moy.fr \
    --cc=git@vger.kernel.org \
    --cc=nathan.berbezier@etu.univ-lyon1.fr \
    --cc=pablo.chabanne@etu.univ-lyon1.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).