From: Jakub Narebski <firstname.lastname@example.org>
To: Derrick Stolee <email@example.com>
Cc: "Derrick Stolee via GitGitGadget" <firstname.lastname@example.org>,
email@example.com, Johannes.Schindelin@gmx.de, firstname.lastname@example.org,
"Junio C Hamano" <email@example.com>,
"Nguyễn Thái Ngọc Duy" <firstname.lastname@example.org>,
"Carlo Marcelo Arenas Belón" <email@example.com>,
"Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org>
Subject: Re: [PATCH v3 0/3] [RFC] Create 'core.featureAdoptionRate' setting to update config defaults
Date: Thu, 11 Jul 2019 23:54:30 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <firstname.lastname@example.org> (Derrick Stolee's message of "Mon, 8 Jul 2019 15:22:49 -0400")
Derrick Stolee <email@example.com> writes:
> On 7/1/2019 10:29 AM, Derrick Stolee via GitGitGadget wrote:
>> Here is a second run at this RFC, which aims to create a "meta" config
>> setting that automatically turns on other settings according to a user's
>> willingness to trade new Git behavior or new feature risk for performance
>> benefits. The new name for the setting is "core.featureAdoptionRate" and is
>> an integer scale from 0 to 10. There will be multiple "categories" of
>> settings, and the intention is to allow more granular levels as necessary.
> (Adding people who contributed feedback to CC line.)
> It seems that this "Feature Adoption Rate" idea was too simplistic, and
> had several issues. Time to take a different stab at this direction, but
> with these clear goals in mind:
> 1. We want intermediate users to be able to take advantage of new config
> options without watching every release for new config options.
> 2. The config name should match the general effect of the implied
> 3. There are orthogonal settings that may not apply beneficially to
> all repos.
> With this in mind, I propose instead a set of "feature.*" config settings
> that form groups of "community recommended" settings (with some caveats).
> In the space below, I'll list a set of possible feature names and the
> implied config options.
A bit of bikeshed painting: I am unsure if "feature.*" is the best name
for this category of config (meta)settings. Perhaps "defaults.*" or
"presets.*" would be a better name -- they would certainly be more
indicative of what setting this config variable actually *does*.
> First, the main two categories we've discussed so far: many commits and
> many files. These two feature sets are for when your repo is large in
> one of these dimensions. Perhaps there are other settings to include
> in these?
> index.version = 4
> index.threads = true
> core.untrackedCache = true
> core.commitGraph = true
> gc.writeCommitGraph = true
> (future: fetch.writeSplitCommitGraph = true)
> Note: the `fetch.writeSplitCommitGraph` does not exist yet, but could
> be introduced in a later release to write a new commit-graph (with --split)
> on fetch.
That looks really nice (for a built-in set of defaults).
It would be good if the above format, or something like it, could be
used as a source of truth for this feature.
> The other category that has been discussed already is that of "experimental
> features that we generally think are helpful but change behavior slightly in
> some cases".
> pack.useSparse = true
> status.aheadBehind = false
> fetch.showForcedUpdates = false
> merge.directoryRenames = true
> protocol.version = 2
> fetch.negotiationAlgorithm = skipping
Well... turning off by default status.aheadBehind and
fetch.showForcedUpdates makes sense only if also repository is large.
Otherwise it is not useful, and even a bad thing.
Both of status.aheadBehind and fetch.showForcedUpdates are discoverable;
as far as I remember Git would show a hint about those config options
when the related task takes too long (either 'git status' in case of
status.aheadBehind, or 'git fetch' in the latter case).
I don't know if we have discoverability in the opposite direction: do we
show some advice (which as all advice can be turned off in the config)
if either of status.aheadBehind or fetch.showForcedUpdates is false?
> We have not discussed anything like the next category, but Dscho thought
> a set of configs to make pretty diffs could be a fun "meta-config" setting:
> diff.color = auto
> ui.color = auto
> diff.context = 5
> diff.colorMoved = true
> diff.colorMovedWs = allow-indentation-change
> diff.algorithm = minimal
> These are just a first round of suggestions. I'm sure we would enjoy a
> debate around an optimal set of diff settings.
Maybe Git for Windows defaults would be shipped in similar form; though
I wonder if in this case it is better from simple system-wide settings.
> Finally, here is a kind of feature that I could imagine being helpful
> in the future, but maybe is not a good idea to pursue right now. In
> some cases users use "gc.auto = 0" to prevent all user-time blocking
Don't we have a hook for that?
> This can degrade performance over time as loose objects
> and pack-files accumulate. The performance could mostly be recovered
> by using a multi-pack-index, but there is not current way to automatically
> write the file. This would not solve the space issues that happen here.
> gc.auto = 0
> core.multiPackIndex = true
> (future: fetch.writeMultiPackIndex = true)
> What do people think about this general idea? Are there any other
> feature.* settings that could be useful? Any additional settings
> to add to these groups?
Maybe feature.slowFilesystem / defaults.slowFilesystem? Or maybe
prev parent reply other threads:[~2019-07-11 21:54 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 20:18 [PATCH 00/11] [RFC] Create 'core.size=large' setting to update config defaults Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 01/11] repo-settings: create repo.size=large setting Derrick Stolee via GitGitGadget
2019-06-03 20:42 ` Jeff Hostetler
2019-06-03 20:18 ` [PATCH 03/11] repo-settings: pack.useSparse=true Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 02/11] repo-settings: use index.version=4 by default Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 04/11] status: add status.aheadbehind setting Jeff Hostetler via GitGitGadget
2019-06-03 20:18 ` [PATCH 05/11] status: add warning when a/b calculation takes too long for long/normal format Jeff Hostetler via GitGitGadget
2019-06-03 20:18 ` [PATCH 07/11] repo-settings: status.aheadBehind=false Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 06/11] status: ignore status.aheadbehind in porcelain formats Jeff Hostetler via GitGitGadget
2019-06-03 20:18 ` [PATCH 08/11] fetch: add --[no-]show-forced-updates argument Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 10/11] pull: add --[no-]show-forced-updates passthrough to fetch Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 09/11] fetch: warn about forced updates after branch list Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 11/11] repo-settings: fetch.showForcedUpdates=false Derrick Stolee via GitGitGadget
2019-06-03 20:55 ` [PATCH 00/11] [RFC] Create 'core.size=large' setting to update config defaults Derrick Stolee
2019-06-04 14:43 ` Johannes Schindelin
2019-06-04 14:56 ` Derrick Stolee
2019-06-05 20:39 ` Junio C Hamano
2019-06-06 12:23 ` Derrick Stolee
2019-06-06 16:07 ` Junio C Hamano
2019-06-19 15:11 ` [PATCH v2 0/3] [RFC] Create 'core.featureAdoptionRate' " Derrick Stolee via GitGitGadget
2019-06-19 15:12 ` [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting Derrick Stolee via GitGitGadget
2019-06-28 20:50 ` Junio C Hamano
2019-06-28 21:08 ` Derrick Stolee
2019-06-28 21:42 ` Junio C Hamano
2019-06-29 1:43 ` Derrick Stolee
2019-06-30 18:35 ` Carlo Arenas
2019-07-01 12:45 ` Derrick Stolee
2019-07-02 10:47 ` Ævar Arnfjörð Bjarmason
2019-07-02 11:09 ` Duy Nguyen
2019-07-02 14:54 ` Derrick Stolee
2019-07-02 16:59 ` Junio C Hamano
2019-06-19 15:12 ` [PATCH v2 2/3] repo-settings: use index.version=4 by default Derrick Stolee via GitGitGadget
2019-06-19 15:12 ` [PATCH v2 3/3] repo-settings: pack.useSparse=true Derrick Stolee via GitGitGadget
2019-07-01 14:29 ` [PATCH v3 0/3] [RFC] Create 'core.featureAdoptionRate' setting to update config defaults Derrick Stolee via GitGitGadget
2019-07-01 14:29 ` [PATCH v3 1/3] repo-settings: create core.featureAdoptionRate setting Derrick Stolee via GitGitGadget
2019-07-01 23:27 ` Carlo Arenas
2019-07-02 9:20 ` Duy Nguyen
2019-07-02 10:53 ` Ævar Arnfjörð Bjarmason
2019-07-04 22:47 ` Jakub Narebski
2019-07-01 14:29 ` [PATCH v3 2/3] repo-settings: use index.version=4 by default Derrick Stolee via GitGitGadget
2019-07-01 14:29 ` [PATCH v3 3/3] repo-settings: pack.useSparse=true Derrick Stolee via GitGitGadget
2019-07-08 19:22 ` [PATCH v3 0/3] [RFC] Create 'core.featureAdoptionRate' setting to update config defaults Derrick Stolee
2019-07-09 18:55 ` Taylor Blau
2019-07-09 19:21 ` Junio C Hamano
2019-07-09 19:45 ` Derrick Stolee
2019-07-09 22:05 ` Junio C Hamano
2019-07-22 12:10 ` Derrick Stolee
2019-07-11 21:54 ` Jakub Narebski [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).