From: Derrick Stolee <email@example.com>
To: Junio C Hamano <firstname.lastname@example.org>,
Derrick Stolee via GitGitGadget <email@example.com>
Subject: Re: [PATCH 00/11] [RFC] Create 'core.size=large' setting to update config defaults
Date: Thu, 6 Jun 2019 08:23:45 -0400 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On 6/5/2019 4:39 PM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <email@example.com> writes:
>> This patch series includes a few new config options we created to speed up
>> certain critical commands in VFS for Git. On their own, they would
>> contribute little value as it is hard to discover new config variables.
>> Instead, I've created this RFC as a goal for probably three sequential patch
>> 1. (Patches 1-3) Introduce a new 'core.size' config setting that takes
>> 'large' as a value. This enables several config values that are
>> beneficial for large repos. We use a certain set in VFS for Git (see
>> ), and most of those are applicable to any repo. This 'core.size'
>> setting is intended for users to automatically receive performance
>> updates as soon as they are stable, but they must opt-in to the setting
>> and can always explicitly set their own config values. The settings to
>> include here are core.commitGraph=true, gc.writeCommitGraph=true,
>> index.version=4, pack.useSparse=true.
> ... and not the configuration introduced by the other two points in
> this list?
They are added to the config setting after they are introduced. See
patches 7 (status.aheadBehind) and 11 (fetch.showForcedUpdates).
> "If you set this, these other configuration variables are set to
> these default values" is a very valuable usability feature. It
> looks a lot more "meta" or "macro", and certainly is not a good idea
> to call it as if it sits next to variables in any existing hierarchy.
> I also wonder if this is something we would want to support in
> general; random things that come to mind are:
> - should such a "macro" configuration be limited to boolean
> (e.g. the above core.size that takes 'large' is a boolean between
> 'large' and 'not large'), or can it be an enum (e.g. choose among
> 'large', 'medium' and 'small', and core.bigFileThreshold will be
> set to 1G, 512M and 128M respectively---this silly example is for
> illustration purposes only), and if so, can we express what these
> default values are for each choice without writing a lot of code?
That's a good point that we could include recommended values for
other non-boolean variables if our "meta" config setting is also
non-boolean. This fits in with the "ring" ideas discussed earlier .
Taking in a few ideas from your message, perhaps we create a new "meta"
category for this setting and use an integer value for "how big do I
think my repo is?" and we can apply different settings based on thresholds:
0: no config defaults changed
3: safe defaults (core.commitGraph, index.version=4)
6: behavior-modifying defaults (status.aheadBehind, fetch.noShowForcedUpdates)
Using 3 and 6 here to allow for finer gradients at a later date.
> - if we were to have more than just this 'core.size' macro, can two
> otherwise orthogonal macros both control the same underlying
> variable, and if so, how do we express their interactions?
> "using these two at the same time is forbidden" is a perfectly
> acceptable answer for the first round until we figure out the
> desired semantics, of course.
To borrow from linear algebra, I would recommend that two orthogonal
config settings have disjoint _bases_ (i.e. the set of config settings
they use are disjoint). Of course, this can be discussed in more
detail when someone suggests a second meta-config setting. Such a
second setting would need justification for why it doesn't work with
our first setting.
> - perhaps we may eventually want to allow end users (via their
> ~/.gitconfig) and system administrators (via /etc/gitconfig)
> define such a macro setting (e.g. setting macro.largeRepoSetting
> sets pack.usebitmaps=true, pack.useSpars=true, etc.) *after* we
> figure out what we want to do to the other points in this list.
> - even if we do not allow end users and system administrators futz
> with custom macros, can we specify the macros we ship without
> casting them in code?
Are you suggesting that we allow some config values to be pulled from
the repo contents? If we could identify some config options as "safe"
to include in the Git data, then a repo administrator could commit a
"/.gitconfig" file _and_ some existing config option says "look at the
config in the repo".
I see value in making some "safe" settings available in the repo, but
also see that it can be very tricky to get right. Further, I think it
is independent of the current direction. In fact, I would imagine the
meta-config setting be one of the "safe" settings that we could put in
this committed config file.
next prev parent reply other threads:[~2019-06-06 12:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 20:18 [PATCH 00/11] [RFC] Create 'core.size=large' setting to update config defaults Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 01/11] repo-settings: create repo.size=large setting Derrick Stolee via GitGitGadget
2019-06-03 20:42 ` Jeff Hostetler
2019-06-03 20:18 ` [PATCH 03/11] repo-settings: pack.useSparse=true Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 02/11] repo-settings: use index.version=4 by default Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 04/11] status: add status.aheadbehind setting Jeff Hostetler via GitGitGadget
2019-06-03 20:18 ` [PATCH 05/11] status: add warning when a/b calculation takes too long for long/normal format Jeff Hostetler via GitGitGadget
2019-06-03 20:18 ` [PATCH 07/11] repo-settings: status.aheadBehind=false Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 06/11] status: ignore status.aheadbehind in porcelain formats Jeff Hostetler via GitGitGadget
2019-06-03 20:18 ` [PATCH 08/11] fetch: add --[no-]show-forced-updates argument Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 10/11] pull: add --[no-]show-forced-updates passthrough to fetch Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 09/11] fetch: warn about forced updates after branch list Derrick Stolee via GitGitGadget
2019-06-03 20:18 ` [PATCH 11/11] repo-settings: fetch.showForcedUpdates=false Derrick Stolee via GitGitGadget
2019-06-03 20:55 ` [PATCH 00/11] [RFC] Create 'core.size=large' setting to update config defaults Derrick Stolee
2019-06-04 14:43 ` Johannes Schindelin
2019-06-04 14:56 ` Derrick Stolee
2019-06-05 20:39 ` Junio C Hamano
2019-06-06 12:23 ` Derrick Stolee [this message]
2019-06-06 16:07 ` Junio C Hamano
2019-06-19 15:11 ` [PATCH v2 0/3] [RFC] Create 'core.featureAdoptionRate' " Derrick Stolee via GitGitGadget
2019-06-19 15:12 ` [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting Derrick Stolee via GitGitGadget
2019-06-28 20:50 ` Junio C Hamano
2019-06-28 21:08 ` Derrick Stolee
2019-06-28 21:42 ` Junio C Hamano
2019-06-29 1:43 ` Derrick Stolee
2019-06-30 18:35 ` Carlo Arenas
2019-07-01 12:45 ` Derrick Stolee
2019-07-02 10:47 ` Ævar Arnfjörð Bjarmason
2019-07-02 11:09 ` Duy Nguyen
2019-07-02 14:54 ` Derrick Stolee
2019-07-02 16:59 ` Junio C Hamano
2019-06-19 15:12 ` [PATCH v2 2/3] repo-settings: use index.version=4 by default Derrick Stolee via GitGitGadget
2019-06-19 15:12 ` [PATCH v2 3/3] repo-settings: pack.useSparse=true Derrick Stolee via GitGitGadget
2019-07-01 14:29 ` [PATCH v3 0/3] [RFC] Create 'core.featureAdoptionRate' setting to update config defaults Derrick Stolee via GitGitGadget
2019-07-01 14:29 ` [PATCH v3 1/3] repo-settings: create core.featureAdoptionRate setting Derrick Stolee via GitGitGadget
2019-07-01 23:27 ` Carlo Arenas
2019-07-02 9:20 ` Duy Nguyen
2019-07-02 10:53 ` Ævar Arnfjörð Bjarmason
2019-07-04 22:47 ` Jakub Narebski
2019-07-01 14:29 ` [PATCH v3 2/3] repo-settings: use index.version=4 by default Derrick Stolee via GitGitGadget
2019-07-01 14:29 ` [PATCH v3 3/3] repo-settings: pack.useSparse=true Derrick Stolee via GitGitGadget
2019-07-08 19:22 ` [PATCH v3 0/3] [RFC] Create 'core.featureAdoptionRate' setting to update config defaults Derrick Stolee
2019-07-09 18:55 ` Taylor Blau
2019-07-09 19:21 ` Junio C Hamano
2019-07-09 19:45 ` Derrick Stolee
2019-07-09 22:05 ` Junio C Hamano
2019-07-22 12:10 ` Derrick Stolee
2019-07-11 21:54 ` Jakub Narebski
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).