From: Junio C Hamano <junkio@cox.net>
To: Nicolas Pitre <nico@cam.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] Add -d flag to git-pull-* family.
Date: Wed, 01 Jun 2005 01:24:22 -0700 [thread overview]
Message-ID: <7vu0kilc21.fsf_-_@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vacmapo18.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Tue, 31 May 2005 23:52:03 -0700")
When a remote repository is deltified, we need to get the
objects that a deltified object we want to obtain is based upon.
Since checking representation type of all objects we retreive
from remote side may be costly, this is made into a separate
option -d; -a implies it for convenience and safety.
Rsync transport does not have this problem since it fetches
everything the remote side has.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
Documentation/git-http-pull.txt | 4 +++-
Documentation/git-local-pull.txt | 4 +++-
Documentation/git-rpull.txt | 4 +++-
http-pull.c | 5 ++++-
local-pull.c | 5 ++++-
pull.c | 15 +++++++++++++++
pull.h | 3 +++
rpull.c | 5 ++++-
8 files changed, 39 insertions(+), 6 deletions(-)
diff --git a/Documentation/git-http-pull.txt b/Documentation/git-http-pull.txt
--- a/Documentation/git-http-pull.txt
+++ b/Documentation/git-http-pull.txt
@@ -9,7 +9,7 @@ git-http-pull - Downloads a remote GIT r
SYNOPSIS
--------
-'git-http-pull' [-c] [-t] [-a] [-v] commit-id url
+'git-http-pull' [-c] [-t] [-a] [-v] [-d] commit-id url
DESCRIPTION
-----------
@@ -17,6 +17,8 @@ Downloads a remote GIT repository via HT
-c::
Get the commit objects.
+-d::
+ Get objects that deltified objects are based upon.
-t::
Get trees associated with the commit objects.
-a::
diff --git a/Documentation/git-local-pull.txt b/Documentation/git-local-pull.txt
--- a/Documentation/git-local-pull.txt
+++ b/Documentation/git-local-pull.txt
@@ -9,7 +9,7 @@ git-local-pull - Duplicates another GIT
SYNOPSIS
--------
-'git-local-pull' [-c] [-t] [-a] [-l] [-s] [-n] [-v] commit-id path
+'git-local-pull' [-c] [-t] [-a] [-l] [-s] [-n] [-v] [-d] commit-id path
DESCRIPTION
-----------
@@ -19,6 +19,8 @@ OPTIONS
-------
-c::
Get the commit objects.
+-d::
+ Get objects that deltified objects are based upon.
-t::
Get trees associated with the commit objects.
-a::
diff --git a/Documentation/git-rpull.txt b/Documentation/git-rpull.txt
--- a/Documentation/git-rpull.txt
+++ b/Documentation/git-rpull.txt
@@ -10,7 +10,7 @@ git-rpull - Pulls from a remote reposito
SYNOPSIS
--------
-'git-rpull' [-c] [-t] [-a] [-v] commit-id url
+'git-rpull' [-c] [-t] [-a] [-v] [-d] commit-id url
DESCRIPTION
-----------
@@ -21,6 +21,8 @@ OPTIONS
-------
-c::
Get the commit objects.
+-d::
+ Get objects that deltified objects are based upon.
-t::
Get trees associated with the commit objects.
-a::
diff --git a/http-pull.c b/http-pull.c
--- a/http-pull.c
+++ b/http-pull.c
@@ -103,17 +103,20 @@ int main(int argc, char **argv)
get_tree = 1;
} else if (argv[arg][1] == 'c') {
get_history = 1;
+ } else if (argv[arg][1] == 'd') {
+ get_delta = 1;
} else if (argv[arg][1] == 'a') {
get_all = 1;
get_tree = 1;
get_history = 1;
+ get_delta = 1;
} else if (argv[arg][1] == 'v') {
get_verbosely = 1;
}
arg++;
}
if (argc < arg + 2) {
- usage("git-http-pull [-c] [-t] [-a] [-v] commit-id url");
+ usage("git-http-pull [-c] [-t] [-a] [-d] [-v] commit-id url");
return 1;
}
commit_id = argv[arg];
diff --git a/local-pull.c b/local-pull.c
--- a/local-pull.c
+++ b/local-pull.c
@@ -74,7 +74,7 @@ int fetch(unsigned char *sha1)
}
static const char *local_pull_usage =
-"git-local-pull [-c] [-t] [-a] [-l] [-s] [-n] [-v] commit-id path";
+"git-local-pull [-c] [-t] [-a] [-l] [-s] [-n] [-v] [-d] commit-id path";
/*
* By default we only use file copy.
@@ -92,10 +92,13 @@ int main(int argc, char **argv)
get_tree = 1;
else if (argv[arg][1] == 'c')
get_history = 1;
+ else if (argv[arg][1] == 'd')
+ get_delta = 1;
else if (argv[arg][1] == 'a') {
get_all = 1;
get_tree = 1;
get_history = 1;
+ get_delta = 1;
}
else if (argv[arg][1] == 'l')
use_link = 1;
diff --git a/pull.c b/pull.c
--- a/pull.c
+++ b/pull.c
@@ -6,6 +6,7 @@
int get_tree = 0;
int get_history = 0;
+int get_delta = 0;
int get_all = 0;
int get_verbosely = 0;
static unsigned char current_commit_sha1[20];
@@ -37,6 +38,20 @@ static int make_sure_we_have_it(const ch
status = fetch(sha1);
if (status && what)
report_missing(what, sha1);
+ if (get_delta) {
+ unsigned long mapsize, size;
+ void *map, *buf;
+ char type[20];
+
+ map = map_sha1_file(sha1, &mapsize);
+ if (map) {
+ buf = unpack_sha1_file(map, mapsize, type, &size);
+ munmap(map, mapsize);
+ if (buf && !strcmp(type, "delta"))
+ status = make_sure_we_have_it(what, buf);
+ free(buf);
+ }
+ }
return status;
}
diff --git a/pull.h b/pull.h
--- a/pull.h
+++ b/pull.h
@@ -13,6 +13,9 @@ extern int get_history;
/** Set to fetch the trees in the commit history. **/
extern int get_all;
+/* Set to fetch the base of delta objects.*/
+extern int get_delta;
+
/* Set to be verbose */
extern int get_verbosely;
diff --git a/rpull.c b/rpull.c
--- a/rpull.c
+++ b/rpull.c
@@ -27,17 +27,20 @@ int main(int argc, char **argv)
get_tree = 1;
} else if (argv[arg][1] == 'c') {
get_history = 1;
+ } else if (argv[arg][1] == 'd') {
+ get_delta = 1;
} else if (argv[arg][1] == 'a') {
get_all = 1;
get_tree = 1;
get_history = 1;
+ get_delta = 1;
} else if (argv[arg][1] == 'v') {
get_verbosely = 1;
}
arg++;
}
if (argc < arg + 2) {
- usage("git-rpull [-c] [-t] [-a] [-v] commit-id url");
+ usage("git-rpull [-c] [-t] [-a] [-v] [-d] commit-id url");
return 1;
}
commit_id = argv[arg];
------------------------------------------------
next prev parent reply other threads:[~2005-06-01 8:22 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-30 20:00 I want to release a "git-1.0" Linus Torvalds
2005-05-30 20:33 ` jeff millar
2005-05-30 20:49 ` Nicolas Pitre
2005-06-01 6:52 ` Junio C Hamano
2005-06-01 8:24 ` Junio C Hamano [this message]
2005-06-01 14:39 ` [PATCH] Add -d flag to git-pull-* family Nicolas Pitre
2005-06-01 16:00 ` Junio C Hamano
[not found] ` <7v1x7lk8fl.fsf_-_@assigned-by-dhcp.cox.net>
2005-06-02 0:47 ` [PATCH] Handle deltified object correctly in git-*-pull family Nicolas Pitre
[not found] ` <7vpsv5hbm5.fsf@assigned-by-dhcp.cox.net>
2005-06-02 0:51 ` [PATCH] Stop inflating the whole SHA1 file only to check size Nicolas Pitre
2005-06-02 1:32 ` Junio C Hamano
2005-06-02 0:58 ` [PATCH] Handle deltified object correctly in git-*-pull family Linus Torvalds
2005-06-02 1:43 ` Junio C Hamano
2005-05-30 20:59 ` I want to release a "git-1.0" Junio C Hamano
2005-05-30 21:07 ` Junio C Hamano
2005-05-30 22:11 ` David Greaves
2005-05-30 22:12 ` Dave Jones
2005-05-30 22:55 ` Dmitry Torokhov
2005-05-30 23:15 ` Junio C Hamano
2005-05-30 23:23 ` Dmitry Torokhov
2005-05-31 0:52 ` Linus Torvalds
2005-05-30 22:19 ` Ryan Anderson
2005-05-31 0:58 ` Linus Torvalds
2005-05-30 22:32 ` Chris Wedgwood
2005-05-30 23:56 ` Chris Wedgwood
2005-05-31 1:06 ` Linus Torvalds
2005-06-01 2:11 ` Junio C Hamano
2005-06-01 2:25 ` David Lang
2005-06-01 4:53 ` Junio C Hamano
2005-06-01 20:06 ` David Lang
2005-06-01 20:16 ` C. Scott Ananian
2005-06-02 0:43 ` Nicolas Pitre
2005-06-02 1:14 ` Brian O'Mahoney
2005-06-01 23:03 ` Junio C Hamano
2005-05-31 0:19 ` Petr Baudis
2005-05-31 13:45 ` Eric W. Biederman
2005-06-01 3:04 ` Linus Torvalds
2005-06-01 4:06 ` Junio C Hamano
2005-06-02 23:54 ` [PATCH] Fix -B "very-different" logic Junio C Hamano
2005-06-03 0:21 ` Linus Torvalds
2005-06-03 1:33 ` Junio C Hamano
2005-06-03 8:32 ` [PATCH 0/4] " Junio C Hamano
2005-06-03 8:36 ` [PATCH 1/4] Tweak count-delta interface Junio C Hamano
2005-06-03 8:36 ` [PATCH 2/4] diff: Fix docs and add -O to diff-helper Junio C Hamano
2005-06-03 8:37 ` [PATCH 3/4] diff: Clean up diff_scoreopt_parse() Junio C Hamano
2005-06-03 8:40 ` [PATCH 4/4] diff: Update -B heuristics Junio C Hamano
2005-06-01 6:28 ` I want to release a "git-1.0" Junio C Hamano
2005-06-01 22:00 ` Daniel Barkalow
2005-06-01 23:05 ` Junio C Hamano
2005-06-03 9:47 ` Petr Baudis
2005-06-03 15:09 ` Daniel Barkalow
2005-06-02 7:15 ` Eric W. Biederman
2005-06-02 8:32 ` Kay Sievers
2005-06-02 14:52 ` Linus Torvalds
2005-06-02 12:02 ` [PATCH] several typos in tutorial Alexey Nezhdanov
2005-06-02 12:41 ` Vincent Hanquez
2005-06-02 12:45 ` Alexey Nezhdanov
2005-06-02 12:51 ` Vincent Hanquez
2005-06-02 12:56 ` Alexey Nezhdanov
2005-06-02 13:00 ` Alexey Nezhdanov
2005-06-02 23:40 ` I want to release a "git-1.0" Adam Kropelin
2005-06-03 0:06 ` Linus Torvalds
2005-06-03 0:47 ` Linus Torvalds
2005-06-03 1:34 ` Adam Kropelin
2005-06-02 19:43 ` CVS migration section to the tutorial Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vu0kilc21.fsf_-_@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).