From: Dmitry Torokhov <dtor_core@ameritech.net>
To: git@vger.kernel.org
Cc: Dave Jones <davej@redhat.com>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: I want to release a "git-1.0"
Date: Mon, 30 May 2005 18:23:02 -0500 [thread overview]
Message-ID: <200505301823.04338.dtor_core@ameritech.net> (raw)
In-Reply-To: <200505301755.15371.dtor_core@ameritech.net>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Monday 30 May 2005 17:55, Dmitry Torokhov wrote:
> On Monday 30 May 2005 17:12, Dave Jones wrote:
> > I realise you've got a nifty bunch of tools to apply a whole mbox of
> > patches, but that's not ideal if all of my patches aren't in mboxes
> > (some I create myself and toss in my spool, some I pull from bugzilla etc..)
>
> I mercilessly hacked Linus's scripts from git-tools repo to work with
> non-mailbox patches, maybe you can make use of them too. Note that
> stripspace.c is not changed in any way whatsoever and mailsplit.c was
> changed to handle my personal preference of having patch description
> in the form of:
>
> Input: make blah blah change
> ---
>
> And Linus's script would eat that line.
>
Oops, make it mailinfo.c, not mailsplit.c
--
Dmitry
[-- Attachment #2: mailinfo.c --]
[-- Type: text/x-csrc, Size: 5691 bytes --]
/*
* Another stupid program, this one parsing the headers of an
* email to figure out authorship and subject
*/
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
static FILE *cmitmsg, *patchfile, *filelist;
static char line[1000];
static char date[1000];
static char name[1000];
static char email[1000];
static char subject[1000];
static char *sanity_check(char *name, char *email)
{
int len = strlen(name);
if (len < 3 || len > 60)
return email;
if (strchr(name, '@') || strchr(name, '<') || strchr(name, '>'))
return email;
return name;
}
static int handle_from(char *line)
{
char *at = strchr(line, '@');
char *dst;
if (!at)
return 0;
/*
* If we already have one email, don't take any confusing lines
*/
if (*email && strchr(at + 1, '@'))
return 0;
while (at > line) {
char c = at[-1];
if (isspace(c) || c == '<')
break;
at--;
}
dst = email;
for (;;) {
unsigned char c = *at;
if (!c || c == '>' || isspace(c))
break;
*at++ = ' ';
*dst++ = c;
}
*dst++ = 0;
at = line + strlen(line);
while (at > line) {
unsigned char c = *--at;
if (isalnum(c))
break;
*at = 0;
}
at = line;
for (;;) {
unsigned char c = *at;
if (!c)
break;
if (isalnum(c))
break;
at++;
}
at = sanity_check(at, email);
strcpy(name, at);
return 1;
}
static void handle_date(char *line)
{
strcpy(date, line);
}
static void handle_subject(char *line)
{
strcpy(subject, line);
}
static void add_subject_line(char *line)
{
while (isspace(*line))
line++;
*--line = ' ';
strcat(subject, line);
}
static int check_special_line(char *line, int len)
{
static int cont = -1;
if (!memcmp(line, "From:", 5) && isspace(line[5])) {
handle_from(line + 6);
cont = 0;
return 1;
}
if (!memcmp(line, "Date:", 5) && isspace(line[5])) {
handle_date(line + 6);
cont = 0;
return 1;
}
if (!memcmp(line, "Subject:", 8) && isspace(line[8])) {
handle_subject(line + 9);
cont = 1;
return 1;
}
if (isspace(*line)) {
switch (cont) {
case 0:
fprintf(stderr,
"I don't do 'Date:' or 'From:' line continuations\n");
break;
case 1:
add_subject_line(line);
return 1;
default:
break;
}
}
cont = -1;
return 0;
}
static char *cleanup_subject(char *subject)
{
for (;;) {
char *p;
int len, remove;
switch (*subject) {
case 'r':
case 'R':
if (!memcmp("e:", subject + 1, 2)) {
subject += 3;
continue;
}
break;
case ' ':
case '\t':
case ':':
subject++;
continue;
case '[':
p = strchr(subject, ']');
if (!p) {
subject++;
continue;
}
len = strlen(p);
remove = p - subject;
if (remove <= len * 2) {
subject = p + 1;
continue;
}
break;
}
return subject;
}
}
static void cleanup_space(char *buf)
{
unsigned char c;
while ((c = *buf) != 0) {
buf++;
if (isspace(c)) {
buf[-1] = ' ';
c = *buf;
while (isspace(c)) {
int len = strlen(buf);
memmove(buf, buf + 1, len);
c = *buf;
}
}
}
}
/*
* Hacky hacky. This depends not only on -p1, but on
* filenames not having some special characters in them,
* like tilde.
*/
static void show_filename(char *line)
{
int len;
char *name = strchr(line, '/');
if (!name || !isspace(*line))
return;
name++;
len = 0;
for (;;) {
unsigned char c = name[len];
switch (c) {
default:
len++;
continue;
case 0:
case ' ':
case '\t':
case '\n':
break;
/* patch tends to special-case these things.. */
case '~':
break;
}
break;
}
/* remove ".orig" from the end - common patch behaviour */
if (len > 5 && !memcmp(name + len - 5, ".orig", 5))
len -= 5;
if (!len)
return;
fprintf(filelist, "%.*s\n", len, name);
}
static void handle_rest(void)
{
char *sub = cleanup_subject(subject);
cleanup_space(name);
cleanup_space(date);
cleanup_space(email);
cleanup_space(sub);
printf("Author: %s\nEmail: %s\nSubject: %s\nDate: %s\n\n", name, email,
sub, date);
FILE *out = cmitmsg;
do {
/* Track filename information from the patch.. */
if (!memcmp("---", line, 3)) {
out = patchfile;
show_filename(line + 3);
}
if (!memcmp("+++", line, 3))
show_filename(line + 3);
fputs(line, out);
} while (fgets(line, sizeof(line), stdin) != NULL);
if (out == cmitmsg) {
fprintf(stderr, "No patch found\n");
exit(1);
}
fclose(cmitmsg);
fclose(patchfile);
}
static int eatspace(char *line)
{
int len = strlen(line);
while (len > 0 && isspace(line[len - 1]))
line[--len] = 0;
return len;
}
static void handle_body(void)
{
int has_from = 0;
/* First line of body can be a From: */
while (fgets(line, sizeof(line), stdin) != NULL) {
int len = eatspace(line);
if (!len)
continue;
if (!memcmp("From:", line, 5) && isspace(line[5])) {
if (!has_from && handle_from(line + 6)) {
has_from = 1;
continue;
}
}
line[len] = '\n';
handle_rest();
break;
}
}
static void usage(void)
{
fprintf(stderr, "mailinfo msg-file path-file filelist-file < email\n");
exit(1);
}
int main(int argc, char **argv)
{
int mail_patch = 0;
if (argc != 4)
usage();
cmitmsg = fopen(argv[1], "w");
if (!cmitmsg) {
perror(argv[1]);
exit(1);
}
patchfile = fopen(argv[2], "w");
if (!patchfile) {
perror(argv[2]);
exit(1);
}
filelist = fopen(argv[3], "w");
if (!filelist) {
perror(argv[3]);
exit(1);
}
while (fgets(line, sizeof(line), stdin) != NULL) {
int len = eatspace(line);
if (!len) {
if (!mail_patch)
fputs("\n", cmitmsg);
handle_body();
break;
}
if (check_special_line(line, len)) {
mail_patch = 1;
rewind(cmitmsg);
}
if (!mail_patch) {
line[len] = '\n';
fputs(line, cmitmsg);
}
}
return 0;
}
next prev parent reply other threads:[~2005-05-30 23:25 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-30 20:00 I want to release a "git-1.0" Linus Torvalds
2005-05-30 20:33 ` jeff millar
2005-05-30 20:49 ` Nicolas Pitre
2005-06-01 6:52 ` Junio C Hamano
2005-06-01 8:24 ` [PATCH] Add -d flag to git-pull-* family Junio C Hamano
2005-06-01 14:39 ` Nicolas Pitre
2005-06-01 16:00 ` Junio C Hamano
[not found] ` <7v1x7lk8fl.fsf_-_@assigned-by-dhcp.cox.net>
2005-06-02 0:47 ` [PATCH] Handle deltified object correctly in git-*-pull family Nicolas Pitre
[not found] ` <7vpsv5hbm5.fsf@assigned-by-dhcp.cox.net>
2005-06-02 0:51 ` [PATCH] Stop inflating the whole SHA1 file only to check size Nicolas Pitre
2005-06-02 1:32 ` Junio C Hamano
2005-06-02 0:58 ` [PATCH] Handle deltified object correctly in git-*-pull family Linus Torvalds
2005-06-02 1:43 ` Junio C Hamano
2005-05-30 20:59 ` I want to release a "git-1.0" Junio C Hamano
2005-05-30 21:07 ` Junio C Hamano
2005-05-30 22:11 ` David Greaves
2005-05-30 22:12 ` Dave Jones
2005-05-30 22:55 ` Dmitry Torokhov
2005-05-30 23:15 ` Junio C Hamano
2005-05-30 23:23 ` Dmitry Torokhov [this message]
2005-05-31 0:52 ` Linus Torvalds
2005-05-30 22:19 ` Ryan Anderson
2005-05-31 0:58 ` Linus Torvalds
2005-05-30 22:32 ` Chris Wedgwood
2005-05-30 23:56 ` Chris Wedgwood
2005-05-31 1:06 ` Linus Torvalds
2005-06-01 2:11 ` Junio C Hamano
2005-06-01 2:25 ` David Lang
2005-06-01 4:53 ` Junio C Hamano
2005-06-01 20:06 ` David Lang
2005-06-01 20:16 ` C. Scott Ananian
2005-06-02 0:43 ` Nicolas Pitre
2005-06-02 1:14 ` Brian O'Mahoney
2005-06-01 23:03 ` Junio C Hamano
2005-05-31 0:19 ` Petr Baudis
2005-05-31 13:45 ` Eric W. Biederman
2005-06-01 3:04 ` Linus Torvalds
2005-06-01 4:06 ` Junio C Hamano
2005-06-02 23:54 ` [PATCH] Fix -B "very-different" logic Junio C Hamano
2005-06-03 0:21 ` Linus Torvalds
2005-06-03 1:33 ` Junio C Hamano
2005-06-03 8:32 ` [PATCH 0/4] " Junio C Hamano
2005-06-03 8:36 ` [PATCH 1/4] Tweak count-delta interface Junio C Hamano
2005-06-03 8:36 ` [PATCH 2/4] diff: Fix docs and add -O to diff-helper Junio C Hamano
2005-06-03 8:37 ` [PATCH 3/4] diff: Clean up diff_scoreopt_parse() Junio C Hamano
2005-06-03 8:40 ` [PATCH 4/4] diff: Update -B heuristics Junio C Hamano
2005-06-01 6:28 ` I want to release a "git-1.0" Junio C Hamano
2005-06-01 22:00 ` Daniel Barkalow
2005-06-01 23:05 ` Junio C Hamano
2005-06-03 9:47 ` Petr Baudis
2005-06-03 15:09 ` Daniel Barkalow
2005-06-02 7:15 ` Eric W. Biederman
2005-06-02 8:32 ` Kay Sievers
2005-06-02 14:52 ` Linus Torvalds
2005-06-02 12:02 ` [PATCH] several typos in tutorial Alexey Nezhdanov
2005-06-02 12:41 ` Vincent Hanquez
2005-06-02 12:45 ` Alexey Nezhdanov
2005-06-02 12:51 ` Vincent Hanquez
2005-06-02 12:56 ` Alexey Nezhdanov
2005-06-02 13:00 ` Alexey Nezhdanov
2005-06-02 23:40 ` I want to release a "git-1.0" Adam Kropelin
2005-06-03 0:06 ` Linus Torvalds
2005-06-03 0:47 ` Linus Torvalds
2005-06-03 1:34 ` Adam Kropelin
2005-06-02 19:43 ` CVS migration section to the tutorial Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505301823.04338.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=davej@redhat.com \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).