* [PATCH 1/2] show-ref.c: Add missing call to git_config()
@ 2013-06-15 20:29 Ramsay Jones
2013-06-17 3:05 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Ramsay Jones @ 2013-06-15 20:29 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list
At present, 'git show-ref' ignores any attempt to set config
variables (e.g. core.checkstat) from the command line using
the -c option to git. In order to enable such usage, add the
missing call to git_config() from cmd_show_ref().
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
builtin/show-ref.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/builtin/show-ref.c b/builtin/show-ref.c
index 8d9b76a..95f5ca9 100644
--- a/builtin/show-ref.c
+++ b/builtin/show-ref.c
@@ -191,6 +191,8 @@ int cmd_show_ref(int argc, const char **argv, const char *prefix)
if (argc == 2 && !strcmp(argv[1], "-h"))
usage_with_options(show_ref_usage, show_ref_options);
+ git_config(git_default_config, NULL);
+
argc = parse_options(argc, argv, prefix, show_ref_options,
show_ref_usage, PARSE_OPT_NO_INTERNAL_HELP);
--
1.8.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] show-ref.c: Add missing call to git_config()
2013-06-15 20:29 [PATCH 1/2] show-ref.c: Add missing call to git_config() Ramsay Jones
@ 2013-06-17 3:05 ` Junio C Hamano
2013-06-18 18:38 ` Ramsay Jones
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2013-06-17 3:05 UTC (permalink / raw)
To: Ramsay Jones; +Cc: GIT Mailing-list
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> At present, 'git show-ref' ignores any attempt to set config
> variables (e.g. core.checkstat) from the command line using
> the -c option to git.
I think what you really want to see is not giving "-c" and have it
honored.
"git show-ref" does not honor configuration variables at
all, but at least core configuration variables read by
git_default_config (most importantly core.checkstat) should
be read and honored, because ...
would be more appropriate. What are the variables that matter to
show-ref, and what are the reasons why they should be honored? I
thought show-ref was just a way to enumerate refs, and does not read
the index nor checks if there are modifications in the working tree,
so I do not see any reason offhand for it to honor core.checkstat
(and I think that is the reason why we don't have the call there in
the current code).
Exactly the same comment applies to 2/2.
Note that I am _not_ opposing these changes. You brought them up
because you saw some reason why these should honor some core
variables. I just want that reason to be explained in the log for
the future developers.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] show-ref.c: Add missing call to git_config()
2013-06-17 3:05 ` Junio C Hamano
@ 2013-06-18 18:38 ` Ramsay Jones
2013-07-01 21:56 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Ramsay Jones @ 2013-06-18 18:38 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list, mhagger
Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>
>> At present, 'git show-ref' ignores any attempt to set config
>> variables (e.g. core.checkstat) from the command line using
>> the -c option to git.
>
> I think what you really want to see is not giving "-c" and have it
> honored.
>
> "git show-ref" does not honor configuration variables at
> all, but at least core configuration variables read by
> git_default_config (most importantly core.checkstat) should
> be read and honored, because ...
>
> would be more appropriate. What are the variables that matter to
> show-ref, and what are the reasons why they should be honored? I
> thought show-ref was just a way to enumerate refs, and does not read
> the index nor checks if there are modifications in the working tree,
> so I do not see any reason offhand for it to honor core.checkstat
> (and I think that is the reason why we don't have the call there in
> the current code).
:-D Yes, you caught me!
These patches *may* not be necessary, prior to Michael's
"reference related races" series. Specifically, the introduction
of the stat_validity_check() function to the reference handling API.
This means that the behaviour 'git show-ref' is now affected by
several config variables, including core.checkstat. I haven't
spent any time auditing the code, but the list would include
(at least) core.trustctime, core.filemode, core.checkstat,
core.ignorecygwinfstricks, ...
>
> Exactly the same comment applies to 2/2.
ditto
> Note that I am _not_ opposing these changes. You brought them up
> because you saw some reason why these should honor some core
> variables. I just want that reason to be explained in the log for
> the future developers.
Yes, I will send a v2 (soon-ish, I hope).
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-04 18:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-15 20:29 [PATCH 1/2] show-ref.c: Add missing call to git_config() Ramsay Jones
2013-06-17 3:05 ` Junio C Hamano
2013-06-18 18:38 ` Ramsay Jones
2013-07-01 21:56 ` Junio C Hamano
2013-07-04 18:25 ` Ramsay Jones
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).