From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] show-ref.c: Add missing call to git_config()
Date: Sun, 16 Jun 2013 20:05:48 -0700 [thread overview]
Message-ID: <7vppvlighf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <51BCCE98.3070201@ramsay1.demon.co.uk> (Ramsay Jones's message of "Sat, 15 Jun 2013 21:29:12 +0100")
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> At present, 'git show-ref' ignores any attempt to set config
> variables (e.g. core.checkstat) from the command line using
> the -c option to git.
I think what you really want to see is not giving "-c" and have it
honored.
"git show-ref" does not honor configuration variables at
all, but at least core configuration variables read by
git_default_config (most importantly core.checkstat) should
be read and honored, because ...
would be more appropriate. What are the variables that matter to
show-ref, and what are the reasons why they should be honored? I
thought show-ref was just a way to enumerate refs, and does not read
the index nor checks if there are modifications in the working tree,
so I do not see any reason offhand for it to honor core.checkstat
(and I think that is the reason why we don't have the call there in
the current code).
Exactly the same comment applies to 2/2.
Note that I am _not_ opposing these changes. You brought them up
because you saw some reason why these should honor some core
variables. I just want that reason to be explained in the log for
the future developers.
next prev parent reply other threads:[~2013-06-17 3:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 20:29 [PATCH 1/2] show-ref.c: Add missing call to git_config() Ramsay Jones
2013-06-17 3:05 ` Junio C Hamano [this message]
2013-06-18 18:38 ` Ramsay Jones
2013-07-01 21:56 ` Junio C Hamano
2013-07-04 18:25 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vppvlighf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).