Re: GSOC idea: build in scripts and cleanups

[Junio C Hamano <gitster@pobox.com>]

Robert David <robert.david.public@gmail.com> writes:

> This task also include cleaning the functionality of this code, to make these 
> functions more "standardized". 
> This means consolidate the differences in these functions and make them more 
> consistent in the user point of view.

Standardized, consolidate, consistent are all pretty words but at the same
time they are highly subjective. Even though you may not have to have the
detailed description of everything in the proposal, you would need to at
least have a handful of examples of what are wrong with the current code
in mind when making such a sweeping statement, but I cannot sense that
from this proposal.

While reading the current add-i code recently, I noticed that over time
the code quality deteriorated compared to the reasonably clean design in
the original version, perhaps due to excessive copying and mimicing,
especially when "Edit patch" feature was added and then more recently when
new modes to apply patches in different directions are added to allow
other commands like "git reset" and "git checkout" to implement their
"--patch" options.

An example of a clean-up in the right direction may be a patch I posted a
few days ago:

  http://thread.gmane.org/gmane.comp.version-control.git/170685/focus=171017 

Is that the kind of "consolidation" you have in mind?

Also I am a bit puzzled by the inconsistency between the various stages of
your goals.  A clearly stated primary goal is:

> Main and final project goal is integrating fully git-add--interactive into 
> current git-add code.

but the success criteria is only about the above "This task also include"?