From: Jeff King <peff@peff.net>
To: Robert David <robert.david.public@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Thomas Rast <trast@student.ethz.ch>,
Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: Re: GSOC idea: build in scripts and cleanups
Date: Mon, 28 Mar 2011 10:21:21 -0400 [thread overview]
Message-ID: <20110328142121.GB14763@sigill.intra.peff.net> (raw)
In-Reply-To: <201103281055.23578.robert.david.public@gmail.com>
On Mon, Mar 28, 2011 at 10:55:22AM +0200, Robert David wrote:
> > If I were considering cleaning up and porting add--interactive to C, I
> > think I would probably start with just porting the "-p" patch loop
> > first. I think it's the part that most people use, and most callers
> > don't support a generic "-i" but just the "-p" interface (e.g., you can
> > do "git add -i" or "git add -p", but only "git checkout -p"). And that
> > cuts down the size of the task somewhat.
>
> I have read all the code in git-add--interactive. If I understand that
> correct, you mean to separate -i and -p int two different commands.
> And make the -p option more like the -i (but just only for patching).
>
> And consequently port them to C.
Sort of. The approach I would take would be:
1. write patch loop code in C (i.e., the code that is going to replace
the --patch code path from git-add--interactive.perl), and make it
call-able from within other C programs
2. write a new command, "git-add--interactive-patch", that behaves
like "git-add--interactive --patch", but is based on your new C
code.
3. Port C callers of "git-add--interactive --patch" to the new
interface from (1). This should be "add -p", "checkout -p", and
"reset -p".
4. Port non-C callers of "git-add--interactive --patch" to the new
command from (2). This should be git-add--interactive.perl and
git-stash.sh.
5. Remove the perl patch code in git-add--interactive.perl; you can
replace it with a call to git-add--interactive-patch.
But that doesn't mean that's the way it has to be done. Just what I
would do. :)
> > As far as cleanup versus features, I think Thomas would have to comment
> > on that. He is the one who did the most work on patch-mode, and
> > therefore the one who most thinks it needs cleaned up. :)
>
> Is Thomas going to be a mentor in this task?
I hope so. I can also co-mentor if it helps.
-Peff
next prev parent reply other threads:[~2011-03-28 14:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 0:41 GSOC idea: build in scripts and cleanups Robert David
2011-03-26 2:14 ` Jonathan Nieder
2011-03-26 13:39 ` Jeff King
2011-03-28 8:55 ` Robert David
2011-03-28 14:21 ` Jeff King [this message]
2011-03-30 15:39 ` Thomas Rast
2011-03-30 21:17 ` Robert David
2011-04-03 21:17 ` Robert David
2011-04-04 7:43 ` Robert David
2011-04-04 18:09 ` Junio C Hamano
2011-04-04 18:51 ` Robert David
2011-04-05 17:07 ` Jeff King
2011-04-05 18:18 ` Junio C Hamano
2011-04-05 16:52 ` Jeff King
2011-04-05 23:27 ` Robert David
2011-04-07 13:30 ` Robert David
2011-04-07 22:19 ` Junio C Hamano
2011-04-08 9:51 ` Robert David
2011-04-11 6:34 ` Jonathan Nieder
2011-04-17 18:50 ` Robert David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328142121.GB14763@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=robert.david.public@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).