From: Jonathan Nieder <jrnieder@gmail.com>
To: Robert David <robert.david.public@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Thomas Rast <trast@student.ethz.ch>,
Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: Re: GSOC idea: build in scripts and cleanups
Date: Fri, 25 Mar 2011 21:14:35 -0500 [thread overview]
Message-ID: <20110326021435.GA2352@elie> (raw)
In-Reply-To: <201103260141.20798.robert.david.public@gmail.com>
(+cc: various relevant people for ideas)
Hi,
Robert David wrote:
> I'm long time user of git and very interested in development participation.
Welcome!
> Having passing your GSOC ideas, keep my eyes on scripts building in and also
> git add -p cleanups. Because I like this kind of work.
>
> Because there are more thinks to do in the cleanup and rewrite task, I would
> like to ask if there is some priority in these tasks? To let me focus on the
> most important parts.
Looking at the git-add--interactive.perl source, I see:
process_args();
refresh();
if ($patch_mode) {
patch_update_cmd();
}
[...]
and patch_update_cmd looks like
my @all_mods = list_modified($patch_mode_flavour{FILTER});
my @mods = grep { !($_->{BINARY}) } @all_mods;
[...]
if ($patch_mode) {
@them = @mods;
}
[...]
for (@them) {
return 0 if patch_update_file($_->{VALUE});
}
patch_update_file loops over hunks in the diff for that file and acts
on them one at a time. So a natural step might be to eliminate this
outer "for (@them)" loop, so the person at the keyboard could decide
to go back to a previous file or list all files and choose one.
Others may have more to say. If there are things you wished "git
checkout --patch" was able to do, that can also help.
> I was also thinking if there isn't PERL a better choice in rewriting shell
> scripts, due to planed porting (android, etc). Better than C. But I don't know
> android and other platform so much, so thats why I'm asking.
So far (on Windows and various Unixen) it seems that C is much easier
to work with as far as porting goes.[2]
Jonathan
[1] Android is an odd example because the platform uses Java heavily
(so JGit might be a better fit for it). Perhaps the wish for android
support should have been put on the Eclipse ideas page[2] and a link
added to git's; I dunno.
[2] http://wiki.eclipse.org/Google_Summer_of_Code_2011_Ideas#Ideas_submission
next prev parent reply other threads:[~2011-03-26 2:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 0:41 GSOC idea: build in scripts and cleanups Robert David
2011-03-26 2:14 ` Jonathan Nieder [this message]
2011-03-26 13:39 ` Jeff King
2011-03-28 8:55 ` Robert David
2011-03-28 14:21 ` Jeff King
2011-03-30 15:39 ` Thomas Rast
2011-03-30 21:17 ` Robert David
2011-04-03 21:17 ` Robert David
2011-04-04 7:43 ` Robert David
2011-04-04 18:09 ` Junio C Hamano
2011-04-04 18:51 ` Robert David
2011-04-05 17:07 ` Jeff King
2011-04-05 18:18 ` Junio C Hamano
2011-04-05 16:52 ` Jeff King
2011-04-05 23:27 ` Robert David
2011-04-07 13:30 ` Robert David
2011-04-07 22:19 ` Junio C Hamano
2011-04-08 9:51 ` Robert David
2011-04-11 6:34 ` Jonathan Nieder
2011-04-17 18:50 ` Robert David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110326021435.GA2352@elie \
--to=jrnieder@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=robert.david.public@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).