From: "Philip Oakley" <philipoakley@iee.org>
To: "Daniele Segato" <daniele.segato@gmail.com>, "Jeff King" <peff@peff.net>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Marc Branchaud" <marcnarc@xiplink.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCHv3] git-tag man: when to use lightweight or annotated tags
Date: Sat, 27 Jul 2013 12:26:26 +0100 [thread overview]
Message-ID: <720060083F5C476A905C09146E7CD711@PhilipOakley> (raw)
In-Reply-To: 51F3A358.5000807@gmail.com
From: "Daniele Segato" <daniele.segato@gmail.com>
> On 07/26/2013 09:06 PM, Jeff King wrote:
>> On Fri, Jul 26, 2013 at 07:33:01PM +0200, Daniele Segato wrote:
>>
>>> stress the difference between the two with suggestion on when the
>>> user
>>> should use one in place of the other.
>>>
>>> Signed-off-by: Daniele Segato <daniele.segato@gmail.com>
>>
>> The intent of your patch seems reasonable to me. There are a few
>> minor
>> language and typographical mistakes, and the patch itself is
>> whitespace-damaged.
>
> Hi Jeff,
>
> thanks for the feedback, very appreciated.
>
> But I don't understand what's wrong with the whitespaces.
>
> Can you explain to me what's wrong and how I can avoid the issue?
>
> I use thunderbird in text mode to send emails, should I use something
> else? what?
Try 'git format-patch' and 'git send-email'. The format-patch man page
even has a note about Thunderbird corruptions.
Philip
>
>>
>> I also do not know that it is accurate to say "most git commands
>> ignore
>> lightweight tags". It is really only "naming" ones like "git
>> describe".
>>
>> Here is a re-send of your patch with the fixups I would recommend.
>>
>
> Thanks, it's obviously better.
>
> I'll send this new version as soon as you or someone else explain me
> how to fix the whitespace damage.
>
[snip]
next prev parent reply other threads:[~2013-07-27 11:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 10:17 git tag usability issue: Lightweight vs Annotated confusion for the end user (ex. git describe default) Daniele Segato
2013-07-24 20:34 ` Junio C Hamano
2013-07-25 13:45 ` [PATCH] git-tag man: when to use lightweight or annotated tags Daniele Segato
2013-07-25 14:47 ` Marc Branchaud
2013-07-26 8:44 ` Daniele Segato
2013-07-26 8:46 ` Daniele Segato
2013-07-26 14:51 ` Marc Branchaud
2013-07-26 17:19 ` Daniele Segato
2013-07-26 17:33 ` [PATCHv3] " Daniele Segato
2013-07-26 19:06 ` Jeff King
2013-07-26 19:36 ` Jonathan Nieder
2013-07-29 18:02 ` Daniele Segato
2013-08-07 12:32 ` Daniele Segato
2013-07-26 21:13 ` Marc Branchaud
2013-07-29 15:04 ` Junio C Hamano
2013-07-29 18:20 ` Daniele Segato
2013-07-27 10:39 ` Daniele Segato
2013-07-27 11:26 ` Philip Oakley [this message]
2013-07-27 11:45 ` Stefan Beller
2013-07-29 18:16 ` Daniele Segato
2013-07-26 21:13 ` [PATCH] " Marc Branchaud
2013-07-29 18:21 ` Daniele Segato
2013-07-25 13:48 ` git tag usability issue: Lightweight vs Annotated confusion for the end user (ex. git describe default) Daniele Segato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=720060083F5C476A905C09146E7CD711@PhilipOakley \
--to=philipoakley@iee.org \
--cc=daniele.segato@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=marcnarc@xiplink.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).