git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Daniele Segato <daniele.segato@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Marc Branchaud <marcnarc@xiplink.com>, Jeff King <peff@peff.net>,
	Git Mailing List <git@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCHv3] git-tag man: when to use lightweight or annotated tags
Date: Mon, 29 Jul 2013 20:20:12 +0200	[thread overview]
Message-ID: <51F6B25C.9040800@gmail.com> (raw)
In-Reply-To: <7v4nbd2ys2.fsf@alter.siamese.dyndns.org>

On 07/29/2013 05:04 PM, Junio C Hamano wrote:
> Marc Branchaud <marcnarc@xiplink.com> writes:
>
>> On 13-07-26 03:06 PM, Jeff King wrote:
>>> On Fri, Jul 26, 2013 at 07:33:01PM +0200, Daniele Segato wrote:
>>>
>>>> stress the difference between the two with suggestion on when the user
>>>> should use one in place of the other.
>>>>
>>>> Signed-off-by: Daniele Segato <daniele.segato@gmail.com>
>>>
>>> The intent of your patch seems reasonable to me. There are a few minor
>>> language and typographical mistakes, and the patch itself is
>>> whitespace-damaged.
>>>
>>> I also do not know that it is accurate to say "most git commands ignore
>>> lightweight tags". It is really only "naming" ones like "git describe".
>>>
>>> Here is a re-send of your patch with the fixups I would recommend.
>>
>> I'm happy with Peff's version.
>>
>> Reviewed-by: Marc Branchaud <marcnarc@xiplink.com>
>>
>> (Daniele, don't feel put off because Jonathan & I are accepting Peff's text.
>>   If you think it still needs improving please speak up!)
>>

I'm not feeling putting off. I thank you for the help you gave me.
Hopefully I'll be able to provide a better patch next time.

>> 		M.
>
> Thank you all.  Will apply.
>

I'm probably too late, I did proposed another version of the page 
tweaking all the description part in response to Jonathan Nieder and 
re-using the Jeff King proposition.

I've been busy in the last days and couldn't reply before now.

I'll understand if you don't like it and don't want to lose more time on 
this.

Regards,
Daniele Segato

  reply	other threads:[~2013-07-29 18:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 10:17 git tag usability issue: Lightweight vs Annotated confusion for the end user (ex. git describe default) Daniele Segato
2013-07-24 20:34 ` Junio C Hamano
2013-07-25 13:45   ` [PATCH] git-tag man: when to use lightweight or annotated tags Daniele Segato
2013-07-25 14:47     ` Marc Branchaud
2013-07-26  8:44       ` Daniele Segato
2013-07-26  8:46         ` Daniele Segato
2013-07-26 14:51           ` Marc Branchaud
2013-07-26 17:19             ` Daniele Segato
2013-07-26 17:33               ` [PATCHv3] " Daniele Segato
2013-07-26 19:06                 ` Jeff King
2013-07-26 19:36                   ` Jonathan Nieder
2013-07-29 18:02                     ` Daniele Segato
2013-08-07 12:32                       ` Daniele Segato
2013-07-26 21:13                   ` Marc Branchaud
2013-07-29 15:04                     ` Junio C Hamano
2013-07-29 18:20                       ` Daniele Segato [this message]
2013-07-27 10:39                   ` Daniele Segato
2013-07-27 11:26                     ` Philip Oakley
2013-07-27 11:45                       ` Stefan Beller
2013-07-29 18:16                         ` Daniele Segato
2013-07-26 21:13               ` [PATCH] " Marc Branchaud
2013-07-29 18:21                 ` Daniele Segato
2013-07-25 13:48   ` git tag usability issue: Lightweight vs Annotated confusion for the end user (ex. git describe default) Daniele Segato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F6B25C.9040800@gmail.com \
    --to=daniele.segato@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=marcnarc@xiplink.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).