From: Marc Branchaud <marcnarc@xiplink.com>
To: Jeff King <peff@peff.net>
Cc: Daniele Segato <daniele.segato@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv3] git-tag man: when to use lightweight or annotated tags
Date: Fri, 26 Jul 2013 17:13:26 -0400 [thread overview]
Message-ID: <51F2E676.6080404@xiplink.com> (raw)
In-Reply-To: <20130726190602.GC29799@sigill.intra.peff.net>
On 13-07-26 03:06 PM, Jeff King wrote:
> On Fri, Jul 26, 2013 at 07:33:01PM +0200, Daniele Segato wrote:
>
>> stress the difference between the two with suggestion on when the user
>> should use one in place of the other.
>>
>> Signed-off-by: Daniele Segato <daniele.segato@gmail.com>
>
> The intent of your patch seems reasonable to me. There are a few minor
> language and typographical mistakes, and the patch itself is
> whitespace-damaged.
>
> I also do not know that it is accurate to say "most git commands ignore
> lightweight tags". It is really only "naming" ones like "git describe".
>
> Here is a re-send of your patch with the fixups I would recommend.
I'm happy with Peff's version.
Reviewed-by: Marc Branchaud <marcnarc@xiplink.com>
(Daniele, don't feel put off because Jonathan & I are accepting Peff's text.
If you think it still needs improving please speak up!)
M.
> -- >8 --
> From: Daniele Segato <daniele.segato@gmail.com>
> Subject: [PATCH] docs/git-tag: explain lightweight versus annotated tags
>
> Stress the difference between the two with a suggestion on
> when the user should use one in place of the other.
>
> Signed-off-by: Daniele Segato <daniele.segato@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Documentation/git-tag.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
> index 22894cb..c418c44 100644
> --- a/Documentation/git-tag.txt
> +++ b/Documentation/git-tag.txt
> @@ -42,6 +42,17 @@ is used to specify custom GnuPG binary.
> GnuPG key for signing. The configuration variable `gpg.program`
> is used to specify custom GnuPG binary.
>
> +Tag objects (created with `-a`, `s`, or `-u`) are called "annotated"
> +tags; they contain a creation date, the tagger name and e-mail, a
> +tagging message, and an optional GnuPG signature. Whereas a
> +"lightweight" tag is simply a name for an object (usually a commit
> +object).
> +
> +Annotated tags are meant for release while lightweight tags are meant
> +for private or temporary object labels. For this reason, some git
> +commands for naming objects (like `git describe`) will ignore
> +lightweight tags by default.
> +
>
> OPTIONS
> -------
>
next prev parent reply other threads:[~2013-07-26 21:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 10:17 git tag usability issue: Lightweight vs Annotated confusion for the end user (ex. git describe default) Daniele Segato
2013-07-24 20:34 ` Junio C Hamano
2013-07-25 13:45 ` [PATCH] git-tag man: when to use lightweight or annotated tags Daniele Segato
2013-07-25 14:47 ` Marc Branchaud
2013-07-26 8:44 ` Daniele Segato
2013-07-26 8:46 ` Daniele Segato
2013-07-26 14:51 ` Marc Branchaud
2013-07-26 17:19 ` Daniele Segato
2013-07-26 17:33 ` [PATCHv3] " Daniele Segato
2013-07-26 19:06 ` Jeff King
2013-07-26 19:36 ` Jonathan Nieder
2013-07-29 18:02 ` Daniele Segato
2013-08-07 12:32 ` Daniele Segato
2013-07-26 21:13 ` Marc Branchaud [this message]
2013-07-29 15:04 ` Junio C Hamano
2013-07-29 18:20 ` Daniele Segato
2013-07-27 10:39 ` Daniele Segato
2013-07-27 11:26 ` Philip Oakley
2013-07-27 11:45 ` Stefan Beller
2013-07-29 18:16 ` Daniele Segato
2013-07-26 21:13 ` [PATCH] " Marc Branchaud
2013-07-29 18:21 ` Daniele Segato
2013-07-25 13:48 ` git tag usability issue: Lightweight vs Annotated confusion for the end user (ex. git describe default) Daniele Segato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2E676.6080404@xiplink.com \
--to=marcnarc@xiplink.com \
--cc=daniele.segato@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).