From: Jonathan del Strother <maillist@steelskies.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Quoting paths in tests
Date: Wed, 17 Oct 2007 18:07:38 +0100 [thread overview]
Message-ID: <6E65762D-FBC4-4A7C-97A9-20F6744E25DE@steelskies.com> (raw)
In-Reply-To: <4715F2E6.1000708@viscovery.net>
On 17 Oct 2007, at 12:32, Johannes Sixt wrote:
> Jonathan del Strother schrieb:
>> --- a/t/lib-git-svn.sh
>> +++ b/t/lib-git-svn.sh
>> @@ -25,7 +25,7 @@ perl -w -e "
>> use SVN::Core;
>> use SVN::Repos;
>> \$SVN::Core::VERSION gt '1.1.0' or exit(42);
>> -system(qw/svnadmin create --fs-type fsfs/, '$svnrepo') == 0 or
>> exit(41);
>> +system(qw/svnadmin create --fs-type fsfs/, \"$svnrepo\") == 0 or
>> exit(41);
>
> Here you have to work harder: The reason is that this is part of a
> perl expression (as opposed to an eval'd string), which does not
> have access to $svnrepo of the shell by which it is invoked. The
> original version failed if there were single-quotes in $svnrepo, the
> new version fails if it contains double-quotes.
...
>
> May I recommend that you run the test suite in a directory named
> like this:
>
> $ mkdir \"\ \$GIT_DIR\ \'
> $ ls
> " $GIT_DIR '
Eww. I'm struggling a bit with paths this perverse, actually.
For instance, git_editor in git-sh-setup expects the editor path to be
pre-quoted. So in t3404, you need to produce escaped double quotes &
dollar signs, resulting in unpleasantness like this :
VISUAL="`pwd`/fake-editor.sh"
VISUAL=${VISUAL//\"/\\\"}
VISUAL=${VISUAL//$/\\\$}
VISUAL=\"$VISUAL\"
export VISUAL
And I'm struggling to come up with neat ways of rewriting things like,
eg, this bit from t5500 -
test_expect_success "clone shallow" "git-clone --depth 2 \"file://
`pwd`/.\" shallow"
- to handle paths like that properly.
Suggestions?
Jon
next prev parent reply other threads:[~2007-10-17 17:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 21:13 [PATCH] Fixing path quoting issues Jonathan del Strother
2007-10-11 6:19 ` Johannes Sixt
2007-10-11 6:47 ` David Kastrup
2007-10-11 7:10 ` Johannes Sixt
2007-10-11 7:30 ` Jonathan del Strother
2007-10-11 7:41 ` Johannes Sixt
2007-10-11 20:53 ` David Kastrup
2007-10-11 21:22 ` Jonathan del Strother
2007-10-11 21:31 ` Johannes Schindelin
2007-10-11 21:40 ` David Kastrup
2007-10-12 6:43 ` Johannes Sixt
2007-10-12 11:17 ` Wincent Colaiuta
2007-10-12 11:37 ` Johannes Schindelin
2007-10-12 12:20 ` Wincent Colaiuta
2007-10-12 12:51 ` Johannes Schindelin
2007-10-12 13:14 ` David Kastrup
2007-10-13 18:12 ` Jonathan del Strother
2007-10-13 22:36 ` Andreas Ericsson
2007-10-15 13:13 ` Jonathan del Strother
2007-10-15 13:13 ` [PATCH 1/3] Fixing path quoting in git-rebase Jonathan del Strother
2007-10-15 13:39 ` Johannes Sixt
2007-10-17 9:14 ` Jonathan del Strother
2007-10-17 9:31 ` [PATCH] Quoting paths, take 3 Jonathan del Strother
2007-10-17 9:31 ` [PATCH 1/2] Fixing path quoting in git-rebase Jonathan del Strother
2007-10-17 9:31 ` [PATCH 2/2] Quoting paths in tests Jonathan del Strother
2007-10-17 11:32 ` Johannes Sixt
2007-10-17 17:07 ` Jonathan del Strother [this message]
2007-10-17 17:15 ` David Kastrup
2007-10-17 20:03 ` David Kastrup
2007-10-18 6:08 ` Johannes Sixt
2007-10-24 13:07 ` Jonathan del Strother
2007-10-17 10:41 ` [PATCH 1/2] Fixing path quoting in git-rebase Johannes Sixt
2007-10-15 13:13 ` [PATCH 2/3] Quoting paths in tests Jonathan del Strother
2007-10-15 13:47 ` Johannes Sixt
2007-10-15 14:00 ` Jonathan del Strother
2007-10-15 14:17 ` Johannes Sixt
2007-10-15 14:03 ` David Kastrup
2007-10-15 13:13 ` [PATCH 3/3] Fix apostrophe quoting " Jonathan del Strother
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E65762D-FBC4-4A7C-97A9-20F6744E25DE@steelskies.com \
--to=maillist@steelskies.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).