From: Johannes Sixt <j.sixt@viscovery.net>
To: Jonathan del Strother <maillist@steelskies.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Quoting paths in tests
Date: Thu, 18 Oct 2007 08:08:09 +0200 [thread overview]
Message-ID: <4716F849.3090102@viscovery.net> (raw)
In-Reply-To: <6E65762D-FBC4-4A7C-97A9-20F6744E25DE@steelskies.com>
Jonathan del Strother schrieb:
>
> On 17 Oct 2007, at 12:32, Johannes Sixt wrote:
>
>> Jonathan del Strother schrieb:
>>> --- a/t/lib-git-svn.sh
>>> +++ b/t/lib-git-svn.sh
>>> @@ -25,7 +25,7 @@ perl -w -e "
>>> use SVN::Core;
>>> use SVN::Repos;
>>> \$SVN::Core::VERSION gt '1.1.0' or exit(42);
>>> -system(qw/svnadmin create --fs-type fsfs/, '$svnrepo') == 0 or
>>> exit(41);
>>> +system(qw/svnadmin create --fs-type fsfs/, \"$svnrepo\") == 0 or
>>> exit(41);
>>
>> Here you have to work harder: The reason is that this is part of a
>> perl expression (as opposed to an eval'd string), which does not have
>> access to $svnrepo of the shell by which it is invoked. The original
>> version failed if there were single-quotes in $svnrepo, the new
>> version fails if it contains double-quotes.
You can rewrite this expression as
perl -w -e '$svnrepo = shift;
...
$SVN::Core::Version gt "1.1.0" ...
system(qw/svnadmin create --fs-type fsfs/, $svnrepo) == 0 ...
...
' >&3 2>&4 "$svnrepo"
i.e. you pass the repository name as an argument to the scriptlet.
>> May I recommend that you run the test suite in a directory named like
>> this:
>>
>> $ mkdir \"\ \$GIT_DIR\ \'
>> $ ls
>> " $GIT_DIR '
>
>
> Eww. I'm struggling a bit with paths this perverse, actually.
>
> For instance, git_editor in git-sh-setup expects the editor path to be
> pre-quoted. So in t3404, you need to produce escaped double quotes &
> dollar signs, resulting in unpleasantness like this :
>
> VISUAL="`pwd`/fake-editor.sh"
> VISUAL=${VISUAL//\"/\\\"}
> VISUAL=${VISUAL//$/\\\$}
This is a bashism - that's a big no-no.
> VISUAL=\"$VISUAL\"
> export VISUAL
>
>
> And I'm struggling to come up with neat ways of rewriting things like,
> eg, this bit from t5500 -
> test_expect_success "clone shallow" "git-clone --depth 2
> \"file://`pwd`/.\" shallow"
> - to handle paths like that properly.
These examples expand `pwd` too early. Can't you just put everything inside
single-quotes? Although I'm not sure about VISUAL: Is it invoked with $PWD
that is different from $PWD when VISUAL is defined? If so, then you can
hardly delay `pwd`...
I know I'm a bit anal with my criticism. I reviewed your patch because I
think fixing for paths with whitespace is worthwhile. However, I also think
any fix should go the full way and not only shift the problems into a
different corner. Maybe a word from $maintainer would be in order ;)
-- Hannes
next prev parent reply other threads:[~2007-10-18 6:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 21:13 [PATCH] Fixing path quoting issues Jonathan del Strother
2007-10-11 6:19 ` Johannes Sixt
2007-10-11 6:47 ` David Kastrup
2007-10-11 7:10 ` Johannes Sixt
2007-10-11 7:30 ` Jonathan del Strother
2007-10-11 7:41 ` Johannes Sixt
2007-10-11 20:53 ` David Kastrup
2007-10-11 21:22 ` Jonathan del Strother
2007-10-11 21:31 ` Johannes Schindelin
2007-10-11 21:40 ` David Kastrup
2007-10-12 6:43 ` Johannes Sixt
2007-10-12 11:17 ` Wincent Colaiuta
2007-10-12 11:37 ` Johannes Schindelin
2007-10-12 12:20 ` Wincent Colaiuta
2007-10-12 12:51 ` Johannes Schindelin
2007-10-12 13:14 ` David Kastrup
2007-10-13 18:12 ` Jonathan del Strother
2007-10-13 22:36 ` Andreas Ericsson
2007-10-15 13:13 ` Jonathan del Strother
2007-10-15 13:13 ` [PATCH 1/3] Fixing path quoting in git-rebase Jonathan del Strother
2007-10-15 13:39 ` Johannes Sixt
2007-10-17 9:14 ` Jonathan del Strother
2007-10-17 9:31 ` [PATCH] Quoting paths, take 3 Jonathan del Strother
2007-10-17 9:31 ` [PATCH 1/2] Fixing path quoting in git-rebase Jonathan del Strother
2007-10-17 9:31 ` [PATCH 2/2] Quoting paths in tests Jonathan del Strother
2007-10-17 11:32 ` Johannes Sixt
2007-10-17 17:07 ` Jonathan del Strother
2007-10-17 17:15 ` David Kastrup
2007-10-17 20:03 ` David Kastrup
2007-10-18 6:08 ` Johannes Sixt [this message]
2007-10-24 13:07 ` Jonathan del Strother
2007-10-17 10:41 ` [PATCH 1/2] Fixing path quoting in git-rebase Johannes Sixt
2007-10-15 13:13 ` [PATCH 2/3] Quoting paths in tests Jonathan del Strother
2007-10-15 13:47 ` Johannes Sixt
2007-10-15 14:00 ` Jonathan del Strother
2007-10-15 14:17 ` Johannes Sixt
2007-10-15 14:03 ` David Kastrup
2007-10-15 13:13 ` [PATCH 3/3] Fix apostrophe quoting " Jonathan del Strother
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4716F849.3090102@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=maillist@steelskies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).