git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Jonathan del Strother <maillist@steelskies.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Fixing path quoting issues
Date: Sun, 14 Oct 2007 00:36:27 +0200	[thread overview]
Message-ID: <4711486B.1050301@op5.se> (raw)
In-Reply-To: <92879AC5-2927-439B-8EB0-AC20AAEE412E@steelskies.com>

Jonathan del Strother wrote:
> On 11 Oct 2007, at 07:19, Johannes Sixt wrote:
> 
>>> -     git-commit -F msg -m amending ."
>>> +    git-commit -F msg -m amending ."
>>
>> You fix whitespace...
>>
>>>  test_expect_success \
>>> -    "using message from other commit" \
>>> -    "git-commit -C HEAD^ ."
>>> +     "using message from other commit" \
>>> +     "git-commit -C HEAD^ ."
>>
>> ... and you break it. More of these follow. Don't do that, it makes 
>> patch review unnecessarily hard.
> 
> 
> I'm just preparing to release this patch... was that "don't break 
> whitespace", or "don't try to fix whitespace in a patch that's has 
> nothing to do with whitespacing-fixing" ?
> 

Both, I think ;-)

> And while I'm here - tabs are preferred, are they?  There seem to be a 
> mixture of tabs & 4 space indentation.

1 hard tab / level of indent, but use spaces for continuation alignment.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

  reply	other threads:[~2007-10-13 22:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10 21:13 [PATCH] Fixing path quoting issues Jonathan del Strother
2007-10-11  6:19 ` Johannes Sixt
2007-10-11  6:47   ` David Kastrup
2007-10-11  7:10     ` Johannes Sixt
2007-10-11  7:30       ` Jonathan del Strother
2007-10-11  7:41         ` Johannes Sixt
2007-10-11 20:53           ` David Kastrup
2007-10-11 21:22             ` Jonathan del Strother
2007-10-11 21:31               ` Johannes Schindelin
2007-10-11 21:40                 ` David Kastrup
2007-10-12  6:43               ` Johannes Sixt
2007-10-12 11:17             ` Wincent Colaiuta
2007-10-12 11:37               ` Johannes Schindelin
2007-10-12 12:20                 ` Wincent Colaiuta
2007-10-12 12:51                   ` Johannes Schindelin
2007-10-12 13:14                     ` David Kastrup
2007-10-13 18:12   ` Jonathan del Strother
2007-10-13 22:36     ` Andreas Ericsson [this message]
2007-10-15 13:13       ` Jonathan del Strother
2007-10-15 13:13       ` [PATCH 1/3] Fixing path quoting in git-rebase Jonathan del Strother
2007-10-15 13:39         ` Johannes Sixt
2007-10-17  9:14           ` Jonathan del Strother
2007-10-17  9:31             ` [PATCH] Quoting paths, take 3 Jonathan del Strother
2007-10-17  9:31               ` [PATCH 1/2] Fixing path quoting in git-rebase Jonathan del Strother
2007-10-17  9:31                 ` [PATCH 2/2] Quoting paths in tests Jonathan del Strother
2007-10-17 11:32                   ` Johannes Sixt
2007-10-17 17:07                     ` Jonathan del Strother
2007-10-17 17:15                       ` David Kastrup
2007-10-17 20:03                         ` David Kastrup
2007-10-18  6:08                       ` Johannes Sixt
2007-10-24 13:07                         ` Jonathan del Strother
2007-10-17 10:41                 ` [PATCH 1/2] Fixing path quoting in git-rebase Johannes Sixt
2007-10-15 13:13       ` [PATCH 2/3] Quoting paths in tests Jonathan del Strother
2007-10-15 13:47         ` Johannes Sixt
2007-10-15 14:00           ` Jonathan del Strother
2007-10-15 14:17             ` Johannes Sixt
2007-10-15 14:03           ` David Kastrup
2007-10-15 13:13       ` [PATCH 3/3] Fix apostrophe quoting " Jonathan del Strother
  -- strict thread matches above, loose matches on Subject: below --
2007-10-10 21:22 [PATCH] Fixing path quoting issues maillist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4711486B.1050301@op5.se \
    --to=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=maillist@steelskies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).