* Re: What's cooking in git.git (Nov 2022, #01; Thu, 3)
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
@ 2022-11-05 0:21 ` Philip Oakley
2022-11-05 0:26 ` Taylor Blau
2022-11-07 14:28 ` ab/config-multi-and-nonbool (was: What's cooking in git.git (Nov 2022, #01; Thu, 3)) Ævar Arnfjörð Bjarmason
` (6 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: Philip Oakley @ 2022-11-05 0:21 UTC (permalink / raw)
To: Taylor Blau, git
On 04/11/2022 01:05, Taylor Blau wrote:
> --------------------------------------------------
> [Cooking]
> * po/pretty-hard-trunc (2022-11-02) 1 commit
> - pretty-formats: add hard truncation, without ellipsis, options
>
> Add a new pretty format which truncates without ellipsis.
>
> Missing test coverage.
Is that out of date? V3 did include tests in t4205 and t6006.
> source: <20221102120853.2013-1-philipoakley@iee.email>
This source is the V3.
Philip
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: What's cooking in git.git (Nov 2022, #01; Thu, 3)
2022-11-05 0:21 ` Philip Oakley
@ 2022-11-05 0:26 ` Taylor Blau
2022-11-07 12:19 ` Philip Oakley
0 siblings, 1 reply; 18+ messages in thread
From: Taylor Blau @ 2022-11-05 0:26 UTC (permalink / raw)
To: Philip Oakley; +Cc: Taylor Blau, git
On Sat, Nov 05, 2022 at 12:21:23AM +0000, Philip Oakley wrote:
> On 04/11/2022 01:05, Taylor Blau wrote:
> > --------------------------------------------------
> > [Cooking]
> > * po/pretty-hard-trunc (2022-11-02) 1 commit
> > - pretty-formats: add hard truncation, without ellipsis, options
> >
> > Add a new pretty format which truncates without ellipsis.
> >
> > Missing test coverage.
> Is that out of date? V3 did include tests in t4205 and t6006.
>
> > source: <20221102120853.2013-1-philipoakley@iee.email>
> This source is the V3.
Yes, thanks for catching. Indeed, the version that I have at:
git@github.com:ttaylorr/git.git
on po/pretty-hard-trunc has the new tests. I think we are still waiting
for review on that topic, though...
Thanks,
Taylor
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: What's cooking in git.git (Nov 2022, #01; Thu, 3)
2022-11-05 0:26 ` Taylor Blau
@ 2022-11-07 12:19 ` Philip Oakley
2022-11-08 21:49 ` Taylor Blau
0 siblings, 1 reply; 18+ messages in thread
From: Philip Oakley @ 2022-11-07 12:19 UTC (permalink / raw)
To: Taylor Blau; +Cc: git
On 05/11/2022 00:26, Taylor Blau wrote:
> On Sat, Nov 05, 2022 at 12:21:23AM +0000, Philip Oakley wrote:
>> On 04/11/2022 01:05, Taylor Blau wrote:
>>> --------------------------------------------------
>>> [Cooking]
>>> * po/pretty-hard-trunc (2022-11-02) 1 commit
>>> - pretty-formats: add hard truncation, without ellipsis, options
>>>
>>> Add a new pretty format which truncates without ellipsis.
>>>
>>> Missing test coverage.
>> Is that out of date? V3 did include tests in t4205 and t6006.
>>
>>> source: <20221102120853.2013-1-philipoakley@iee.email>
>> This source is the V3.
> Yes, thanks for catching. Indeed, the version that I have at:
>
> git@github.com:ttaylorr/git.git
>
> on po/pretty-hard-trunc has the new tests. I think we are still waiting
> for review on that topic, though...
>
> Thanks,
> Taylor
An extra review would be useful.
I wasn't certain about the use of `qz_to_tab_space` in the here-doc
formulation of t6006-rev-list-format where some of the new tests now
included trailing spaces (but others didn't).
Ta,
Philip
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: What's cooking in git.git (Nov 2022, #01; Thu, 3)
2022-11-07 12:19 ` Philip Oakley
@ 2022-11-08 21:49 ` Taylor Blau
0 siblings, 0 replies; 18+ messages in thread
From: Taylor Blau @ 2022-11-08 21:49 UTC (permalink / raw)
To: Philip Oakley; +Cc: Taylor Blau, git
On Mon, Nov 07, 2022 at 12:19:22PM +0000, Philip Oakley wrote:
> On 05/11/2022 00:26, Taylor Blau wrote:
> > On Sat, Nov 05, 2022 at 12:21:23AM +0000, Philip Oakley wrote:
> >> On 04/11/2022 01:05, Taylor Blau wrote:
> >>> --------------------------------------------------
> >>> [Cooking]
> >>> * po/pretty-hard-trunc (2022-11-02) 1 commit
> >>> - pretty-formats: add hard truncation, without ellipsis, options
> >>>
> >>> Add a new pretty format which truncates without ellipsis.
> >>>
> >>> Missing test coverage.
> >> Is that out of date? V3 did include tests in t4205 and t6006.
> >>
> >>> source: <20221102120853.2013-1-philipoakley@iee.email>
> >> This source is the V3.
> > Yes, thanks for catching. Indeed, the version that I have at:
> >
> > git@github.com:ttaylorr/git.git
> >
> > on po/pretty-hard-trunc has the new tests. I think we are still waiting
> > for review on that topic, though...
> >
> > Thanks,
> > Taylor
> An extra review would be useful.
>
> I wasn't certain about the use of `qz_to_tab_space` in the here-doc
> formulation of t6006-rev-list-format where some of the new tests now
> included trailing spaces (but others didn't).
Let's wait for a little more review before we start merging this one
down. I'll try and take a look if others don't beat me to it shortly.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 18+ messages in thread
* ab/config-multi-and-nonbool (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
2022-11-05 0:21 ` Philip Oakley
@ 2022-11-07 14:28 ` Ævar Arnfjörð Bjarmason
2022-11-07 14:33 ` ab/make-bin-wrappers " Ævar Arnfjörð Bjarmason
` (5 subsequent siblings)
7 siblings, 0 replies; 18+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-11-07 14:28 UTC (permalink / raw)
To: Taylor Blau; +Cc: git, Junio C Hamano
On Thu, Nov 03 2022, Taylor Blau wrote:
> * ab/config-multi-and-nonbool (2022-11-02) 9 commits
> - for-each-repo: with bad config, don't conflate <path> and <cmd>
> - config API: add "string" version of *_value_multi(), fix segfaults
> - config API users: test for *_get_value_multi() segfaults
> - for-each-repo: error on bad --config
> - config API: have *_multi() return an "int" and take a "dest"
> - versioncmp.c: refactor config reading next commit
> - config tests: add "NULL" tests for *_get_value_multi()
> - config tests: cover blind spots in git_die_config() tests
> - for-each-repo tests: test bad --config keys
>
> A mixed bag of config API updates.
>
> Expecting a reroll.
> cf. <221026.86pmeebcj9.gmgdl@evledraar.gmail.com>
> source: <cover-v2-0.9-00000000000-20221101T225822Z-avarab@gmail.com>
The "mixed bag" part of this comes from Junio's v1 summary[1], which I
think I addressed by narrowing the scope in the v2[2].
Per [3] it looks like you were going to try to find time to take a
second look, *gentle poke* :)
1. https://lore.kernel.org/git/xmqqy1szef49.fsf@gitster.g/
2. https://lore.kernel.org/git/cover-v2-0.9-00000000000-20221101T225822Z-avarab@gmail.com/
3. https://lore.kernel.org/git/Y2G+qczur9eLVtk5@nand.local/
^ permalink raw reply [flat|nested] 18+ messages in thread
* ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
2022-11-05 0:21 ` Philip Oakley
2022-11-07 14:28 ` ab/config-multi-and-nonbool (was: What's cooking in git.git (Nov 2022, #01; Thu, 3)) Ævar Arnfjörð Bjarmason
@ 2022-11-07 14:33 ` Ævar Arnfjörð Bjarmason
2022-11-08 14:27 ` Jeff King
2022-11-07 21:14 ` ab/coccicheck-incremental " Ævar Arnfjörð Bjarmason
` (4 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-11-07 14:33 UTC (permalink / raw)
To: Taylor Blau; +Cc: git, Jeff King
On Thu, Nov 03 2022, Taylor Blau wrote:
> * ab/make-bin-wrappers (2022-10-31) 4 commits
> - Makefile: simplify $(test_bindir_programs) rule by splitting it up
> - Makefile: rename "test_bindir_programs" variable, pre-declare
> - Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier
> - Makefile: factor sed-powered '#!/bin/sh' munging into a variable
>
> Resolve issues with the bin-wrappers/% rules where "make
> bin-wrappers/git" would generate the script but not "git" itself.
>
> Waiting for review.
> source: <cover-v3-0.4-00000000000-20221031T222249Z-avarab@gmail.com>
On my end I'm waiting to see what you and/or Jeff think about:
https://lore.kernel.org/git/221101.86edun5tgn.gmgdl@evledraar.gmail.com/
I.e. i can certainly re-roll with a one-line fix, but don't see how it's
useful to have a "make" target produce a wrapper that doesn't work.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-07 14:33 ` ab/make-bin-wrappers " Ævar Arnfjörð Bjarmason
@ 2022-11-08 14:27 ` Jeff King
2022-11-08 21:52 ` Taylor Blau
0 siblings, 1 reply; 18+ messages in thread
From: Jeff King @ 2022-11-08 14:27 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: Taylor Blau, git
On Mon, Nov 07, 2022 at 03:33:40PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Thu, Nov 03 2022, Taylor Blau wrote:
>
> > * ab/make-bin-wrappers (2022-10-31) 4 commits
> > - Makefile: simplify $(test_bindir_programs) rule by splitting it up
> > - Makefile: rename "test_bindir_programs" variable, pre-declare
> > - Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier
> > - Makefile: factor sed-powered '#!/bin/sh' munging into a variable
> >
> > Resolve issues with the bin-wrappers/% rules where "make
> > bin-wrappers/git" would generate the script but not "git" itself.
> >
> > Waiting for review.
> > source: <cover-v3-0.4-00000000000-20221031T222249Z-avarab@gmail.com>
>
> On my end I'm waiting to see what you and/or Jeff think about:
> https://lore.kernel.org/git/221101.86edun5tgn.gmgdl@evledraar.gmail.com/
I don't have any strong opinion on that. I read the v2 cover letter, was
skeptical/confused of the motivation, and didn't go much further.
Your explanation in the linked email is that there are _other_ reasons
to do this refactoring, but I don't have any knowledge there that would
add to the review. My gut is still that building bin-wrappers/foo
doesn't need to depend on foo, but if it's one line, I don't care that
much either way. If it was 50 lines of complicated Makefile refactoring,
then would probably not be worth it.
-Peff
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-08 14:27 ` Jeff King
@ 2022-11-08 21:52 ` Taylor Blau
2022-11-09 14:04 ` Jeff King
0 siblings, 1 reply; 18+ messages in thread
From: Taylor Blau @ 2022-11-08 21:52 UTC (permalink / raw)
To: Jeff King; +Cc: Ævar Arnfjörð Bjarmason, Taylor Blau, git
On Tue, Nov 08, 2022 at 09:27:50AM -0500, Jeff King wrote:
> On Mon, Nov 07, 2022 at 03:33:40PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> >
> > On Thu, Nov 03 2022, Taylor Blau wrote:
> >
> > > * ab/make-bin-wrappers (2022-10-31) 4 commits
> > > - Makefile: simplify $(test_bindir_programs) rule by splitting it up
> > > - Makefile: rename "test_bindir_programs" variable, pre-declare
> > > - Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier
> > > - Makefile: factor sed-powered '#!/bin/sh' munging into a variable
> > >
> > > Resolve issues with the bin-wrappers/% rules where "make
> > > bin-wrappers/git" would generate the script but not "git" itself.
> > >
> > > Waiting for review.
> > > source: <cover-v3-0.4-00000000000-20221031T222249Z-avarab@gmail.com>
> >
> > On my end I'm waiting to see what you and/or Jeff think about:
> > https://lore.kernel.org/git/221101.86edun5tgn.gmgdl@evledraar.gmail.com/
>
> I don't have any strong opinion on that. I read the v2 cover letter, was
> skeptical/confused of the motivation, and didn't go much further.
>
> Your explanation in the linked email is that there are _other_ reasons
> to do this refactoring, but I don't have any knowledge there that would
> add to the review. My gut is still that building bin-wrappers/foo
> doesn't need to depend on foo, but if it's one line, I don't care that
> much either way. If it was 50 lines of complicated Makefile refactoring,
> then would probably not be worth it.
Isn't this topic exactly the latter? IOW:
$ git diff --stat master...ab/make-bin-wrappers
Makefile | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------
1 file changed, 52 insertions(+), 20 deletions(-)
...maybe that was exactly your point ;-).
TBH, I am not sold whatsoever on the premise of that series, and agree
that plodding through 50+ lines of complicated Makefile diff is
difficult to justify when the premise is hazy to me.
Ævar, any strong objections against dropping this one? If there is a
simpler way forward, I'm all ears, but in the meantime I find it
difficult to justify the review time as-is.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-08 21:52 ` Taylor Blau
@ 2022-11-09 14:04 ` Jeff King
0 siblings, 0 replies; 18+ messages in thread
From: Jeff King @ 2022-11-09 14:04 UTC (permalink / raw)
To: Taylor Blau; +Cc: Ævar Arnfjörð Bjarmason, git
On Tue, Nov 08, 2022 at 04:52:44PM -0500, Taylor Blau wrote:
> > I don't have any strong opinion on that. I read the v2 cover letter, was
> > skeptical/confused of the motivation, and didn't go much further.
> >
> > Your explanation in the linked email is that there are _other_ reasons
> > to do this refactoring, but I don't have any knowledge there that would
> > add to the review. My gut is still that building bin-wrappers/foo
> > doesn't need to depend on foo, but if it's one line, I don't care that
> > much either way. If it was 50 lines of complicated Makefile refactoring,
> > then would probably not be worth it.
>
> Isn't this topic exactly the latter? IOW:
>
> $ git diff --stat master...ab/make-bin-wrappers
> Makefile | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------
> 1 file changed, 52 insertions(+), 20 deletions(-)
>
> ...maybe that was exactly your point ;-).
Sorry, I perhaps could have made the last sentence more clear as:
If it was 50 lines of complicated Makefile refactoring _just_ to have
"make bin-wrappers/foo" depend on "foo", it would not be worth it. But
if it is doing something else, it might be. I don't have a strong
opinion because I haven't (and don't want to have) looked into that
"something else".
-Peff
^ permalink raw reply [flat|nested] 18+ messages in thread
* ab/coccicheck-incremental (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
` (2 preceding siblings ...)
2022-11-07 14:33 ` ab/make-bin-wrappers " Ævar Arnfjörð Bjarmason
@ 2022-11-07 21:14 ` Ævar Arnfjörð Bjarmason
2022-11-08 21:53 ` Taylor Blau
2022-11-07 21:24 ` ab/sha-makefile-doc " Ævar Arnfjörð Bjarmason
` (3 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-11-07 21:14 UTC (permalink / raw)
To: Taylor Blau; +Cc: git
On Thu, Nov 03 2022, Taylor Blau wrote:
> * ab/coccicheck-incremental (2022-11-02) 13 commits
> - spatchcache: add a ccache-alike for "spatch"
> - cocci: run against a generated ALL.cocci
> - cocci rules: remove <id>'s from rules that don't need them
> - Makefile: copy contrib/coccinelle/*.cocci to build/
> - cocci: optimistically use COMPUTE_HEADER_DEPENDENCIES
> - cocci: make "coccicheck" rule incremental
> - cocci: split off "--all-includes" from SPATCH_FLAGS
> - cocci: split off include-less "tests" from SPATCH_FLAGS
> - Makefile: split off SPATCH_BATCH_SIZE comment from "cocci" heading
> - Makefile: have "coccicheck" re-run if flags change
> - Makefile: add ability to TAB-complete cocci *.patch rules
> - cocci rules: remove unused "F" metavariable from pending rule
> - Makefile + shared.mak: rename and indent $(QUIET_SPATCH_T)
>
> "make coccicheck" is time consuming. It has been made to run more
> incrementally.
>
> Will merge to 'next'?
> source: <cover-v5-00.13-00000000000-20221101T222616Z-avarab@gmail.com>
I think it's ready for that, the v5 having hopefully solved any last
remaining nits / issues.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: ab/coccicheck-incremental (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-07 21:14 ` ab/coccicheck-incremental " Ævar Arnfjörð Bjarmason
@ 2022-11-08 21:53 ` Taylor Blau
0 siblings, 0 replies; 18+ messages in thread
From: Taylor Blau @ 2022-11-08 21:53 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: Taylor Blau, git
On Mon, Nov 07, 2022 at 10:14:28PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Thu, Nov 03 2022, Taylor Blau wrote:
>
> > * ab/coccicheck-incremental (2022-11-02) 13 commits
> > - spatchcache: add a ccache-alike for "spatch"
> > - cocci: run against a generated ALL.cocci
> > - cocci rules: remove <id>'s from rules that don't need them
> > - Makefile: copy contrib/coccinelle/*.cocci to build/
> > - cocci: optimistically use COMPUTE_HEADER_DEPENDENCIES
> > - cocci: make "coccicheck" rule incremental
> > - cocci: split off "--all-includes" from SPATCH_FLAGS
> > - cocci: split off include-less "tests" from SPATCH_FLAGS
> > - Makefile: split off SPATCH_BATCH_SIZE comment from "cocci" heading
> > - Makefile: have "coccicheck" re-run if flags change
> > - Makefile: add ability to TAB-complete cocci *.patch rules
> > - cocci rules: remove unused "F" metavariable from pending rule
> > - Makefile + shared.mak: rename and indent $(QUIET_SPATCH_T)
> >
> > "make coccicheck" is time consuming. It has been made to run more
> > incrementally.
> >
> > Will merge to 'next'?
> > source: <cover-v5-00.13-00000000000-20221101T222616Z-avarab@gmail.com>
>
> I think it's ready for that, the v5 having hopefully solved any last
> remaining nits / issues.
Yep, let's start merging this one down.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 18+ messages in thread
* ab/sha-makefile-doc (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
` (3 preceding siblings ...)
2022-11-07 21:14 ` ab/coccicheck-incremental " Ævar Arnfjörð Bjarmason
@ 2022-11-07 21:24 ` Ævar Arnfjörð Bjarmason
2022-11-08 14:13 ` ab/submodule-helper-prep-only " Ævar Arnfjörð Bjarmason
` (2 subsequent siblings)
7 siblings, 0 replies; 18+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-11-07 21:24 UTC (permalink / raw)
To: Taylor Blau; +Cc: git
On Thu, Nov 03 2022, Taylor Blau wrote:
> * ab/sha-makefile-doc (2022-10-26) 9 commits
> - Makefile: discuss SHAttered in *_SHA{1,256} discussion
> - Makefile: document default SHA-1 backend on OSX
> - Makefile: document SHA-1 and SHA-256 default and selection order
> - Makefile: document default SHA-256 backend
> - Makefile: rephrase the discussion of *_SHA1 knobs
> - Makefile: create and use sections for "define" flag listing
> - Makefile: correct DC_SHA1 documentation
> - INSTALL: remove discussion of SHA-1 backends
> - Makefile: always (re)set DC_SHA1 on fallback
>
> Makefile comments updates and reordering to clarify knobs used to
> choose SHA implementations.
>
> Will merge to 'next'?
> source: <cover-v4-0.9-00000000000-20221026T145255Z-avarab@gmail.com>
There was one outstanding issue from Junio noted in the v4, I just sent
a v5 in that should address that & more:
https://lore.kernel.org/git/cover-v5-00.10-00000000000-20221107T211736Z-avarab@gmail.com/
So hopefully with that it's ready for 'next'. I have a trivial patch
queued after it to flip the default on OSX to use
sha1collisiondetection.
^ permalink raw reply [flat|nested] 18+ messages in thread
* ab/submodule-helper-prep-only (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
` (4 preceding siblings ...)
2022-11-07 21:24 ` ab/sha-makefile-doc " Ævar Arnfjörð Bjarmason
@ 2022-11-08 14:13 ` Ævar Arnfjörð Bjarmason
2022-11-08 22:04 ` Taylor Blau
2022-11-08 14:14 ` ab/cmake-nix-and-ci " Ævar Arnfjörð Bjarmason
2022-11-08 14:22 ` ab/misc-hook-submodule-run-command " Ævar Arnfjörð Bjarmason
7 siblings, 1 reply; 18+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-11-08 14:13 UTC (permalink / raw)
To: Taylor Blau; +Cc: git, Glen Choo
On Thu, Nov 03 2022, Taylor Blau wrote:
> * ab/submodule-helper-prep-only (2022-11-02) 8 commits
> - submodule--helper: use OPT_SUBCOMMAND() API
> - submodule--helper: drop "update --prefix <pfx>" for "-C <pfx> update"
> - submodule--helper: remove --prefix from "absorbgitdirs"
> - submodule API & "absorbgitdirs": remove "----recursive" option
> - submodule.c: refactor recursive block out of absorb function
> - submodule tests: test for a "foreach" blind-spot
> - submodule tests: add tests for top-level flag output
> - submodule--helper: move "config" to a test-tool
>
> Preparation to remove git-submodule.sh and replace it with a builtin.
>
> Waiting for review?
> source: <cover-0.8-00000000000-20221102T074148Z-avarab@gmail.com>
It was waiting on a small re-roll I just sent in:
https://lore.kernel.org/git/cover-v2-0.9-00000000000-20221108T140501Z-avarab@gmail.com/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: ab/submodule-helper-prep-only (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-08 14:13 ` ab/submodule-helper-prep-only " Ævar Arnfjörð Bjarmason
@ 2022-11-08 22:04 ` Taylor Blau
0 siblings, 0 replies; 18+ messages in thread
From: Taylor Blau @ 2022-11-08 22:04 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: Taylor Blau, git, Glen Choo
On Tue, Nov 08, 2022 at 03:13:23PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Thu, Nov 03 2022, Taylor Blau wrote:
>
> > * ab/submodule-helper-prep-only (2022-11-02) 8 commits
> > - submodule--helper: use OPT_SUBCOMMAND() API
> > - submodule--helper: drop "update --prefix <pfx>" for "-C <pfx> update"
> > - submodule--helper: remove --prefix from "absorbgitdirs"
> > - submodule API & "absorbgitdirs": remove "----recursive" option
> > - submodule.c: refactor recursive block out of absorb function
> > - submodule tests: test for a "foreach" blind-spot
> > - submodule tests: add tests for top-level flag output
> > - submodule--helper: move "config" to a test-tool
> >
> > Preparation to remove git-submodule.sh and replace it with a builtin.
> >
> > Waiting for review?
> > source: <cover-0.8-00000000000-20221102T074148Z-avarab@gmail.com>
>
> It was waiting on a small re-roll I just sent in:
> https://lore.kernel.org/git/cover-v2-0.9-00000000000-20221108T140501Z-avarab@gmail.com/
Thanks. I took the updated round and I think that this is ready to start
merging down per Glen's review.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 18+ messages in thread
* ab/cmake-nix-and-ci (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
` (5 preceding siblings ...)
2022-11-08 14:13 ` ab/submodule-helper-prep-only " Ævar Arnfjörð Bjarmason
@ 2022-11-08 14:14 ` Ævar Arnfjörð Bjarmason
2022-11-08 14:49 ` Phillip Wood
2022-11-08 14:22 ` ab/misc-hook-submodule-run-command " Ævar Arnfjörð Bjarmason
7 siblings, 1 reply; 18+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-11-08 14:14 UTC (permalink / raw)
To: Taylor Blau; +Cc: git, Phillip Wood
On Thu, Nov 03 2022, Taylor Blau wrote:
> * ab/cmake-nix-and-ci (2022-11-02) 12 commits
> - CI: add a "linux-cmake-test" to run cmake & ctest on linux
> - cmake: copy over git-p4.py for t983[56] perforce test
> - cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults
> - Makefile + cmake: use environment, not GIT-BUILD-DIR
> - test-lib.sh: support a "GIT_TEST_BUILD_DIR"
> - cmake: set "USE_LIBPCRE2" in "GIT-BUILD-OPTIONS" for test-lib.sh
> - cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable
> - cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4
> - cmake: don't copy chainlint.pl to build directory
> - cmake: update instructions for portable CMakeLists.txt
> - cmake: don't "mkdir -p" and "cd" in build instructions
> - cmake: increase test timeout on Windows only
>
> Fix assorted issues with CTest on *nix machines.
>
> Waiting for review.
> source: <cover-v3-00.12-00000000000-20221101T225022Z-avarab@gmail.com>
I think the v4[1] you've since picked up should be ready, and I think
addressed the outstanding comments, except as noted in "let's pursue
that separately" in [2].
1. https://lore.kernel.org/git/cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com/
2. https://lore.kernel.org/git/221103.86a6581129.gmgdl@evledraar.gmail.com/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: ab/cmake-nix-and-ci (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-08 14:14 ` ab/cmake-nix-and-ci " Ævar Arnfjörð Bjarmason
@ 2022-11-08 14:49 ` Phillip Wood
0 siblings, 0 replies; 18+ messages in thread
From: Phillip Wood @ 2022-11-08 14:49 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason, Taylor Blau; +Cc: git, Phillip Wood
On 08/11/2022 14:14, Ævar Arnfjörð Bjarmason wrote:
>
> On Thu, Nov 03 2022, Taylor Blau wrote:
>
>> * ab/cmake-nix-and-ci (2022-11-02) 12 commits
>> - CI: add a "linux-cmake-test" to run cmake & ctest on linux
>> - cmake: copy over git-p4.py for t983[56] perforce test
>> - cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults
>> - Makefile + cmake: use environment, not GIT-BUILD-DIR
>> - test-lib.sh: support a "GIT_TEST_BUILD_DIR"
>> - cmake: set "USE_LIBPCRE2" in "GIT-BUILD-OPTIONS" for test-lib.sh
>> - cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable
>> - cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4
>> - cmake: don't copy chainlint.pl to build directory
>> - cmake: update instructions for portable CMakeLists.txt
>> - cmake: don't "mkdir -p" and "cd" in build instructions
>> - cmake: increase test timeout on Windows only
>>
>> Fix assorted issues with CTest on *nix machines.
>>
>> Waiting for review.
>> source: <cover-v3-00.12-00000000000-20221101T225022Z-avarab@gmail.com>
>
> I think the v4[1] you've since picked up should be ready, and I think
> addressed the outstanding comments, except as noted in "let's pursue
> that separately" in [2].
I think we need to wait for someone with windows experience to look at
this as that is the primary use of the cmake build. Without that I think
patches 4(?), 5 and 7 are still could go forward as a separate series
but the rest of the patches including the documentation and test changes
need to have buy-in from their primary audience.
Best Wishes
Phillip
> 1. https://lore.kernel.org/git/cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com/
> 2. https://lore.kernel.org/git/221103.86a6581129.gmgdl@evledraar.gmail.com/
^ permalink raw reply [flat|nested] 18+ messages in thread
* ab/misc-hook-submodule-run-command (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
` (6 preceding siblings ...)
2022-11-08 14:14 ` ab/cmake-nix-and-ci " Ævar Arnfjörð Bjarmason
@ 2022-11-08 14:22 ` Ævar Arnfjörð Bjarmason
7 siblings, 0 replies; 18+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-11-08 14:22 UTC (permalink / raw)
To: Taylor Blau; +Cc: git
On Thu, Nov 03 2022, Taylor Blau wrote:
> * ab/misc-hook-submodule-run-command (2022-10-31) 3 commits
> (merged to 'next' on 2022-11-03 at 0f01b25561)
> + run-command tests: test stdout of run_command_parallel()
> + submodule tests: reset "trace.out" between "grep" invocations
> + hook tests: fix redirection logic error in 96e7225b310
>
> Various test updates.
>
> Waiting for review.
> source: <cover-0.3-00000000000-20221029T025520Z-avarab@gmail.com>
Per [1] that's a stale comment, and you'd decided on a "let's merge this
down".
1. https://lore.kernel.org/git/Y2Kn5MVQojz33cta@nand.local/
^ permalink raw reply [flat|nested] 18+ messages in thread