git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Taylor Blau" <me@ttaylorr.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: ab/cmake-nix-and-ci (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
Date: Tue, 8 Nov 2022 14:49:27 +0000	[thread overview]
Message-ID: <64b91b29-bbcd-e946-1f20-c0a5be63d9b7@dunelm.org.uk> (raw)
In-Reply-To: <221108.86cz9xsf1w.gmgdl@evledraar.gmail.com>

On 08/11/2022 14:14, Ævar Arnfjörð Bjarmason wrote:
> 
> On Thu, Nov 03 2022, Taylor Blau wrote:
> 
>> * ab/cmake-nix-and-ci (2022-11-02) 12 commits
>>   - CI: add a "linux-cmake-test" to run cmake & ctest on linux
>>   - cmake: copy over git-p4.py for t983[56] perforce test
>>   - cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults
>>   - Makefile + cmake: use environment, not GIT-BUILD-DIR
>>   - test-lib.sh: support a "GIT_TEST_BUILD_DIR"
>>   - cmake: set "USE_LIBPCRE2" in "GIT-BUILD-OPTIONS" for test-lib.sh
>>   - cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable
>>   - cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4
>>   - cmake: don't copy chainlint.pl to build directory
>>   - cmake: update instructions for portable CMakeLists.txt
>>   - cmake: don't "mkdir -p" and "cd" in build instructions
>>   - cmake: increase test timeout on Windows only
>>
>>   Fix assorted issues with CTest on *nix machines.
>>
>>   Waiting for review.
>>   source: <cover-v3-00.12-00000000000-20221101T225022Z-avarab@gmail.com>
> 
> I think the v4[1] you've since picked up should be ready, and I think
> addressed the outstanding comments, except as noted in "let's pursue
> that separately" in [2].

I think we need to wait for someone with windows experience to look at 
this as that is the primary use of the cmake build. Without that I think 
  patches 4(?), 5 and 7 are still could go forward as a separate series 
but the rest of the patches including the documentation and test changes 
need to have buy-in from their primary audience.

Best Wishes

Phillip


> 1. https://lore.kernel.org/git/cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com/
> 2. https://lore.kernel.org/git/221103.86a6581129.gmgdl@evledraar.gmail.com/

  reply	other threads:[~2022-11-08 14:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04  1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
2022-11-05  0:21 ` Philip Oakley
2022-11-05  0:26   ` Taylor Blau
2022-11-07 12:19     ` Philip Oakley
2022-11-08 21:49       ` Taylor Blau
2022-11-07 14:28 ` ab/config-multi-and-nonbool (was: What's cooking in git.git (Nov 2022, #01; Thu, 3)) Ævar Arnfjörð Bjarmason
2022-11-07 14:33 ` ab/make-bin-wrappers " Ævar Arnfjörð Bjarmason
2022-11-08 14:27   ` Jeff King
2022-11-08 21:52     ` Taylor Blau
2022-11-09 14:04       ` Jeff King
2022-11-07 21:14 ` ab/coccicheck-incremental " Ævar Arnfjörð Bjarmason
2022-11-08 21:53   ` Taylor Blau
2022-11-07 21:24 ` ab/sha-makefile-doc " Ævar Arnfjörð Bjarmason
2022-11-08 14:13 ` ab/submodule-helper-prep-only " Ævar Arnfjörð Bjarmason
2022-11-08 22:04   ` Taylor Blau
2022-11-08 14:14 ` ab/cmake-nix-and-ci " Ævar Arnfjörð Bjarmason
2022-11-08 14:49   ` Phillip Wood [this message]
2022-11-08 14:22 ` ab/misc-hook-submodule-run-command " Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64b91b29-bbcd-e946-1f20-c0a5be63d9b7@dunelm.org.uk \
    --to=phillip.wood123@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).